On 5/5/19 4:07 AM, Karsten Merker wrote:

On Wed, May 01, 2019 at 01:07:31PM -0700, Atish Patra wrote:

...

This patch adds booti support for RISC-V Linux kernel. The existing bootm method will also continue to work as it is.

It depends on the following kernel patch which adds the header to the flat Image. Gzip compressed Image (Image.gz) support is not enabled with this patch.

https://patchwork.kernel.org/patch/10925543/

Tested on HiFive Unleashed and QEMU.

Signed-off-by: Atish Patra atish.patra@wdc.com

Hello,

the patch (both directly from my inbox as well as from patchwork) appears to be mangled and doesn't apply cleanly:

Applying: RISCV: image: Add booti support. error: patch failed: cmd/booti.c:77 error: cmd/booti.c: patch does not apply Patch failed at 0001 RISCV: image: Add booti support.

I have fixed the patch and sent a v4. That should cleanly apply on top of master.

I have manually applied the changes on top of 2019.07-rc1 and run a number of tests together with the corresponding kernel patch (https://patchwork.kernel.org/patch/10925543/). With the patch applied I can successfully boot a kernel and an initramfs with booti on a qemu-system-riscv64 "virt" machine:

Thanks for testing the patch.

Regards, Atish

OpenSBI v0.3 (May 4 2019 20:32:00) ____ _____ ____ _____ / __ \ / ____| _ _ _| | | | |_ __ ___ _ __ | (___ | |_) || | | | | | '_ \ / _ \ '_ \ ___ | _ < | | | |__| | |_) | __/ | | |____) | |_) || |_ ____/| .__/ ___|_| |_|_____/|____/_____| | | |_|

Platform Name : QEMU Virt Machine Platform HART Features : RV64ACDFIMSU Platform Max HARTs : 8 Current Hart : 0 Firmware Base : 0x80000000 Firmware Size : 100 KB Runtime SBI Version : 0.1

PMP0: 0x0000000080000000-0x000000008001ffff (A) PMP1: 0x0000000000000000-0xffffffffffffffff (A,R,W,X)

U-Boot 2019.07-rc1-00001-g6b6a8d27ea-dirty (May 05 2019 - 01:05:15 +0200)

CPU: rv64imafdcsu Model: riscv-virtio,qemu DRAM: 8 GiB In: uart@10000000 Out: uart@10000000 Err: uart@10000000 Net: Warning: virtio-net#2 using MAC address from ROM eth0: virtio-net#2 Hit any key to stop autoboot: 0 => load virtio 0:1 ${kernel_addr_r} /boot/vmlinux-5.0.0-trunk-riscv64 9073676 bytes read in 5 ms (1.7 GiB/s) => load virtio 0:1 ${ramdisk_addr_r} /boot/initrd.img-5.0.0-trunk-riscv64 45823535 bytes read in 14 ms (3 GiB/s) => booti ${kernel_addr_r} ${ramdisk_addr_r}:${filesize} ${fdtcontroladdr} ## Flattened Device Tree blob at ff77bd30 Booting using the fdt blob at 0xff77bd30 Using Device Tree in place at 00000000ff77bd30, end 00000000ff77fda5

Starting kernel ...

[ 0.000000] OF: fdt: Ignoring memory range 0x80000000 - 0x80200000 [ 0.000000] No DTB passed to the kernel [ 0.000000] Linux version 5.0.0-trunk-riscv64 (debian-kernel@lists.debian.org) (gcc version 8.3.0 (Debian 8.3.0-7)) #1 SMP Debian 5.0.10-1~exp1 (2019-03-22) [ 0.000000] Initial ramdisk at: 0x(____ptrval____) (45823535 bytes) [...]

Tested-by: Karsten Merker merker@debian.org

Regards, Karsten