[PATCH] configs: rk3588: rename defconfig for rock-5b
it should be rock-5b-rk3588_defconfig.
Signed-off-by: FUKAUMI Naoki naoki@radxa.com --- configs/{rock5b-rk3588_defconfig => rock-5b-rk3588_defconfig} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename configs/{rock5b-rk3588_defconfig => rock-5b-rk3588_defconfig} (100%)
diff --git a/configs/rock5b-rk3588_defconfig b/configs/rock-5b-rk3588_defconfig similarity index 100% rename from configs/rock5b-rk3588_defconfig rename to configs/rock-5b-rk3588_defconfig
Hi,
On 2023/4/8 17:33, FUKAUMI Naoki wrote:
it should be rock-5b-rk3588_defconfig.
Why it should be rock-5b?
Its seems rock pi has many boards and with different name, I thinks rock5b is a reasonable config name
because there is no name rule for rock pi boards till now.
configs/rockpro64-rk3399_defconfig configs/rock_defconfig configs/rock-pi-s-rk3308_defconfig configs/rock-pi-e-rk3328_defconfig configs/rock5b-rk3588_defconfig configs/rock2_defconfig configs/rock64-rk3328_defconfig configs/rock-pi-4-rk3399_defconfig configs/rock-pi-4c-rk3399_defconfig configs/rock-pi-n10-rk3399pro_defconfig configs/rock960-rk3399_defconfig configs/rock-3a-rk3568_defconfig configs/rock-pi-n8-rk3288_defconfig
Thanks,
- Kever
Signed-off-by: FUKAUMI Naoki naoki@radxa.com
configs/{rock5b-rk3588_defconfig => rock-5b-rk3588_defconfig} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename configs/{rock5b-rk3588_defconfig => rock-5b-rk3588_defconfig} (100%)
diff --git a/configs/rock5b-rk3588_defconfig b/configs/rock-5b-rk3588_defconfig similarity index 100% rename from configs/rock5b-rk3588_defconfig rename to configs/rock-5b-rk3588_defconfig
Hi,
On 4/10/23 12:12, Kever Yang wrote:
Hi,
On 2023/4/8 17:33, FUKAUMI Naoki wrote:
it should be rock-5b-rk3588_defconfig.
Why it should be rock-5b?
Its seems rock pi has many boards and with different name, I thinks rock5b is a reasonable config name
because there is no name rule for rock pi boards till now.
configs/rockpro64-rk3399_defconfig configs/rock64-rk3328_defconfig configs/rock960-rk3399_defconfig
above 3 are not made by Radxa. please ignore for now.
configs/rock_defconfig configs/rock2_defconfig
above 2 are made by Radxa. but very old, no name rule.
configs/rock-pi-s-rk3308_defconfig configs/rock-pi-e-rk3328_defconfig configs/rock5b-rk3588_defconfig configs/rock-pi-4-rk3399_defconfig configs/rock-pi-4c-rk3399_defconfig configs/rock-pi-n10-rk3399pro_defconfig configs/rock-3a-rk3568_defconfig configs/rock-pi-n8-rk3288_defconfig
$ grep -h CONFIG_DEFAULT_DEVICE_TREE configs/*rock* CONFIG_DEFAULT_DEVICE_TREE="rk3288-rock2-square" CONFIG_DEFAULT_DEVICE_TREE="rk3568-rock-3a" CONFIG_DEFAULT_DEVICE_TREE="rk3588-rock-5b" CONFIG_DEFAULT_DEVICE_TREE="rk3328-rock64" CONFIG_DEFAULT_DEVICE_TREE="rk3399-rock960" CONFIG_DEFAULT_DEVICE_TREE="rk3188-radxarock" CONFIG_DEFAULT_DEVICE_TREE="rk3399-rock-pi-4c" CONFIG_DEFAULT_DEVICE_TREE="rk3399-rock-pi-4b" CONFIG_DEFAULT_DEVICE_TREE="rk3328-rock-pi-e" CONFIG_DEFAULT_DEVICE_TREE="rk3399pro-rock-pi-n10" CONFIG_DEFAULT_DEVICE_TREE="rk3288-rock-pi-n8" CONFIG_DEFAULT_DEVICE_TREE="rk3308-rock-pi-s" CONFIG_DEFAULT_DEVICE_TREE="rk3399-rockpro64"
I think "rock-5b" is better than "rock5b".
-- FUKAUMI Naoki
Thanks,
- Kever
Signed-off-by: FUKAUMI Naoki naoki@radxa.com
configs/{rock5b-rk3588_defconfig => rock-5b-rk3588_defconfig} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename configs/{rock5b-rk3588_defconfig => rock-5b-rk3588_defconfig} (100%)
diff --git a/configs/rock5b-rk3588_defconfig b/configs/rock-5b-rk3588_defconfig similarity index 100% rename from configs/rock5b-rk3588_defconfig rename to configs/rock-5b-rk3588_defconfig
participants (2)
-
FUKAUMI Naoki -
Kever Yang