[U-Boot] [PATCH v2 1/2] MX28: mx28evk: Align SSP clock speed
Align the SSP clock speed with oscilator to achieve higher transfer stability.
Signed-off-by: Otavio Salvador otavio@ossystems.com.br --- Changes in v2: - reword commit log to match the change description done on m28evk.
board/freescale/mx28evk/mx28evk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/board/freescale/mx28evk/mx28evk.c b/board/freescale/mx28evk/mx28evk.c index 867d3c8..d782aea 100644 --- a/board/freescale/mx28evk/mx28evk.c +++ b/board/freescale/mx28evk/mx28evk.c @@ -49,8 +49,8 @@ int board_early_init_f(void)
/* SSP0 clock at 96MHz */ mx28_set_sspclk(MXC_SSPCLK0, 96000, 0); - /* SSP2 clock at 96MHz */ - mx28_set_sspclk(MXC_SSPCLK2, 96000, 0); + /* SSP2 clock at 160MHz */ + mx28_set_sspclk(MXC_SSPCLK2, 160000, 0);
#ifdef CONFIG_CMD_USB mxs_iomux_setup_pad(MX28_PAD_SSP2_SS1__USB1_OVERCURRENT);
Signed-off-by: Otavio Salvador otavio@ossystems.com.br --- Changes in v2: - new patch
include/configs/mx28evk.h | 1 + 1 file changed, 1 insertion(+)
diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h index 8d83495..a5a98fb 100644 --- a/include/configs/mx28evk.h +++ b/include/configs/mx28evk.h @@ -200,6 +200,7 @@ #ifdef CONFIG_CMD_SPI #define CONFIG_HARD_SPI #define CONFIG_MXS_SPI +#define CONFIG_MXS_SPI_DMA_ENABLE #define CONFIG_SPI_HALF_DUPLEX #define CONFIG_DEFAULT_SPI_BUS 2 #define CONFIG_DEFAULT_SPI_MODE SPI_MODE_0
On 28/08/2012 11:56, Otavio Salvador wrote:
Signed-off-by: Otavio Salvador otavio@ossystems.com.br
Applied to u-boot-imx, thanks.
Best regards, Stefano Babic
Dear Otavio Salvador,
Align the SSP clock speed with oscilator to achieve higher transfer stability.
This change is still pointless, unless you have user for this!
Signed-off-by: Otavio Salvador otavio@ossystems.com.br
Changes in v2:
- reword commit log to match the change description done on m28evk.
board/freescale/mx28evk/mx28evk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/board/freescale/mx28evk/mx28evk.c b/board/freescale/mx28evk/mx28evk.c index 867d3c8..d782aea 100644 --- a/board/freescale/mx28evk/mx28evk.c +++ b/board/freescale/mx28evk/mx28evk.c @@ -49,8 +49,8 @@ int board_early_init_f(void)
/* SSP0 clock at 96MHz */ mx28_set_sspclk(MXC_SSPCLK0, 96000, 0);
- /* SSP2 clock at 96MHz */
- mx28_set_sspclk(MXC_SSPCLK2, 96000, 0);
- /* SSP2 clock at 160MHz */
- mx28_set_sspclk(MXC_SSPCLK2, 160000, 0);
#ifdef CONFIG_CMD_USB mxs_iomux_setup_pad(MX28_PAD_SSP2_SS1__USB1_OVERCURRENT);
Best regards, Marek Vasut
On Tue, Aug 28, 2012 at 7:18 AM, Marek Vasut marek.vasut@gmail.com wrote:
Dear Otavio Salvador,
Align the SSP clock speed with oscilator to achieve higher transfer stability.
This change is still pointless, unless you have user for this!
As far as I know the SPI flash uses SSP2; so it is a user of it.
Signed-off-by: Otavio Salvador otavio@ossystems.com.br
Changes in v2:
- reword commit log to match the change description done on m28evk.
board/freescale/mx28evk/mx28evk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/board/freescale/mx28evk/mx28evk.c b/board/freescale/mx28evk/mx28evk.c index 867d3c8..d782aea 100644 --- a/board/freescale/mx28evk/mx28evk.c +++ b/board/freescale/mx28evk/mx28evk.c @@ -49,8 +49,8 @@ int board_early_init_f(void)
/* SSP0 clock at 96MHz */ mx28_set_sspclk(MXC_SSPCLK0, 96000, 0);
/* SSP2 clock at 96MHz */mx28_set_sspclk(MXC_SSPCLK2, 96000, 0);
/* SSP2 clock at 160MHz */mx28_set_sspclk(MXC_SSPCLK2, 160000, 0);#ifdef CONFIG_CMD_USB mxs_iomux_setup_pad(MX28_PAD_SSP2_SS1__USB1_OVERCURRENT);
Best regards, Marek Vasut
Dear Otavio Salvador,
On Tue, Aug 28, 2012 at 7:18 AM, Marek Vasut marek.vasut@gmail.com wrote:
Dear Otavio Salvador,
Align the SSP clock speed with oscilator to achieve higher transfer stability.
This change is still pointless, unless you have user for this!
As far as I know the SPI flash uses SSP2; so it is a user of it.
So, why dont you also align the default clockspeed of the spi flash attached to ssp2 in the config file within this patch?
Lemme answer myself after taking a look ... because that's already done.
Ok,
Acked-by: Marek Vasut marex@denx.de
Signed-off-by: Otavio Salvador otavio@ossystems.com.br
Changes in v2:
- reword commit log to match the change description done on m28evk.
board/freescale/mx28evk/mx28evk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/board/freescale/mx28evk/mx28evk.c b/board/freescale/mx28evk/mx28evk.c index 867d3c8..d782aea 100644 --- a/board/freescale/mx28evk/mx28evk.c +++ b/board/freescale/mx28evk/mx28evk.c @@ -49,8 +49,8 @@ int board_early_init_f(void)
/* SSP0 clock at 96MHz */ mx28_set_sspclk(MXC_SSPCLK0, 96000, 0);
/* SSP2 clock at 96MHz */mx28_set_sspclk(MXC_SSPCLK2, 96000, 0);
/* SSP2 clock at 160MHz */mx28_set_sspclk(MXC_SSPCLK2, 160000, 0);#ifdef CONFIG_CMD_USB
mxs_iomux_setup_pad(MX28_PAD_SSP2_SS1__USB1_OVERCURRENT);Best regards, Marek Vasut
Best regards, Marek Vasut
On 28/08/2012 11:56, Otavio Salvador wrote:
Align the SSP clock speed with oscilator to achieve higher transfer stability.
Signed-off-by: Otavio Salvador otavio@ossystems.com.br
Applied to u-boot-imx, thanks.
Best regards, Stefano Babic
participants (4)
-
Marek Vasut -
Marek Vasut -
Otavio Salvador -
Stefano Babic