Hi Ladislav,

Thanks for the patch, some comments below

2015-12-30 2:50 GMT+01:00 Ladislav Michl ladis@linux-mips.org:

File is already included: omap3_igep00x0.h -> ti_omap3_common.h -> ti_armv7_omap.h -> ti_armv7_common.h -> config_distro_defaults.h

Signed-off-by: Ladislav Michl ladis@linux-mips.org

include/configs/omap3_igep00x0.h | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/include/configs/omap3_igep00x0.h b/include/configs/omap3_igep00x0.h index cf2bc3e..a64b38f 100644 --- a/include/configs/omap3_igep00x0.h +++ b/include/configs/omap3_igep00x0.h @@ -43,7 +43,7 @@ #else #error "status LED not defined for this machine." #endif -#define RED_LED_DEV 0 +#define RED_LED_DEV 0

any reason for this change ?

#define STATUS_LED_BIT RED_LED_GPIO #define STATUS_LED_STATE STATUS_LED_ON #define STATUS_LED_PERIOD (CONFIG_SYS_HZ / 2) @@ -56,7 +56,7 @@ #define CONFIG_OMAP3_GPIO_6 /* GPIO160..191 is in GPIO bank 6 */

/* USB */ -#define CONFIG_USB_MUSB_UDC 1 +#define CONFIG_USB_MUSB_UDC 1

and this ?

#define CONFIG_USB_OMAP3 1 #define CONFIG_TWL4030_USB 1

@@ -81,12 +81,8 @@ #define CONFIG_CMD_DHCP #define CONFIG_CMD_PING

-/*#undef CONFIG_ENV_IS_NOWHERE*/

and this ?

#ifndef CONFIG_SPL_BUILD

-#include <config_distro_defaults.h>

/* Environment */ #define ENV_DEVICE_SETTINGS \ "stdin=serial\0" \ @@ -138,7 +134,7 @@ #if defined(CONFIG_CMD_NET) #define CONFIG_SMC911X #define CONFIG_SMC911X_32_BIT -#define CONFIG_SMC911X_BASE 0x2C000000 +#define CONFIG_SMC911X_BASE 0x2C000000

again, any reason for this change?

#endif /* (CONFIG_CMD_NET) */

/* OneNAND boot config */

2.1.4

---

U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Also, can you send this patch and the other patch (igep00x0: cleanup ethernet support) as numbered patch series?

Thanks,

Enric