[PATCH] arch: mach-k3: fix mapping higher DDR addresses as device memory
From: Sekhar Nori nsekhar@ti.com
An entry in memory map table for MMU configuration is spilling over and inadvertently mapping DDR available at higher address (above 4GB address space) as device memory (nGnRnE).
Fix this by adjusting entry size. Tested on AM62A SK by enabling CONFIG_CMD_TIME. Before this patch:
=> time crc32 0x881000000 0x20000000 crc32 for 881000000 ... 8a0ffffff ==> 5a7a5760
time: 1 minutes, 14.715 seconds
After patch:
=> time crc32 0x881000000 0x20000000 crc32 for 881000000 ... 8a0ffffff ==> 3df1ce02
time: 2.711 seconds
Signed-off-by: Sekhar Nori nsekhar@ti.com [n-francis@ti.com: rebased on next, retested on all devices inc. commit] Signed-off-by: Neha Malcom Francis n-francis@ti.com Cc: Andrew Davis afd@ti.com --- Boot logs: https://gist.github.com/nehamalcom/7b101ea8b97f5a9433a553ef881166a1
arch/arm/mach-k3/arm64-mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-k3/arm64-mmu.c b/arch/arm/mach-k3/arm64-mmu.c index b4308205b2..0e07b1b7ce 100644 --- a/arch/arm/mach-k3/arm64-mmu.c +++ b/arch/arm/mach-k3/arm64-mmu.c @@ -41,7 +41,7 @@ struct mm_region k3_mem_map[] = { }, { .virt = 0x500000000UL, .phys = 0x500000000UL, - .size = 0x400000000UL, + .size = 0x380000000UL, .attrs = PTE_BLOCK_MEMTYPE(MT_DEVICE_NGNRNE) | PTE_BLOCK_NON_SHARE | PTE_BLOCK_PXN | PTE_BLOCK_UXN
Hi all,
Looks like this patch was already merged to u-boot/master
https://lore.kernel.org/all/20240109084551.21155-1-nsekhar@ti.com/T/#md1fd66...
Sorry for the spam!
On 22/02/24 12:15, Neha Malcom Francis wrote:
From: Sekhar Nori nsekhar@ti.com
An entry in memory map table for MMU configuration is spilling over and inadvertently mapping DDR available at higher address (above 4GB address space) as device memory (nGnRnE).
Fix this by adjusting entry size. Tested on AM62A SK by enabling CONFIG_CMD_TIME. Before this patch:
=> time crc32 0x881000000 0x20000000 crc32 for 881000000 ... 8a0ffffff ==> 5a7a5760
time: 1 minutes, 14.715 seconds
After patch:
=> time crc32 0x881000000 0x20000000 crc32 for 881000000 ... 8a0ffffff ==> 3df1ce02
time: 2.711 seconds
Signed-off-by: Sekhar Nori nsekhar@ti.com [n-francis@ti.com: rebased on next, retested on all devices inc. commit] Signed-off-by: Neha Malcom Francis n-francis@ti.com Cc: Andrew Davis afd@ti.com
Boot logs: https://gist.github.com/nehamalcom/7b101ea8b97f5a9433a553ef881166a1
arch/arm/mach-k3/arm64-mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-k3/arm64-mmu.c b/arch/arm/mach-k3/arm64-mmu.c index b4308205b2..0e07b1b7ce 100644 --- a/arch/arm/mach-k3/arm64-mmu.c +++ b/arch/arm/mach-k3/arm64-mmu.c @@ -41,7 +41,7 @@ struct mm_region k3_mem_map[] = { }, { .virt = 0x500000000UL, .phys = 0x500000000UL,
.size = 0x400000000UL,
.size = 0x380000000UL,
On 12:15-20240222, Neha Malcom Francis wrote:
From: Sekhar Nori nsekhar@ti.com
An entry in memory map table for MMU configuration is spilling over and inadvertently mapping DDR available at higher address (above 4GB address space) as device memory (nGnRnE).
Fix this by adjusting entry size. Tested on AM62A SK by enabling CONFIG_CMD_TIME. Before this patch:
=> time crc32 0x881000000 0x20000000 crc32 for 881000000 ... 8a0ffffff ==> 5a7a5760
time: 1 minutes, 14.715 seconds
After patch:
=> time crc32 0x881000000 0x20000000 crc32 for 881000000 ... 8a0ffffff ==> 3df1ce02
time: 2.711 seconds
Signed-off-by: Sekhar Nori nsekhar@ti.com [n-francis@ti.com: rebased on next, retested on all devices inc. commit] Signed-off-by: Neha Malcom Francis n-francis@ti.com Cc: Andrew Davis afd@ti.com
Boot logs: https://gist.github.com/nehamalcom/7b101ea8b97f5a9433a553ef881166a1
arch/arm/mach-k3/arm64-mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-k3/arm64-mmu.c b/arch/arm/mach-k3/arm64-mmu.c index b4308205b2..0e07b1b7ce 100644 --- a/arch/arm/mach-k3/arm64-mmu.c +++ b/arch/arm/mach-k3/arm64-mmu.c @@ -41,7 +41,7 @@ struct mm_region k3_mem_map[] = { }, { .virt = 0x500000000UL, .phys = 0x500000000UL,
.size = 0x400000000UL,
.size = 0x380000000UL,-- 2.34.1
https://lore.kernel.org/u-boot/20240119160900.GU12635@bill-the-cat/ ??
Something was missing?
participants (2)
-
Neha Malcom Francis -
Nishanth Menon