[U-Boot] Please pull u-boot-ti/master
Hey,
The following changes since commit 4c54419737ffbfadd605263d97a1357bb03c04e8:
socfpga: Adding Freeze Controller driver (2013-12-03 14:38:56 +0100)
are available in the git repository at:
git://git.denx.de/u-boot-ti.git master
for you to fetch changes up to b06f8984959f51f4b99f9c77efa5267623c98957:
omap4_panda: Don't use ulpi_reset (2013-12-04 11:41:14 -0500)
---------------------------------------------------------------- Hardik Patel (1): pandaboard: 1/1] ARM:OMAP4+: panda-es: Support Rev B3 Elpida DDR2 RAM
Ilya Ledvich (3): cm_t335: add cm_t335 board support cm_t335: add support for status LED cm_t335: add support for pca9555 i2c gpio extender
Lars Poeschel (1): pcm051: Support for revision 3
Lokesh Vutla (1): ARM: OMAP5+: Remove unnecessary EFUSE settings
Lubomir Popov (1): ARM: OMAP4: Fix bug in omap4470_volts struct
Michael Trimarchi (2): arm: omap3: Add uart4 omap3 adddress arm: omap3: Enable clocks for peripherals only if they are used
Oleg Kosheliev (2): ARMV7: OMAP4: Add struct for twl603x data ARMV7: OMAP4: Add twl6032 support
Roger Quadros (11): ahci: Error out with message on malloc() failure ahci: Fix cache align error messages ARM: OMAP5: Add Pipe3 PHY driver ARM: OMAP5: Add PRCM and Control information for SATA ARM: OMAP5: Add SATA platform glue ARM: omap5_uevm: Add SATA support ARM: DRA7xx: Add PRCM and Control information for SATA ARM: dra7_evm: Add SATA support usb: ehci-omap: Reset the USB Host OMAP module omap3_beagle: Don't use ulpi_reset omap4_panda: Don't use ulpi_reset
SRICHARAN R (3): ARM: DRA7: Add is_dra7xx cpu check definition ARM: DRA: EMIF: Change DDR3 settings to use hw leveling ARM: DRA7/OMAP5: EMIF: Add workaround for bug 0039
Stefan Roese (1): arm: am335x: Add DT (FDT) support to Siemens boards
Tom Rini (2): am33xx: Stop modifying certain EMIF4D registers am335x_evm: Update nandboot to use partitions and DT
Viktar Palstsiuk (1): davinci: fix Master Priority Registers location
Vladimir Koutny (1): am335x: cpsw: optimize cpsw_recv to increase network performance
Yegor Yefremov (1): am3517_evm: activate Ethernet PHY
arch/arm/cpu/armv7/am33xx/ddr.c | 7 - arch/arm/cpu/armv7/omap-common/Makefile | 5 + arch/arm/cpu/armv7/omap-common/emif-common.c | 142 ++++++++++++---- arch/arm/cpu/armv7/omap-common/pipe3-phy.c | 231 ++++++++++++++++++++++++++ arch/arm/cpu/armv7/omap-common/pipe3-phy.h | 36 ++++ arch/arm/cpu/armv7/omap-common/sata.c | 75 +++++++++ arch/arm/cpu/armv7/omap3/clock.c | 2 - arch/arm/cpu/armv7/omap4/hw_data.c | 12 +- arch/arm/cpu/armv7/omap4/sdram_elpida.c | 9 +- arch/arm/cpu/armv7/omap5/hw_data.c | 9 +- arch/arm/cpu/armv7/omap5/hwinit.c | 18 +- arch/arm/cpu/armv7/omap5/prcm-regs.c | 7 + arch/arm/cpu/armv7/omap5/sdram.c | 214 +++++++++++++++++------- arch/arm/include/asm/arch-am33xx/ddr_defs.h | 37 ++--- arch/arm/include/asm/arch-davinci/hardware.h | 3 +- arch/arm/include/asm/arch-omap3/clock.h | 2 - arch/arm/include/asm/arch-omap3/omap3.h | 1 + arch/arm/include/asm/arch-omap4/sys_proto.h | 4 + arch/arm/include/asm/arch-omap5/clock.h | 3 + arch/arm/include/asm/arch-omap5/omap.h | 4 + arch/arm/include/asm/arch-omap5/sata.h | 48 ++++++ arch/arm/include/asm/emif.h | 14 +- arch/arm/include/asm/omap_common.h | 10 ++ board/compulab/cm_t335/Makefile | 10 ++ board/compulab/cm_t335/cm_t335.c | 162 ++++++++++++++++++ board/compulab/cm_t335/mux.c | 117 +++++++++++++ board/compulab/cm_t335/spl.c | 106 ++++++++++++ board/compulab/cm_t335/u-boot.lds | 101 +++++++++++ board/isee/igep0033/board.c | 4 - board/logicpd/am3517evm/am3517evm.c | 34 ++++ board/logicpd/am3517evm/am3517evm.h | 2 +- board/phytec/pcm051/board.c | 53 ++++-- board/siemens/dxr2/board.c | 4 - board/siemens/pxm2/board.c | 5 - board/siemens/rut/board.c | 5 - board/ti/am335x/board.c | 17 -- board/ti/dra7xx/evm.c | 7 + board/ti/omap5_uevm/evm.c | 7 + board/ti/panda/panda.c | 60 +++++++ board/ti/ti814x/evm.c | 5 - board/ti/ti816x/evm.c | 17 -- boards.cfg | 4 +- drivers/block/ahci.c | 18 +- drivers/net/cpsw.c | 2 +- drivers/power/twl6030.c | 77 +++++++-- drivers/usb/host/ehci-omap.c | 57 +++++-- include/configs/am335x_evm.h | 9 +- include/configs/cm_t335.h | 182 ++++++++++++++++++++ include/configs/dra7xx_evm.h | 11 ++ include/configs/omap3_beagle.h | 3 - include/configs/omap4_panda.h | 3 - include/configs/omap5_uevm.h | 10 ++ include/configs/siemens-am33x-common.h | 5 + include/twl6030.h | 38 +++++ 54 files changed, 1768 insertions(+), 260 deletions(-) create mode 100644 arch/arm/cpu/armv7/omap-common/pipe3-phy.c create mode 100644 arch/arm/cpu/armv7/omap-common/pipe3-phy.h create mode 100644 arch/arm/cpu/armv7/omap-common/sata.c create mode 100644 arch/arm/include/asm/arch-omap5/sata.h create mode 100644 board/compulab/cm_t335/Makefile create mode 100644 board/compulab/cm_t335/cm_t335.c create mode 100644 board/compulab/cm_t335/mux.c create mode 100644 board/compulab/cm_t335/spl.c create mode 100644 board/compulab/cm_t335/u-boot.lds create mode 100644 include/configs/cm_t335.h
Thanks!
Hi Tom,
On Wed, 4 Dec 2013 17:06:30 -0500, Tom Rini trini@ti.com wrote:
Hey,
The following changes since commit 4c54419737ffbfadd605263d97a1357bb03c04e8:
socfpga: Adding Freeze Controller driver (2013-12-03 14:38:56 +0100)
are available in the git repository at:
git://git.denx.de/u-boot-ti.git master
for you to fetch changes up to b06f8984959f51f4b99f9c77efa5267623c98957:
omap4_panda: Don't use ulpi_reset (2013-12-04 11:41:14 -0500)
This causes am3517_evm to fail with warnings:
am3517evm.c: In function 'misc_init_r': am3517evm.c:106:6: warning: unused variable 'reset' [-Wunused-variable] am3517evm.c:105:24: warning: unused variable 'ctr' [-Wunused-variable] am3517evm.c: In function 'misc_init_r': am3517evm.c:106:6: warning: unused variable 'reset' [-Wunused-variable] am3517evm.c:105:24: warning: unused variable 'ctr' [-Wunused-variable]
These are trivial, but I'd like them fixed; lingering warnings are a pain to manage when doing large-scale test build.
These ones come from commit ae98bbeb, that is :
Yegor Yefremov (1): am3517_evm: activate Ethernet PHY
Yegor, can you fix this? Thanks.
Amicalement,
On Fri, Dec 6, 2013 at 9:33 AM, Albert ARIBAUD albert.u.boot@aribaud.net wrote:
Hi Tom,
On Wed, 4 Dec 2013 17:06:30 -0500, Tom Rini trini@ti.com wrote:
Hey,
The following changes since commit 4c54419737ffbfadd605263d97a1357bb03c04e8:
socfpga: Adding Freeze Controller driver (2013-12-03 14:38:56 +0100)
are available in the git repository at:
git://git.denx.de/u-boot-ti.git master
for you to fetch changes up to b06f8984959f51f4b99f9c77efa5267623c98957:
omap4_panda: Don't use ulpi_reset (2013-12-04 11:41:14 -0500)
This causes am3517_evm to fail with warnings:
am3517evm.c: In function 'misc_init_r': am3517evm.c:106:6: warning: unused variable 'reset' [-Wunused-variable] am3517evm.c:105:24: warning: unused variable 'ctr' [-Wunused-variable] am3517evm.c: In function 'misc_init_r': am3517evm.c:106:6: warning: unused variable 'reset' [-Wunused-variable] am3517evm.c:105:24: warning: unused variable 'ctr' [-Wunused-variable]
These are trivial, but I'd like them fixed; lingering warnings are a pain to manage when doing large-scale test build.
These ones come from commit ae98bbeb, that is :
Yegor Yefremov (1): am3517_evm: activate Ethernet PHY
Yegor, can you fix this? Thanks.
v2 sent. I've put those variables under if defined statement, so the warning has gone.
Yegor
Hi Yegor,
On 06.12.2013 10:20, Yegor Yefremov wrote:
This causes am3517_evm to fail with warnings:
am3517evm.c: In function 'misc_init_r': am3517evm.c:106:6: warning: unused variable 'reset' [-Wunused-variable] am3517evm.c:105:24: warning: unused variable 'ctr' [-Wunused-variable] am3517evm.c: In function 'misc_init_r': am3517evm.c:106:6: warning: unused variable 'reset' [-Wunused-variable] am3517evm.c:105:24: warning: unused variable 'ctr' [-Wunused-variable]
These are trivial, but I'd like them fixed; lingering warnings are a pain to manage when doing large-scale test build.
These ones come from commit ae98bbeb, that is :
Yegor Yefremov (1): am3517_evm: activate Ethernet PHY
Yegor, can you fix this? Thanks.
v2 sent. I've put those variables under if defined statement, so the warning has gone.
In general its preferred to use the __maybe_unused statement instead of adding more #ifdef's. Like this:
+ __maybe_unused volatile unsigned int ctr; + __maybe_unused u32 reset;
Care to send a v3 for this patch?
Thanks, Stefan
On Fri, Dec 6, 2013 at 11:08 AM, Stefan Roese sr@denx.de wrote:
Hi Yegor,
On 06.12.2013 10:20, Yegor Yefremov wrote:
This causes am3517_evm to fail with warnings:
am3517evm.c: In function 'misc_init_r': am3517evm.c:106:6: warning: unused variable 'reset' [-Wunused-variable] am3517evm.c:105:24: warning: unused variable 'ctr' [-Wunused-variable] am3517evm.c: In function 'misc_init_r': am3517evm.c:106:6: warning: unused variable 'reset' [-Wunused-variable] am3517evm.c:105:24: warning: unused variable 'ctr' [-Wunused-variable]
These are trivial, but I'd like them fixed; lingering warnings are a pain to manage when doing large-scale test build.
These ones come from commit ae98bbeb, that is :
Yegor Yefremov (1): am3517_evm: activate Ethernet PHY
Yegor, can you fix this? Thanks.
v2 sent. I've put those variables under if defined statement, so the warning has gone.
In general its preferred to use the __maybe_unused statement instead of adding more #ifdef's. Like this:
__maybe_unused volatile unsigned int ctr;__maybe_unused u32 reset;Care to send a v3 for this patch?
Will do.
Yegor
Hi Stefan,
On Fri, 06 Dec 2013 11:08:17 +0100, Stefan Roese sr@denx.de wrote:
Hi Yegor,
On 06.12.2013 10:20, Yegor Yefremov wrote:
This causes am3517_evm to fail with warnings:
am3517evm.c: In function 'misc_init_r': am3517evm.c:106:6: warning: unused variable 'reset' [-Wunused-variable] am3517evm.c:105:24: warning: unused variable 'ctr' [-Wunused-variable] am3517evm.c: In function 'misc_init_r': am3517evm.c:106:6: warning: unused variable 'reset' [-Wunused-variable] am3517evm.c:105:24: warning: unused variable 'ctr' [-Wunused-variable]
These are trivial, but I'd like them fixed; lingering warnings are a pain to manage when doing large-scale test build.
These ones come from commit ae98bbeb, that is :
Yegor Yefremov (1): am3517_evm: activate Ethernet PHY
Yegor, can you fix this? Thanks.
v2 sent. I've put those variables under if defined statement, so the warning has gone.
In general its preferred to use the __maybe_unused statement instead of adding more #ifdef's. Like this:
- __maybe_unused volatile unsigned int ctr;
- __maybe_unused u32 reset;
Care to send a v3 for this patch?
Thanks, Stefan
Hmm, if the variables are used under a clearly defined conditional, I prefer them to be defined under than conditional too. This makes it clearer what is affected when removing the conditional.
Amicalement,
Hi Albert,
On 06.12.2013 13:06, Albert ARIBAUD wrote:
On 06.12.2013 10:20, Yegor Yefremov wrote:
This causes am3517_evm to fail with warnings:
am3517evm.c: In function 'misc_init_r': am3517evm.c:106:6: warning: unused variable 'reset' [-Wunused-variable] am3517evm.c:105:24: warning: unused variable 'ctr' [-Wunused-variable] am3517evm.c: In function 'misc_init_r': am3517evm.c:106:6: warning: unused variable 'reset' [-Wunused-variable] am3517evm.c:105:24: warning: unused variable 'ctr' [-Wunused-variable]
These are trivial, but I'd like them fixed; lingering warnings are a pain to manage when doing large-scale test build.
These ones come from commit ae98bbeb, that is :
Yegor Yefremov (1): am3517_evm: activate Ethernet PHY
Yegor, can you fix this? Thanks.
v2 sent. I've put those variables under if defined statement, so the warning has gone.
In general its preferred to use the __maybe_unused statement instead of adding more #ifdef's. Like this:
- __maybe_unused volatile unsigned int ctr;
- __maybe_unused u32 reset;
Care to send a v3 for this patch?
Thanks, Stefan
Hmm, if the variables are used under a clearly defined conditional, I prefer them to be defined under than conditional too. This makes it clearer what is affected when removing the conditional.
I personally still prefer the __maybe_unused version. And I have seen other U-Boot developers also using it lately more frequently. The removed #ifdef outweighs the added __maybe_unused for my taste.
Thanks, Stefan
Hi Stefan,
On Fri, 06 Dec 2013 14:38:58 +0100, Stefan Roese sr@denx.de wrote:
Hi Albert,
On 06.12.2013 13:06, Albert ARIBAUD wrote:
On 06.12.2013 10:20, Yegor Yefremov wrote:
This causes am3517_evm to fail with warnings:
am3517evm.c: In function 'misc_init_r': am3517evm.c:106:6: warning: unused variable 'reset' [-Wunused-variable] am3517evm.c:105:24: warning: unused variable 'ctr' [-Wunused-variable] am3517evm.c: In function 'misc_init_r': am3517evm.c:106:6: warning: unused variable 'reset' [-Wunused-variable] am3517evm.c:105:24: warning: unused variable 'ctr' [-Wunused-variable]
These are trivial, but I'd like them fixed; lingering warnings are a pain to manage when doing large-scale test build.
These ones come from commit ae98bbeb, that is :
Yegor Yefremov (1): am3517_evm: activate Ethernet PHY
Yegor, can you fix this? Thanks.
v2 sent. I've put those variables under if defined statement, so the warning has gone.
In general its preferred to use the __maybe_unused statement instead of adding more #ifdef's. Like this:
- __maybe_unused volatile unsigned int ctr;
- __maybe_unused u32 reset;
Care to send a v3 for this patch?
Thanks, Stefan
Hmm, if the variables are used under a clearly defined conditional, I prefer them to be defined under than conditional too. This makes it clearer what is affected when removing the conditional.
I personally still prefer the __maybe_unused version. And I have seen other U-Boot developers also using it lately more frequently. The removed #ifdef outweighs the added __maybe_unused for my taste.
I respect your preference. However, my own taste is for making explicit rather than implicit the reason why a variable is marked possibly unused, therefore I would prefer the declarations to be under the same conditional as their use.
Note however that in case where one cannot readily see the conditions under which the variable is unused (e.g. if the variable is an argument to a macro which may or may not use it), I'm ok with using the attribute 'maybe_unused'.
Note also that in the case at hand, a solution may be to declare the variables inside a block under the existing conditional; that block could enclose the three lines below the "ensure that the module is out of reset" comment. The declarations would then require neither conditionals or attributes (and would be topologically as close to the use as possible).
Thanks, Stefan
Amicalement,
participants (4)
-
Albert ARIBAUD -
Stefan Roese -
Tom Rini -
Yegor Yefremov