[U-Boot] [PATCH 1/6] x86/pcat_timer: fix implicit declaration of function ‘unmask_irq’

newer
[U-Boot] [PATCH] lib_arch/board.c:...

older
[U-Boot] [PATCH 2/2] Fix OneNAND...

Jean-Christophe PLAGNIOL-VILLARD

10 May 2009 10 May '09

5:31 p.m.

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com --- lib_i386/pcat_timer.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/lib_i386/pcat_timer.c b/lib_i386/pcat_timer.c index e282f64..97ed8b6 100644 --- a/lib_i386/pcat_timer.c +++ b/lib_i386/pcat_timer.c @@ -22,6 +22,7 @@ */

#include <common.h> +#include <asm/interrupt.h> #include <asm/io.h> #include <asm/i8254.h> #include <asm/ibmpc.h>

-- 1.6.2.4

Show replies by date

Jean-Christophe PLAGNIOL-VILLARD

10 May 10 May

5:31 p.m.

New subject: [U-Boot] [PATCH 2/6] x86/sc520_pci: fix non renaming PCI_REGION_MEMORY by commit ff4e66e93

Rename PCI_REGION_MEMORY to PCI_REGION_SYS_MEMORY

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com --- cpu/i386/sc520/sc520_pci.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/cpu/i386/sc520/sc520_pci.c b/cpu/i386/sc520/sc520_pci.c index 38b837e..871ad0a 100644 --- a/cpu/i386/sc520/sc520_pci.c +++ b/cpu/i386/sc520/sc520_pci.c @@ -124,7 +124,7 @@ void pci_sc520_init(struct pci_controller *hose) SC520_PCI_MEMORY_BUS, SC520_PCI_MEMORY_PHYS, SC520_PCI_MEMORY_SIZE, - PCI_REGION_MEM | PCI_REGION_MEMORY); + PCI_REGION_MEM | PCI_REGION_SYS_MEMORY);

/* PCI memory space */ pci_set_region(hose->regions + 1,

-- 1.6.2.4

Jean-Christophe PLAGNIOL-VILLARD

5:31 p.m.

New subject: [U-Boot] [PATCH 3/6] sc520_spunk: fix ssi.h include location

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com --- board/sc520_spunk/sc520_spunk.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/board/sc520_spunk/sc520_spunk.c b/board/sc520_spunk/sc520_spunk.c index d3bd869..e439b0b 100644 --- a/board/sc520_spunk/sc520_spunk.c +++ b/board/sc520_spunk/sc520_spunk.c @@ -24,11 +24,11 @@

#include <common.h> #include <pci.h> -#include <ssi.h> #include <netdev.h> #include <asm/io.h> #include <asm/pci.h> #include <asm/ic/sc520.h> +#include <asm/ic/ssi.h>

DECLARE_GLOBAL_DATA_PTR;

-- 1.6.2.4

Jean-Christophe PLAGNIOL-VILLARD

5:31 p.m.

New subject: [U-Boot] [PATCH 4/6] x86: fix pci large integer implicitly truncated to unsigned type

when allowing for PCI addresses to be 64-bit in commint 30e76d5e3bc4

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com --- lib_i386/pci.c | 2 +- lib_i386/video_bios.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib_i386/pci.c b/lib_i386/pci.c index 4331b04..f366bdc 100644 --- a/lib_i386/pci.c +++ b/lib_i386/pci.c @@ -60,7 +60,7 @@ int pci_shadow_rom(pci_dev_t dev, unsigned char *dest) vendor, device, class_code); #endif /* Enable the rom addess decoder */ - pci_write_config_dword(dev, PCI_ROM_ADDRESS, PCI_ROM_ADDRESS_MASK); + pci_write_config_dword(dev, PCI_ROM_ADDRESS, (u32)PCI_ROM_ADDRESS_MASK); pci_read_config_dword(dev, PCI_ROM_ADDRESS, &addr_reg);

if (!addr_reg) { diff --git a/lib_i386/video_bios.c b/lib_i386/video_bios.c index ce96a3e..d9116d4 100644 --- a/lib_i386/video_bios.c +++ b/lib_i386/video_bios.c @@ -103,7 +103,7 @@ static u32 probe_pci_video(void)

/* Test the ROM decoder, do the device support a rom? */ pci_read_config_dword(devbusfn, PCI_ROM_ADDRESS, &old); - pci_write_config_dword(devbusfn, PCI_ROM_ADDRESS, PCI_ROM_ADDRESS_MASK); + pci_write_config_dword(devbusfn, PCI_ROM_ADDRESS, (u32)PCI_ROM_ADDRESS_MASK); pci_read_config_dword(devbusfn, PCI_ROM_ADDRESS, &addr); pci_write_config_dword(devbusfn, PCI_ROM_ADDRESS, old);

-- 1.6.2.4

Jean-Christophe PLAGNIOL-VILLARD

5:31 p.m.

New subject: [U-Boot] [PATCH 5/6] fix ‘x86/video_bios: probe_pci_video’ defined but not used

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com --- lib_i386/video_bios.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/lib_i386/video_bios.c b/lib_i386/video_bios.c index d9116d4..3935d05 100644 --- a/lib_i386/video_bios.c +++ b/lib_i386/video_bios.c @@ -76,11 +76,12 @@ void print_bios_bios_stat(void) } #endif

+#ifdef CONFIG_VIDEO + #define PCI_CLASS_VIDEO 3 #define PCI_CLASS_VIDEO_STD 0 #define PCI_CLASS_VIDEO_PROG_IF_VGA 0

- static u32 probe_pci_video(void) { pci_dev_t devbusfn; @@ -132,7 +133,7 @@ static u32 probe_pci_video(void)

return 0; } - +#endif /* CONFIG_VIDEO */

#endif

@@ -176,7 +177,9 @@ int video_bios_init(void)

if (probe_isa_video()) { /* No ISA board found, try the PCI bus */ +#ifdef CONFIG_PCI regs.eax = probe_pci_video(); +#endif }

/* Did we succeed in mapping any video bios */

-- 1.6.2.4

Jean-Christophe PLAGNIOL-VILLARD

5:31 p.m.

New subject: [U-Boot] [PATCH 6/6] eNET: fix MAKEALL

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com --- MAKEALL | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/MAKEALL b/MAKEALL index 46a96c0..62697c4 100755 --- a/MAKEALL +++ b/MAKEALL @@ -697,8 +697,8 @@ LIST_mips_el=" \ #########################################################################

LIST_I486=" \ + eNET \ sc520_cdp \ - sc520_eNET \ sc520_spunk \ sc520_spunk_rel \ "

-- 1.6.2.4

Wolfgang Denk

15 May 15 May

9:47 p.m.

New subject: [U-Boot] [PATCH 6/6] eNET: fix MAKEALL

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message 1241969511-4497-6-git-send-email-plagnioj@jcrosoft.com you wrote:

...

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com

MAKEALL | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

Please provice a description what sort of problem you are fixing.

Best regards,

Wolfgang Denk

-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de A Freudian slip is when you say one thing but mean your mother.

Wolfgang Denk

11 May 11 May

9:15 a.m.

New subject: [U-Boot] [PATCH 5/6] fix ‘x86/video_bios: probe_pci_video’ defined but not used

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message 1241969511-4497-5-git-send-email-plagnioj@jcrosoft.com you wrote:

...

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com

Please provide a proper commit message explaining what you are doing, and get rid of the special character(s) in the Subject: line.

Best regards,

Wolfgang Denk

9:16 a.m.

New subject: [U-Boot] [PATCH 4/6] x86: fix pci large integer implicitly truncated to unsigned type

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message 1241969511-4497-4-git-send-email-plagnioj@jcrosoft.com you wrote:

...

when allowing for PCI addresses to be 64-bit in commint 30e76d5e3bc4

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com

lib_i386/pci.c | 2 +- lib_i386/video_bios.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib_i386/pci.c b/lib_i386/pci.c index 4331b04..f366bdc 100644 --- a/lib_i386/pci.c +++ b/lib_i386/pci.c @@ -60,7 +60,7 @@ int pci_shadow_rom(pci_dev_t dev, unsigned char *dest) vendor, device, class_code); #endif /* Enable the rom addess decoder */

pci_write_config_dword(dev, PCI_ROM_ADDRESS, PCI_ROM_ADDRESS_MASK);

pci_write_config_dword(dev, PCI_ROM_ADDRESS, (u32)PCI_ROM_ADDRESS_MASK);

Ummm... but when we have 64 bit PIC addresses, then truncating these to 32 bit (either implicitly or explicitly) is wrong. Instead of fixing the problem, you just hush up the compiler warning. NAK.

Best regards,

Wolfgang Denk

-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de Love sometimes expresses itself in sacrifice. -- Kirk, "Metamorphosis", stardate 3220.3

Wolfgang Denk

15 May 15 May

9:45 p.m.

New subject: [U-Boot] [PATCH 1/6] x86/pcat_timer: fix implicit declaration of function ‘unmask_irq’

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message 1241969511-4497-1-git-send-email-plagnioj@jcrosoft.com you wrote:

...

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com

lib_i386/pcat_timer.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)

Please get rid of the special characters in the Subject: line.

Best regards,

Wolfgang Denk

-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de "The combination of a number of things to make existence worthwhile." "Yes, the philosophy of 'none,' meaning 'all.'" -- Spock and Lincoln, "The Savage Curtain", stardate 5906.4

Wolfgang Denk

9:47 p.m.

New subject: [U-Boot] [PATCH 1/6] x86/pcat_timer: fix implicit declaration of function ‘unmask_irq’

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message 1241969511-4497-1-git-send-email-plagnioj@jcrosoft.com you wrote:

...

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com

lib_i386/pcat_timer.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)

....

Since most patches of these series had some issues, I suggest you repost the whole serias after cleaning up.

Thanks.

Best regards,

Wolfgang Denk

-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de Earth -- mother of the most beautiful women in the universe. -- Apollo, "Who Mourns for Adonais?" stardate 3468.1

5836

Age (days ago)

5841

Last active (days ago)

List overview

Download

10 comments

2 participants

tags (0)

participants (2)

Jean-Christophe PLAGNIOL-VILLARD
Wolfgang Denk