Re: [U-Boot] i.MX6: Add hdmidet command
Hi Stefano,
This seems to have gotten lost in the shuffle.
It's showing as "Changes requested" in Patchwork:
http://patchwork.ozlabs.org/patch/186280/
Is there something you'd like changed?
Please advise,
Eric
On Tue, Feb 19, 2013 at 5:12 PM, Eric Nelson eric.nelson@boundarydevices.com wrote:
Hi Stefano,
This seems to have gotten lost in the shuffle.
It's showing as "Changes requested" in Patchwork:
http://patchwork.ozlabs.org/patch/186280/Is there something you'd like changed?
Please advise,
I'd say to use space between the '+' as done in other code.
Hi Otavio,
On 02/19/2013 01:30 PM, Otavio Salvador wrote:
On Tue, Feb 19, 2013 at 5:12 PM, Eric Nelson eric.nelson@boundarydevices.com wrote:
Hi Stefano,
This seems to have gotten lost in the shuffle.
It's showing as "Changes requested" in Patchwork:
http://patchwork.ozlabs.org/patch/186280/Is there something you'd like changed?
Please advise,
I'd say to use space between the '+' as done in other code.
I must be dense.
Which '+' needs a space?
Please advise,
Eric
On Tue, Feb 19, 2013 at 8:03 PM, Eric Nelson eric.nelson@boundarydevices.com wrote:
Hi Otavio,
On 02/19/2013 01:30 PM, Otavio Salvador wrote:
On Tue, Feb 19, 2013 at 5:12 PM, Eric Nelson eric.nelson@boundarydevices.com wrote:
Hi Stefano,
This seems to have gotten lost in the shuffle.
It's showing as "Changes requested" in Patchwork:
http://patchwork.ozlabs.org/patch/186280/Is there something you'd like changed?
Please advise,
I'd say to use space between the '+' as done in other code.
I must be dense.
Which '+' needs a space?
It seems usually when dealing with offsets we have ' + '. Personally I think it is clear to read too. But it's not my call so it is up to you and Stefano.
On 02/19/2013 05:42 PM, Otavio Salvador wrote:
On Tue, Feb 19, 2013 at 8:03 PM, Eric Nelson eric.nelson@boundarydevices.com wrote:
Hi Otavio,
On 02/19/2013 01:30 PM, Otavio Salvador wrote:
On Tue, Feb 19, 2013 at 5:12 PM, Eric Nelson eric.nelson@boundarydevices.com wrote:
Hi Stefano,
This seems to have gotten lost in the shuffle.
It's showing as "Changes requested" in Patchwork:
http://patchwork.ozlabs.org/patch/186280/Is there something you'd like changed?
Please advise,
I'd say to use space between the '+' as done in other code.
I must be dense.
Which '+' needs a space?
It seems usually when dealing with offsets we have ' + '. Personally I think it is clear to read too. But it's not my call so it is up to you and Stefano.
Gotcha.
You mean here:
+{ + u8 reg = __raw_readb(HDMI_ARB_BASE_ADDR+HDMI_PHY_STAT0); ^
That's the trouble with commenting on the patchwork link...
No context.
Regards,
Eric
On Tue, Feb 19, 2013 at 10:16 PM, Eric Nelson eric.nelson@boundarydevices.com wrote:
On 02/19/2013 05:42 PM, Otavio Salvador wrote:
On Tue, Feb 19, 2013 at 8:03 PM, Eric Nelson eric.nelson@boundarydevices.com wrote:
Hi Otavio,
On 02/19/2013 01:30 PM, Otavio Salvador wrote:
On Tue, Feb 19, 2013 at 5:12 PM, Eric Nelson eric.nelson@boundarydevices.com wrote:
Hi Stefano,
This seems to have gotten lost in the shuffle.
It's showing as "Changes requested" in Patchwork:
http://patchwork.ozlabs.org/patch/186280/Is there something you'd like changed?
Please advise,
I'd say to use space between the '+' as done in other code.
I must be dense.
Which '+' needs a space?
It seems usually when dealing with offsets we have ' + '. Personally I think it is clear to read too. But it's not my call so it is up to you and Stefano.
Gotcha.
You mean here:
+{
u8 reg = __raw_readb(HDMI_ARB_BASE_ADDR+HDMI_PHY_STAT0); ^That's the trouble with commenting on the patchwork link...
Yes; a space between both macros.
On 02/19/2013 06:19 PM, Otavio Salvador wrote:
On Tue, Feb 19, 2013 at 10:16 PM, Eric Nelson eric.nelson@boundarydevices.com wrote:
On 02/19/2013 05:42 PM, Otavio Salvador wrote:
On Tue, Feb 19, 2013 at 8:03 PM, Eric Nelson eric.nelson@boundarydevices.com wrote:
Hi Otavio,
On 02/19/2013 01:30 PM, Otavio Salvador wrote:
On Tue, Feb 19, 2013 at 5:12 PM, Eric Nelson eric.nelson@boundarydevices.com wrote:
Hi Stefano,
This seems to have gotten lost in the shuffle.
It's showing as "Changes requested" in Patchwork:
http://patchwork.ozlabs.org/patch/186280/Is there something you'd like changed?
Please advise,
I'd say to use space between the '+' as done in other code.
I must be dense.
Which '+' needs a space?
It seems usually when dealing with offsets we have ' + '. Personally I think it is clear to read too. But it's not my call so it is up to you and Stefano.
Gotcha.
You mean here:
+{
u8 reg = __raw_readb(HDMI_ARB_BASE_ADDR+HDMI_PHY_STAT0); ^That's the trouble with commenting on the patchwork link...
Yes; a space between both macros.
And a run through checkpatch...
I am dense today.
On 20/02/2013 02:21, Eric Nelson wrote:
On 02/19/2013 06:19 PM, Otavio Salvador wrote:
On Tue, Feb 19, 2013 at 10:16 PM, Eric Nelson eric.nelson@boundarydevices.com wrote:
On 02/19/2013 05:42 PM, Otavio Salvador wrote:
On Tue, Feb 19, 2013 at 8:03 PM, Eric Nelson eric.nelson@boundarydevices.com wrote:
Hi Otavio,
On 02/19/2013 01:30 PM, Otavio Salvador wrote:
On Tue, Feb 19, 2013 at 5:12 PM, Eric Nelson eric.nelson@boundarydevices.com wrote: > > > Hi Stefano, > > This seems to have gotten lost in the shuffle. > > It's showing as "Changes requested" in Patchwork: > > http://patchwork.ozlabs.org/patch/186280/ > > Is there something you'd like changed? > > Please advise,
I'd say to use space between the '+' as done in other code.
I must be dense.
Which '+' needs a space?
It seems usually when dealing with offsets we have ' + '. Personally I think it is clear to read too. But it's not my call so it is up to you and Stefano.
Gotcha.
You mean here:
+{
u8 reg = __raw_readb(HDMI_ARB_BASE_ADDR+HDMI_PHY_STAT0); ^That's the trouble with commenting on the patchwork link...
Yes; a space between both macros.
And a run through checkpatch...
I am dense today.
Right, sorry for late answer - it is only to fix checkpatch warning, nothing more. I wll then apply it
Best regards, Stefano
participants (3)
-
Eric Nelson -
Otavio Salvador -
Stefano Babic