[U-Boot] [PATCH v2] MUSB timeout broken
Use pre-decrement to leave timeout at 0 when the timeout happens (which is what the timeout detecting code expects).
Signed-off-by: Orjan Friberg of@flatfrog.com --- drivers/usb/musb/musb_hcd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/musb/musb_hcd.c b/drivers/usb/musb/musb_hcd.c index 974bb31..adcf7f7 100644 --- a/drivers/usb/musb/musb_hcd.c +++ b/drivers/usb/musb/musb_hcd.c @@ -1114,7 +1114,7 @@ int usb_lowlevel_init(void) * should be a usb device connected. */ timeout = musb_cfg.timeout; - while (timeout--) + while (--timeout) if (readb(&musbr->devctl) & MUSB_DEVCTL_HM) break;
Hi,
2011/7/4 Orjan Friberg of@flatfrog.com:
Use pre-decrement to leave timeout at 0 when the timeout happens (which is what the timeout detecting code expects).
Signed-off-by: Orjan Friberg of@flatfrog.com
drivers/usb/musb/musb_hcd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/musb/musb_hcd.c b/drivers/usb/musb/musb_hcd.c index 974bb31..adcf7f7 100644 --- a/drivers/usb/musb/musb_hcd.c +++ b/drivers/usb/musb/musb_hcd.c @@ -1114,7 +1114,7 @@ int usb_lowlevel_init(void) * should be a usb device connected. */ timeout = musb_cfg.timeout;
- while (timeout--)
- while (--timeout)
if (readb(&musbr->devctl) & MUSB_DEVCTL_HM) break;
Applied to u-boot-usb
Thanks.
Remy
Hi,
2011/7/4 Orjan Friberg of@flatfrog.com:
Use pre-decrement to leave timeout at 0 when the timeout happens (which is what the timeout detecting code expects).
Signed-off-by: Orjan Friberg of@flatfrog.com
drivers/usb/musb/musb_hcd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/musb/musb_hcd.c b/drivers/usb/musb/musb_hcd.c index 974bb31..adcf7f7 100644 --- a/drivers/usb/musb/musb_hcd.c +++ b/drivers/usb/musb/musb_hcd.c @@ -1114,7 +1114,7 @@ int usb_lowlevel_init(void) * should be a usb device connected. */ timeout = musb_cfg.timeout;
- while (timeout--)
- while (--timeout)
if (readb(&musbr->devctl) & MUSB_DEVCTL_HM) break;
Applied to u-boot-usb
Whoops... Not applied to u-boot-usb, since the timeout code is broken. It should wait for a certain time, not a certain count.
Kind regards,
Remy
participants (2)
-
Orjan Friberg -
Remy Bohmer