[U-Boot] [PATCH] net: Fix problem with 405EZ ethernet interrupt

From: James Clough james@rtetc.com
On 405EZ the RX-/TX-interrupts are coalesced into one IRQ bit in the UIC. We need to acknowledge the RX-/TX-interrupts in the SDR0_ICINTSTAT reg as well.
This problem was introduced with commit d1631fe1 [ppc4xx: Consolidate PPC4xx UIC defines]
Signed-off-by: James Clough james@rtetc.com Signed-off-by: Stefan Roese sr@denx.de --- drivers/net/4xx_enet.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/drivers/net/4xx_enet.c b/drivers/net/4xx_enet.c index 329eef0..9d438b5 100644 --- a/drivers/net/4xx_enet.c +++ b/drivers/net/4xx_enet.c @@ -1717,6 +1717,15 @@ int enetInt (struct eth_device *dev) rc = 0; } } +#if defined(CONFIG_405EZ) + /* + * On 405EZ the RX-/TX-interrupts are coalesced into + * one IRQ bit in the UIC. We need to acknowledge the + * RX-/TX-interrupts in the SDR0_ICINTSTAT reg as well. + */ + mtsdr(SDR0_ICINTSTAT, + SDR_ICRX_STAT | SDR_ICTX0_STAT | SDR_ICTX1_STAT); +#endif /* defined(CONFIG_405EZ) */ } while (serviced);
return (rc);

Stefan Roese wrote:
From: James Clough james@rtetc.com
On 405EZ the RX-/TX-interrupts are coalesced into one IRQ bit in the UIC. We need to acknowledge the RX-/TX-interrupts in the SDR0_ICINTSTAT reg as well.
This problem was introduced with commit d1631fe1 [ppc4xx: Consolidate PPC4xx UIC defines]
Signed-off-by: James Clough james@rtetc.com Signed-off-by: Stefan Roese sr@denx.de
drivers/net/4xx_enet.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/drivers/net/4xx_enet.c b/drivers/net/4xx_enet.c index 329eef0..9d438b5 100644 --- a/drivers/net/4xx_enet.c +++ b/drivers/net/4xx_enet.c @@ -1717,6 +1717,15 @@ int enetInt (struct eth_device *dev) rc = 0; } } +#if defined(CONFIG_405EZ)
/*
* On 405EZ the RX-/TX-interrupts are coalesced into
* one IRQ bit in the UIC. We need to acknowledge the
* RX-/TX-interrupts in the SDR0_ICINTSTAT reg as well.
*/
mtsdr(SDR0_ICINTSTAT,
SDR_ICRX_STAT | SDR_ICTX0_STAT | SDR_ICTX1_STAT);
+#endif /* defined(CONFIG_405EZ) */ } while (serviced);
return (rc);
Applied to net repo.
thanks, Ben

Dear Ben Warren,
In message 4AA985C3.5060901@gmail.com you wrote:
...
Applied to net repo.
Do you intend to send a pull request any time soon?
Best regards,
Wolfgang Denk

On Sun, Oct 4, 2009 at 12:09 PM, Wolfgang Denk wd@denx.de wrote:
Dear Ben Warren,
In message 4AA985C3.5060901@gmail.com you wrote:
...
Applied to net repo.
Do you intend to send a pull request any time soon?
Yes I do. Very soon.
Best regards,
Wolfgang Denk
regards,
Ben
participants (3)
-
Ben Warren
-
Stefan Roese
-
Wolfgang Denk