[U-Boot] [PATCH 1/1] tools: conditionally disable python libfdt wrapper

Not all host systems want the default swig to be used when building the tools. Allow for the disabling of the wrapper to enable cross-compiling of the tools on a host system with swig.
Signed-off-by: Matthew Weber matthew.weber@rockwellcollins.com ---
I'm open for suggestions on what updates to make to enable the wrapper building to use prefix/destdir that point python/swig in the right place to the sysroot/host tools/libs for building of the tools.
Example build failure when buildroot is trying to build target/host uboot-tools and the host systems OS is detecting swig. The intention would be the buildroot built host python/swig should be used for the detect and as the tools assisting in the build. http://autobuild.buildroot.net/results/6d5/6d52ac8bb71012aea6fc4c679691b31a3... --- tools/Makefile | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/tools/Makefile b/tools/Makefile index 2fc4a58..7f6c29d 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -114,6 +114,7 @@ fit_check_sign-objs := $(dumpimage-mkimage-objs) fit_check_sign.o
# Build a libfdt Python module if swig is available # Use 'sudo apt-get install swig libpython-dev' to enable this +ifndef CONFIG_TOOLS_PYTHON_WRAPPER_DISABLE hostprogs-y += \ $(if $(shell which swig 2> /dev/null),_libfdt.so) _libfdt.so-sharedobjs += $(LIBFDT_OBJS) @@ -126,6 +127,7 @@ tools/_libfdt.so: $(patsubst %.o,%.c,$(LIBFDT_OBJS)) tools/libfdt_wrap.c
tools/libfdt_wrap.c: $(srctree)/lib/libfdt/libfdt.swig swig -python -o $@ $< +endif
# TODO(sjg@chromium.org): Is this correct on Mac OS?

Hi Matt,
On 1 May 2017 at 21:43, Matt Weber matthew.weber@rockwellcollins.com wrote:
Not all host systems want the default swig to be used when building the tools. Allow for the disabling of the wrapper to enable cross-compiling of the tools on a host system with swig.
Signed-off-by: Matthew Weber matthew.weber@rockwellcollins.com
I'm open for suggestions on what updates to make to enable the wrapper building to use prefix/destdir that point python/swig in the right place to the sysroot/host tools/libs for building of the tools.
Example build failure when buildroot is trying to build target/host uboot-tools and the host systems OS is detecting swig. The intention would be the buildroot built host python/swig should be used for the detect and as the tools assisting in the build. http://autobuild.buildroot.net/results/6d5/6d52ac8bb71012aea6fc4c679691b31a3...
tools/Makefile | 2 ++ 1 file changed, 2 insertions(+)
Can you please take a look at u-boot-fdt/next ?
That branch has the new approach for this feature. Can you try to get your path running on that branch and send v2?
Thanks, Simon

Hi Matt,
On 8 May 2017 at 10:38, Simon Glass sjg@chromium.org wrote:
Hi Matt,
On 1 May 2017 at 21:43, Matt Weber matthew.weber@rockwellcollins.com wrote:
Not all host systems want the default swig to be used when building the tools. Allow for the disabling of the wrapper to enable cross-compiling of the tools on a host system with swig.
Signed-off-by: Matthew Weber matthew.weber@rockwellcollins.com
I'm open for suggestions on what updates to make to enable the wrapper building to use prefix/destdir that point python/swig in the right place to the sysroot/host tools/libs for building of the tools.
Example build failure when buildroot is trying to build target/host uboot-tools and the host systems OS is detecting swig. The intention would be the buildroot built host python/swig should be used for the detect and as the tools assisting in the build. http://autobuild.buildroot.net/results/6d5/6d52ac8bb71012aea6fc4c679691b31a3...
tools/Makefile | 2 ++ 1 file changed, 2 insertions(+)
Can you please take a look at u-boot-fdt/next ?
That branch has the new approach for this feature. Can you try to get your path running on that branch and send v2?
This work is now in mainline. What do you think? Do you still need this patch?
Regards, Simon
participants (2)
-
Matt Weber
-
Simon Glass