[U-Boot] [RESEND PATCH] net: phy: Fix return value check phy_probe

From: Siva Durga Prasad Paladugu siva.durga.paladugu@xilinx.com
Don't ignore return value of phy_probe() call as the probe may fail and it needs to be reported.
Signed-off-by: Siva Durga Prasad Paladugu siva.durga.paladugu@xilinx.com Signed-off-by: Michal Simek michal.simek@xilinx.com ---
Joe asked for it.
--- drivers/net/phy/phy.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index a508fb550451..e0a925152e8b 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -670,7 +670,10 @@ static struct phy_device *phy_device_create(struct mii_dev *bus, int addr,
dev->drv = get_phy_driver(dev, interface);
- phy_probe(dev); + if (phy_probe(dev)) { + printf("%s, PHY probe failed\n", __func__); + return NULL; + }
if (addr >= 0 && addr < PHY_MAX_ADDR) bus->phymap[addr] = dev;

On Mon, Mar 4, 2019 at 9:02 AM Michal Simek michal.simek@xilinx.com wrote:
From: Siva Durga Prasad Paladugu siva.durga.paladugu@xilinx.com
Don't ignore return value of phy_probe() call as the probe may fail and it needs to be reported.
Signed-off-by: Siva Durga Prasad Paladugu siva.durga.paladugu@xilinx.com Signed-off-by: Michal Simek michal.simek@xilinx.com
Acked-by: Joe Hershberger joe.hershberger@ni.com

Hi Michal,
https://patchwork.ozlabs.org/patch/1051139/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git
Thanks! -Joe
participants (2)
-
Joe Hershberger
-
Michal Simek