Re: [U-Boot-Users] [PATCH] lwmon5 dspic POST spezification

Hello Wolfgang,
i found another problem with the sysmon POST. We have to add an offset to the voltage thresholds.
best regards, Sascha Laue
From: Sascha Laue sascha.laue@liebherr.com Date: Wed, 30 Apr 2008 13:32:17 +0200 Subject: [PATCH] fix an offset error in lwmon5 sysmon0 post.
--- post/board/lwmon5/sysmon.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/post/board/lwmon5/sysmon.c b/post/board/lwmon5/sysmon.c index 23cb709..e9c9624 100644 --- a/post/board/lwmon5/sysmon.c +++ b/post/board/lwmon5/sysmon.c @@ -133,16 +133,16 @@ static sysmon_table_t sysmon_table[] = { "+ 5 V", "V", &sysmon_dspic, NULL, NULL, 100, 1000, -0x8000, 0x7FFF, 0xFFFF, - VOLTAGE_5V_MIN, VOLTAGE_5V_MAX, 0, - VOLTAGE_5V_MIN, VOLTAGE_5V_MAX, 0, + 0x8000 + VOLTAGE_5V_MIN, 0x8000 + VOLTAGE_5V_MAX, 0, + 0x8000 + VOLTAGE_5V_MIN, 0x8000 + VOLTAGE_5V_MAX, 0, REG_VOLTAGE_5V, },
{ "+ 5 V standby", "V", &sysmon_dspic, NULL, NULL, 100, 1000, -0x8000, 0x7FFF, 0xFFFF, - VOLTAGE_5V_STANDBY_MIN, VOLTAGE_5V_STANDBY_MAX, 0, - VOLTAGE_5V_STANDBY_MIN, VOLTAGE_5V_STANDBY_MAX, 0, + 0x8000 + VOLTAGE_5V_STANDBY_MIN, 0x8000 + VOLTAGE_5V_STANDBY_MAX, 0, + 0x8000 + VOLTAGE_5V_STANDBY_MIN, 0x8000 + VOLTAGE_5V_STANDBY_MAX, 0, REG_VOLTAGE_5V_STANDBY, }, }; -- 1.5.2.4
-------- Original-Nachricht --------
Datum: Mon, 28 Apr 2008 22:41:39 +0200 Von: Wolfgang Denk wd@denx.de An: "Sascha Laue" Sascha.Laue@gmx.biz CC: marcel.brasch@liebherr.com, u-boot-users@lists.sourceforge.net, mk@denx.de Betreff: Re: [U-Boot-Users] [PATCH] lwmon5 dspic POST spezification
In message 20080401075646.145810@gmx.net you wrote:
sorry but it's the first time for me. let's try again.
we modified the specification for the lwmon5 board dspic POST. Additionally I have add defines for the temperature- and voltagevalues.
Signed-off-by: Sascha Laue sascha.laue@liebherr.com
post/board/lwmon5/sysmon.c | 39
++++++++++++++++++++++++++++++---------
1 files changed, 30 insertions(+), 9 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de Committee, n.: A group of men who individually can do nothing but as a group decide that nothing can be done. - Fred Allen

In message 20080430132338.311900@gmx.net you wrote:
Hello Wolfgang,
i found another problem with the sysmon POST. We have to add an offset to the voltage thresholds.
best regards, Sascha Laue
From: Sascha Laue sascha.laue@liebherr.com Date: Wed, 30 Apr 2008 13:32:17 +0200 Subject: [PATCH] fix an offset error in lwmon5 sysmon0 post.
post/board/lwmon5/sysmon.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)
Applied, manually again.
Please pay a bit more attention how to submit patches:
- comments that are not intended for the commit message belong *below* the '---' line - this patch was again white space corrupted.
I *strongly* recommend to use 'git-send-email' to send patches.
The tools you are using are obviously inadequate.
Thanks in advance.
Best regards,
Wolfgang Denk
participants (2)
-
Sascha Laue
-
Wolfgang Denk