[PATCH v1] arch/arm: sm: introduce efusedump command

Using this command user can print efuse memory:
$ sm efusedump 0 10 00000000: ff 00 31 00 00 ff 66 00 00 00 ..1...f...
Signed-off-by: Alexey Romanov avromanov@sberdevices.ru --- arch/arm/mach-meson/sm.c | 36 +++++++++++++++++++++++++++++++++++- 1 file changed, 35 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-meson/sm.c b/arch/arm/mach-meson/sm.c index d6eb910689f..87dff2b4c61 100644 --- a/arch/arm/mach-meson/sm.c +++ b/arch/arm/mach-meson/sm.c @@ -20,6 +20,7 @@ #include <linux/bitfield.h> #include <regmap.h> #include <syscon.h> +#include <hexdump.h>
#define FN_GET_SHARE_MEM_INPUT_BASE 0x82000020 #define FN_GET_SHARE_MEM_OUTPUT_BASE 0x82000021 @@ -246,11 +247,43 @@ static int do_efuse_write(struct cmd_tbl *cmdtp, int flag, int argc, return CMD_RET_SUCCESS; }
+static int do_efuse_dump(struct cmd_tbl *cmdtp, int flag, int argc, + char *const argv[]) +{ + ulong offset, size; + u8 *buffer; + int ret; + + if (argc != 3) + return CMD_RET_USAGE; + + offset = simple_strtoul(argv[1], NULL, 0); + size = simple_strtoul(argv[2], NULL, 0); + buffer = malloc(size); + if (!buffer) { + pr_err("Failed to allocate %lu bytes\n", size); + return CMD_RET_FAILURE; + } + + ret = meson_sm_read_efuse(offset, (void *)buffer, size); + if (ret != size) { + ret = CMD_RET_FAILURE; + goto free_buffer; + } + + print_buffer(0, buffer, 1, size, 0); + +free_buffer: + free(buffer); + return ret; +} + static struct cmd_tbl cmd_sm_sub[] = { U_BOOT_CMD_MKENT(serial, 2, 1, do_sm_serial, "", ""), U_BOOT_CMD_MKENT(reboot_reason, 1, 1, do_sm_reboot_reason, "", ""), U_BOOT_CMD_MKENT(efuseread, 4, 1, do_efuse_read, "", ""), U_BOOT_CMD_MKENT(efusewrite, 4, 0, do_efuse_write, "", ""), + U_BOOT_CMD_MKENT(efusedump, 3, 1, do_efuse_dump, "", ""), };
static int do_sm(struct cmd_tbl *cmdtp, int flag, int argc, @@ -279,5 +312,6 @@ U_BOOT_CMD( "serial <address> - read chip unique id to memory address\n" "sm reboot_reason [name] - get reboot reason and store to to environment\n" "sm efuseread <offset> <size> <address> - read efuse to memory address\n" - "sm efusewrite <offset> <size> <address> - write into efuse from memory address" + "sm efusewrite <offset> <size> <address> - write into efuse from memory address\n" + "sm efusedump <offset> <size> - dump efuse data range to console" );

On Fri, Dec 09, 2022 at 03:52:04PM +0300, Alexey Romanov wrote:
Using this command user can print efuse memory:
$ sm efusedump 0 10 00000000: ff 00 31 00 00 ff 66 00 00 00 ..1...f...
Signed-off-by: Alexey Romanov avromanov@sberdevices.ru
arch/arm/mach-meson/sm.c | 36 +++++++++++++++++++++++++++++++++++- 1 file changed, 35 insertions(+), 1 deletion(-)
This needs to be moved done under cmd/ somewhere, perhaps cmd/meson/

Hello!
On Mon, Dec 12, 2022 at 11:08:34AM -0500, Tom Rini wrote:
On Fri, Dec 09, 2022 at 03:52:04PM +0300, Alexey Romanov wrote:
Using this command user can print efuse memory:
$ sm efusedump 0 10 00000000: ff 00 31 00 00 ff 66 00 00 00 ..1...f...
Signed-off-by: Alexey Romanov avromanov@sberdevices.ru
arch/arm/mach-meson/sm.c | 36 +++++++++++++++++++++++++++++++++++- 1 file changed, 35 insertions(+), 1 deletion(-)
This needs to be moved done under cmd/ somewhere, perhaps cmd/meson/
-- Tom
Do you mean it must be moved by a different patchset? From my point of view, your comment is totally right, because arch dependent commands are located at cmd/ARCH path. But I'm afraid my patchset is just about new helper command.
Anyway, I can send a new different patchset with refactoring suggested by you. But, please, comment out some words about new efuse command if possible.

On Tue, Dec 13, 2022 at 01:59:01PM +0000, Alexey Romanov wrote:
Hello!
On Mon, Dec 12, 2022 at 11:08:34AM -0500, Tom Rini wrote:
On Fri, Dec 09, 2022 at 03:52:04PM +0300, Alexey Romanov wrote:
Using this command user can print efuse memory:
$ sm efusedump 0 10 00000000: ff 00 31 00 00 ff 66 00 00 00 ..1...f...
Signed-off-by: Alexey Romanov avromanov@sberdevices.ru
arch/arm/mach-meson/sm.c | 36 +++++++++++++++++++++++++++++++++++- 1 file changed, 35 insertions(+), 1 deletion(-)
This needs to be moved done under cmd/ somewhere, perhaps cmd/meson/
-- Tom
Do you mean it must be moved by a different patchset? From my point of view, your comment is totally right, because arch dependent commands are located at cmd/ARCH path. But I'm afraid my patchset is just about new helper command.
Anyway, I can send a new different patchset with refactoring suggested by you. But, please, comment out some words about new efuse command if possible.
I think your changes are fine, I'd like to see this as a 2 part patch where part 1 is just moving the code and 2 is adding your changes.
participants (3)
-
Alexey Romanov
-
Alexey Romanov
-
Tom Rini