Re: [U-Boot] [PATCH] Kirkwood: SATA supports only one device per bus
-----Original Message----- From: Prafulla Wadaskar Sent: Wednesday, March 30, 2011 4:48 PM To: 'Gray Remlin' Cc: u-boot@lists.denx.de; Prabhanjan Sarnaik; Ashish Karkare Subject: RE: [PATCH] Kirkwood: SATA supports only one device per bus
-----Original Message----- From: Gray Remlin [mailto:gryrmln@gmail.com] Sent: Wednesday, March 30, 2011 1:12 AM To: Prafulla Wadaskar Cc: u-boot@lists.denx.de; Gray Remlin Subject: [PATCH] Kirkwood: SATA supports only one device per bus
Change CONFIG_SYS_IDE_MAXDEVICE from 2 to 1
Kirkwood supports max 2 Why do you want this change?
Hi Gray I take back my words. I will study more and let you know my comments on this. Sorry for noise.
Regards.. Prafulla . .
Regards.. Prafulla ..
Signed-off-by: Gray Remlin gryrmln@gmail.com
arch/arm/include/asm/arch-kirkwood/config.h | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/arm/include/asm/arch-kirkwood/config.h b/arch/arm/include/asm/arch-kirkwood/config.h index 71ba464..f582ba4 100644 --- a/arch/arm/include/asm/arch-kirkwood/config.h +++ b/arch/arm/include/asm/arch-kirkwood/config.h @@ -128,7 +128,8 @@ #define CONFIG_LBA48 /* CONFIG_CMD_IDE requires some #defines for ATA registers */ #define CONFIG_SYS_IDE_MAXBUS 2 -#define CONFIG_SYS_IDE_MAXDEVICE 2 +/* Only one device per bus on SATA */ +#define CONFIG_SYS_IDE_MAXDEVICE 1 /* ATA registers base is at SATA controller base */ #define CONFIG_SYS_ATA_BASE_ADDR MV_SATA_BASE
#endif /* CONFIG_CMD_IDE */
1.7.4
On 03/30/2011 12:21 PM, Prafulla Wadaskar wrote:
-----Original Message----- From: Prafulla Wadaskar Sent: Wednesday, March 30, 2011 4:48 PM To: 'Gray Remlin' Cc: u-boot@lists.denx.de; Prabhanjan Sarnaik; Ashish Karkare Subject: RE: [PATCH] Kirkwood: SATA supports only one device per bus
-----Original Message----- From: Gray Remlin [mailto:gryrmln@gmail.com] Sent: Wednesday, March 30, 2011 1:12 AM To: Prafulla Wadaskar Cc: u-boot@lists.denx.de; Gray Remlin Subject: [PATCH] Kirkwood: SATA supports only one device per bus
Change CONFIG_SYS_IDE_MAXDEVICE from 2 to 1
Kirkwood supports max 2 Why do you want this change?
Hi Gray I take back my words. I will study more and let you know my comments on this. Sorry for noise.
Regards.. Prafulla . .
Regards.. Prafulla ..
Signed-off-by: Gray Remlingryrmln@gmail.com
arch/arm/include/asm/arch-kirkwood/config.h | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/arm/include/asm/arch-kirkwood/config.h b/arch/arm/include/asm/arch-kirkwood/config.h index 71ba464..f582ba4 100644 --- a/arch/arm/include/asm/arch-kirkwood/config.h +++ b/arch/arm/include/asm/arch-kirkwood/config.h @@ -128,7 +128,8 @@ #define CONFIG_LBA48 /* CONFIG_CMD_IDE requires some #defines for ATA registers */ #define CONFIG_SYS_IDE_MAXBUS 2 -#define CONFIG_SYS_IDE_MAXDEVICE 2 +/* Only one device per bus on SATA */ +#define CONFIG_SYS_IDE_MAXDEVICE 1 /* ATA registers base is at SATA controller base */ #define CONFIG_SYS_ATA_BASE_ADDR MV_SATA_BASE
#endif /* CONFIG_CMD_IDE */
1.7.4
Hi Prafulla,
This one was a bit of a judgement call. You are absolutely correct in what you say that Kirkwood supports two, but to the best of my knowledge, no one has yet implemented a board using both busses (I am not that familiar with OpenRD, I may have to eat my words).
For the sheevaplug, guruplug & dreamplug, it is definitely the case that only one device can be attached.
-----Original Message----- From: Gray Remlin [mailto:gryrmln@gmail.com] Sent: Wednesday, March 30, 2011 7:21 PM To: Prafulla Wadaskar Cc: u-boot@lists.denx.de Subject: Re: [PATCH] Kirkwood: SATA supports only one device per bus
On 03/30/2011 12:21 PM, Prafulla Wadaskar wrote:
-----Original Message----- From: Prafulla Wadaskar Sent: Wednesday, March 30, 2011 4:48 PM To: 'Gray Remlin' Cc: u-boot@lists.denx.de; Prabhanjan Sarnaik; Ashish Karkare Subject: RE: [PATCH] Kirkwood: SATA supports only one device per bus
-----Original Message----- From: Gray Remlin [mailto:gryrmln@gmail.com] Sent: Wednesday, March 30, 2011 1:12 AM To: Prafulla Wadaskar Cc: u-boot@lists.denx.de; Gray Remlin Subject: [PATCH] Kirkwood: SATA supports only one device per bus
Change CONFIG_SYS_IDE_MAXDEVICE from 2 to 1
Kirkwood supports max 2 Why do you want this change?
Hi Gray I take back my words. I will study more and let you know my comments
on this.
Sorry for noise.
Regards.. Prafulla . .
Regards.. Prafulla ..
Signed-off-by: Gray Remlingryrmln@gmail.com
arch/arm/include/asm/arch-kirkwood/config.h | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/arm/include/asm/arch-kirkwood/config.h b/arch/arm/include/asm/arch-kirkwood/config.h index 71ba464..f582ba4 100644 --- a/arch/arm/include/asm/arch-kirkwood/config.h +++ b/arch/arm/include/asm/arch-kirkwood/config.h @@ -128,7 +128,8 @@ #define CONFIG_LBA48 /* CONFIG_CMD_IDE requires some #defines for ATA registers */ #define CONFIG_SYS_IDE_MAXBUS 2 -#define CONFIG_SYS_IDE_MAXDEVICE 2 +/* Only one device per bus on SATA */ +#define CONFIG_SYS_IDE_MAXDEVICE 1 /* ATA registers base is at SATA controller base */ #define CONFIG_SYS_ATA_BASE_ADDR MV_SATA_BASE
#endif /* CONFIG_CMD_IDE */
1.7.4
Hi Prafulla,
This one was a bit of a judgement call. You are absolutely correct in what you say that Kirkwood supports two, but to the best of my knowledge, no one has yet implemented a board using both busses (I am not that familiar with OpenRD, I may have to eat my words).
OpenRD-Base board has two, one e-sata for external hdd and one sata for onboard hdd interface, I am using them :-)
Regards.. Prafulla . .
For the sheevaplug, guruplug & dreamplug, it is definitely the case that only one device can be attached.
Le 30/03/2011 20:59, Prafulla Wadaskar a écrit :
to the best of my knowledge, no one has yet implemented a board using both busses (I am not that familiar with OpenRD, I may have to eat my words).
OpenRD-Base board has two, one e-sata for external hdd and one sata for onboard hdd interface, I am using them :-)
In which case it makes sense to keep CONFIG_SYS_IDE_MAXDEVICE set to 2 in the common code and redefine it to 1 in board configs that only implement one, does it not?
Amicalement,
participants (3)
-
Albert ARIBAUD -
Gray Remlin -
Prafulla Wadaskar