[PATCH] boardf: Modify DRAM message
The message "DRAM: 2 GiB (effective 32 GiB)" can be a little confusing, modify the message to show exactly what is meant:
"DRAM: 2 GiB (available for U-Boot out of total 32 GiB)"
Signed-off-by: Neha Malcom Francis n-francis@ti.com --- common/board_f.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/board_f.c b/common/board_f.c index 154675d0e40..b7add8f7d3d 100644 --- a/common/board_f.c +++ b/common/board_f.c @@ -254,7 +254,7 @@ static int show_dram_config(void)
print_size(gd->ram_size, ""); if (!sizes_near(gd->ram_size, size)) { - printf(" (effective "); + printf(" (available for U-Boot out of total "); print_size(size, ")"); } board_add_ram_info(0);
On 10/10/2024 12:39 PM, Neha Malcom Francis wrote:
The message "DRAM: 2 GiB (effective 32 GiB)" can be a little confusing, modify the message to show exactly what is meant:
"DRAM: 2 GiB (available for U-Boot out of total 32 GiB)"
Still confusing for me atleast :) can this be
"DRAM: 2 GiB available for U-Boot, out of total 32 GiB"
Signed-off-by: Neha Malcom Francis n-francis@ti.com
common/board_f.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/board_f.c b/common/board_f.c index 154675d0e40..b7add8f7d3d 100644 --- a/common/board_f.c +++ b/common/board_f.c @@ -254,7 +254,7 @@ static int show_dram_config(void)
print_size(gd->ram_size, ""); if (!sizes_near(gd->ram_size, size)) {
printf(" (effective ");
printf(" (available for U-Boot out of total ");
Hi Udit
On 10/10/24 21:25, Kumar, Udit wrote:
On 10/10/2024 12:39 PM, Neha Malcom Francis wrote:
The message "DRAM: 2 GiB (effective 32 GiB)" can be a little confusing, modify the message to show exactly what is meant:
"DRAM: 2 GiB (available for U-Boot out of total 32 GiB)"
Still confusing for me atleast :) can this be
"DRAM: 2 GiB available for U-Boot, out of total 32 GiB"
According to Tom, growing this string is not a good option; I agree as well, we can choose a different approach.
Signed-off-by: Neha Malcom Francis n-francis@ti.com
common/board_f.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/board_f.c b/common/board_f.c index 154675d0e40..b7add8f7d3d 100644 --- a/common/board_f.c +++ b/common/board_f.c @@ -254,7 +254,7 @@ static int show_dram_config(void) print_size(gd->ram_size, ""); if (!sizes_near(gd->ram_size, size)) { - printf(" (effective "); + printf(" (available for U-Boot out of total "); print_size(size, ")"); } board_add_ram_info(0);
On Thu, Oct 10, 2024 at 12:39:09PM +0530, Neha Malcom Francis wrote:
The message "DRAM: 2 GiB (effective 32 GiB)" can be a little confusing, modify the message to show exactly what is meant:
"DRAM: 2 GiB (available for U-Boot out of total 32 GiB)"
Signed-off-by: Neha Malcom Francis n-francis@ti.com
common/board_f.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/board_f.c b/common/board_f.c index 154675d0e40..b7add8f7d3d 100644 --- a/common/board_f.c +++ b/common/board_f.c @@ -254,7 +254,7 @@ static int show_dram_config(void)
print_size(gd->ram_size, ""); if (!sizes_near(gd->ram_size, size)) {
printf(" (effective ");
printf(" (available for U-Boot out of total ");
We're growing a constant string in every build here. I would rather see doc/develop/memory.rst start to get updated to spell out that when we print "effective" here it's because we do not have the full 64bit address space available, only 2GiB.
Hi Tom
On 10/10/24 23:28, Tom Rini wrote:
On Thu, Oct 10, 2024 at 12:39:09PM +0530, Neha Malcom Francis wrote:
The message "DRAM: 2 GiB (effective 32 GiB)" can be a little confusing, modify the message to show exactly what is meant:
"DRAM: 2 GiB (available for U-Boot out of total 32 GiB)"
Signed-off-by: Neha Malcom Francis n-francis@ti.com
common/board_f.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/board_f.c b/common/board_f.c index 154675d0e40..b7add8f7d3d 100644 --- a/common/board_f.c +++ b/common/board_f.c @@ -254,7 +254,7 @@ static int show_dram_config(void)
print_size(gd->ram_size, ""); if (!sizes_near(gd->ram_size, size)) {
printf(" (effective ");
printf(" (available for U-Boot out of total ");We're growing a constant string in every build here. I would rather see doc/develop/memory.rst start to get updated to spell out that when we print "effective" here it's because we do not have the full 64bit address space available, only 2GiB.
Agreed, maybe we can take both updation of memory.rst as well as Simon's suggestion of s/effective/total to clear things out.
Hi Neha,
On Thu, 10 Oct 2024 at 01:09, Neha Malcom Francis n-francis@ti.com wrote:
The message "DRAM: 2 GiB (effective 32 GiB)" can be a little confusing, modify the message to show exactly what is meant:
"DRAM: 2 GiB (available for U-Boot out of total 32 GiB)"
Signed-off-by: Neha Malcom Francis n-francis@ti.com
common/board_f.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/board_f.c b/common/board_f.c index 154675d0e40..b7add8f7d3d 100644 --- a/common/board_f.c +++ b/common/board_f.c @@ -254,7 +254,7 @@ static int show_dram_config(void)
print_size(gd->ram_size, ""); if (!sizes_near(gd->ram_size, size)) {
printf(" (effective ");
printf(" (available for U-Boot out of total "); print_size(size, ")"); } board_add_ram_info(0);-- 2.34.1
I've forgotten why the first number can be so much lower than the second. What is causing that?
This is quite a long string...could we say "(total 32 GiB)" ? Then perhaps add something to doc/ to talk about the banner that U-Boot prints?
Regards, Simon
On 10/10/24 1:50 PM, Simon Glass wrote:
Hi Neha,
On Thu, 10 Oct 2024 at 01:09, Neha Malcom Francis n-francis@ti.com wrote:
The message "DRAM: 2 GiB (effective 32 GiB)" can be a little confusing, modify the message to show exactly what is meant:
"DRAM: 2 GiB (available for U-Boot out of total 32 GiB)"
Signed-off-by: Neha Malcom Francis n-francis@ti.com
common/board_f.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/board_f.c b/common/board_f.c index 154675d0e40..b7add8f7d3d 100644 --- a/common/board_f.c +++ b/common/board_f.c @@ -254,7 +254,7 @@ static int show_dram_config(void)
print_size(gd->ram_size, ""); if (!sizes_near(gd->ram_size, size)) {
printf(" (effective ");
printf(" (available for U-Boot out of total "); print_size(size, ")"); } board_add_ram_info(0);-- 2.34.1
I've forgotten why the first number can be so much lower than the second. What is causing that?
This is quite a long string...could we say "(total 32 GiB)" ? Then perhaps add something to doc/ to talk about the banner that U-Boot prints?
Why not just only print the total number? The amount available to U-Boot seems like an internal detail, I'd guess most folks just what to see at a glance how much DDR was detected on their system.
Andrew
Regards, Simon
Hi Andrew
On 11/10/24 01:59, Andrew Davis wrote:
On 10/10/24 1:50 PM, Simon Glass wrote:
Hi Neha,
On Thu, 10 Oct 2024 at 01:09, Neha Malcom Francis n-francis@ti.com wrote:
The message "DRAM: 2 GiB (effective 32 GiB)" can be a little confusing, modify the message to show exactly what is meant:
"DRAM: 2 GiB (available for U-Boot out of total 32 GiB)"
Signed-off-by: Neha Malcom Francis n-francis@ti.com
common/board_f.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/board_f.c b/common/board_f.c index 154675d0e40..b7add8f7d3d 100644 --- a/common/board_f.c +++ b/common/board_f.c @@ -254,7 +254,7 @@ static int show_dram_config(void)
print_size(gd->ram_size, ""); if (!sizes_near(gd->ram_size, size)) { - printf(" (effective "); + printf(" (available for U-Boot out of total "); print_size(size, ")"); } board_add_ram_info(0); -- 2.34.1
I've forgotten why the first number can be so much lower than the second. What is causing that?
This is quite a long string...could we say "(total 32 GiB)" ? Then perhaps add something to doc/ to talk about the banner that U-Boot prints?
Why not just only print the total number? The amount available to U-Boot seems like an internal detail, I'd guess most folks just what to see at a glance how much DDR was detected on their system.
Looking at the git history of this line, seems like we were printing U-Boot available size first and then modified it to show the entire DRAM available as "effective size"... quite possibly directly showing the total is a better idea.
Unless anyone has any reason to have this detail?
Andrew
Regards, Simon
On Mon, Oct 14, 2024 at 10:10:43AM +0530, Neha Malcom Francis wrote:
Hi Andrew
On 11/10/24 01:59, Andrew Davis wrote:
On 10/10/24 1:50 PM, Simon Glass wrote:
Hi Neha,
On Thu, 10 Oct 2024 at 01:09, Neha Malcom Francis n-francis@ti.com wrote:
The message "DRAM: 2 GiB (effective 32 GiB)" can be a little confusing, modify the message to show exactly what is meant:
"DRAM: 2 GiB (available for U-Boot out of total 32 GiB)"
Signed-off-by: Neha Malcom Francis n-francis@ti.com
common/board_f.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/board_f.c b/common/board_f.c index 154675d0e40..b7add8f7d3d 100644 --- a/common/board_f.c +++ b/common/board_f.c @@ -254,7 +254,7 @@ static int show_dram_config(void)
print_size(gd->ram_size, ""); if (!sizes_near(gd->ram_size, size)) { - printf(" (effective "); + printf(" (available for U-Boot out of total "); print_size(size, ")"); } board_add_ram_info(0); -- 2.34.1
I've forgotten why the first number can be so much lower than the second. What is causing that?
This is quite a long string...could we say "(total 32 GiB)" ? Then perhaps add something to doc/ to talk about the banner that U-Boot prints?
Why not just only print the total number? The amount available to U-Boot seems like an internal detail, I'd guess most folks just what to see at a glance how much DDR was detected on their system.
Looking at the git history of this line, seems like we were printing U-Boot available size first and then modified it to show the entire DRAM available as "effective size"... quite possibly directly showing the total is a better idea.
Unless anyone has any reason to have this detail?
There's probably more history as well, but not totally relevant these days. Some solution that starts from "most SoCs are 64bit and can easily address all memory" and goes from there to not grow the overall U-Boot binary much would be good.
Hi,
On 14/10/24 19:57, Tom Rini wrote:
On Mon, Oct 14, 2024 at 10:10:43AM +0530, Neha Malcom Francis wrote:
Hi Andrew
On 11/10/24 01:59, Andrew Davis wrote:
On 10/10/24 1:50 PM, Simon Glass wrote:
Hi Neha,
On Thu, 10 Oct 2024 at 01:09, Neha Malcom Francis n-francis@ti.com wrote:
The message "DRAM: 2 GiB (effective 32 GiB)" can be a little confusing, modify the message to show exactly what is meant:
"DRAM: 2 GiB (available for U-Boot out of total 32 GiB)"
Signed-off-by: Neha Malcom Francis n-francis@ti.com
common/board_f.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/board_f.c b/common/board_f.c index 154675d0e40..b7add8f7d3d 100644 --- a/common/board_f.c +++ b/common/board_f.c @@ -254,7 +254,7 @@ static int show_dram_config(void)
print_size(gd->ram_size, ""); if (!sizes_near(gd->ram_size, size)) { - printf(" (effective "); + printf(" (available for U-Boot out of total "); print_size(size, ")"); } board_add_ram_info(0); -- 2.34.1
I've forgotten why the first number can be so much lower than the second. What is causing that?
This is quite a long string...could we say "(total 32 GiB)" ? Then perhaps add something to doc/ to talk about the banner that U-Boot prints?
Why not just only print the total number? The amount available to U-Boot seems like an internal detail, I'd guess most folks just what to see at a glance how much DDR was detected on their system.
Knowing how much u-boot is using might help someone who is working on some memory map related stuff or if they want to stop at u-boot prompt and tweak environment variables related to memory map (e.g. load address for kernel, dtb, load bitmap to DDR etc). Overall I personally don't see much harm on keeping both the information (DDR available to u-boot and total available DDR). If the word effective is confusing than the print can be made more verbose as being intended in this patch-set or by following the suggestions given by Simon and Udit.
Regards Devarsh
On Mon, Oct 14, 2024 at 08:59:39PM +0530, Devarsh Thakkar wrote:
Hi,
On 14/10/24 19:57, Tom Rini wrote:
On Mon, Oct 14, 2024 at 10:10:43AM +0530, Neha Malcom Francis wrote:
Hi Andrew
On 11/10/24 01:59, Andrew Davis wrote:
On 10/10/24 1:50 PM, Simon Glass wrote:
Hi Neha,
On Thu, 10 Oct 2024 at 01:09, Neha Malcom Francis n-francis@ti.com wrote:
The message "DRAM: 2 GiB (effective 32 GiB)" can be a little confusing, modify the message to show exactly what is meant:
"DRAM: 2 GiB (available for U-Boot out of total 32 GiB)"
Signed-off-by: Neha Malcom Francis n-francis@ti.com
common/board_f.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/board_f.c b/common/board_f.c index 154675d0e40..b7add8f7d3d 100644 --- a/common/board_f.c +++ b/common/board_f.c @@ -254,7 +254,7 @@ static int show_dram_config(void)
print_size(gd->ram_size, ""); if (!sizes_near(gd->ram_size, size)) { - printf(" (effective "); + printf(" (available for U-Boot out of total "); print_size(size, ")"); } board_add_ram_info(0); -- 2.34.1
I've forgotten why the first number can be so much lower than the second. What is causing that?
This is quite a long string...could we say "(total 32 GiB)" ? Then perhaps add something to doc/ to talk about the banner that U-Boot prints?
Why not just only print the total number? The amount available to U-Boot seems like an internal detail, I'd guess most folks just what to see at a glance how much DDR was detected on their system.
Knowing how much u-boot is using might help someone who is working on some memory map related stuff or if they want to stop at u-boot prompt and tweak environment variables related to memory map (e.g. load address for kernel, dtb, load bitmap to DDR etc). Overall I personally don't see much harm on keeping both the information (DDR available to u-boot and total available DDR). If the word effective is confusing than the print can be made more verbose as being intended in this patch-set or by following the suggestions given by Simon and Udit.
U-Boot isn't "using" 2GiB however. And in fact the command Simon is working on to dump the memory table and what's where, as far as U-Boot knows, would be helpful in that case.
Hi all,
On 10/14/24 5:35 PM, Tom Rini wrote:
On Mon, Oct 14, 2024 at 08:59:39PM +0530, Devarsh Thakkar wrote:
Hi,
On 14/10/24 19:57, Tom Rini wrote:
On Mon, Oct 14, 2024 at 10:10:43AM +0530, Neha Malcom Francis wrote:
Hi Andrew
On 11/10/24 01:59, Andrew Davis wrote:
On 10/10/24 1:50 PM, Simon Glass wrote:
Hi Neha,
On Thu, 10 Oct 2024 at 01:09, Neha Malcom Francis n-francis@ti.com wrote: > > The message "DRAM: 2 GiB (effective 32 GiB)" can be a little confusing, > modify the message to show exactly what is meant: > > "DRAM: 2 GiB (available for U-Boot out of total 32 GiB)" > > Signed-off-by: Neha Malcom Francis n-francis@ti.com > --- > common/board_f.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/common/board_f.c b/common/board_f.c > index 154675d0e40..b7add8f7d3d 100644 > --- a/common/board_f.c > +++ b/common/board_f.c > @@ -254,7 +254,7 @@ static int show_dram_config(void) > > print_size(gd->ram_size, ""); > if (!sizes_near(gd->ram_size, size)) { > - printf(" (effective "); > + printf(" (available for U-Boot out of total "); > print_size(size, ")"); > } > board_add_ram_info(0); > -- > 2.34.1 >
I've forgotten why the first number can be so much lower than the second. What is causing that?
This is quite a long string...could we say "(total 32 GiB)" ? Then perhaps add something to doc/ to talk about the banner that U-Boot prints?
Why not just only print the total number? The amount available to U-Boot seems like an internal detail, I'd guess most folks just what to see at a glance how much DDR was detected on their system.
Knowing how much u-boot is using might help someone who is working on some memory map related stuff or if they want to stop at u-boot prompt and tweak environment variables related to memory map (e.g. load address for kernel, dtb, load bitmap to DDR etc). Overall I personally don't see much harm on keeping both the information (DDR available to u-boot and total available DDR). If the word effective is confusing than the print can be made more verbose as being intended in this patch-set or by following the suggestions given by Simon and Udit.
U-Boot isn't "using" 2GiB however. And in fact the command Simon is working on to dump the memory table and what's where, as far as U-Boot knows, would be helpful in that case.
"Available" and "Total" would be matching the terms used by "free" in Linux for example.
I still think both are valuable pieces of information (what's populated and what is usable by U-Boot AFAIR).
Cheers, Quentin
On Mon, Oct 14, 2024 at 07:23:09PM +0200, Quentin Schulz wrote:
Hi all,
On 10/14/24 5:35 PM, Tom Rini wrote:
On Mon, Oct 14, 2024 at 08:59:39PM +0530, Devarsh Thakkar wrote:
Hi,
On 14/10/24 19:57, Tom Rini wrote:
On Mon, Oct 14, 2024 at 10:10:43AM +0530, Neha Malcom Francis wrote:
Hi Andrew
On 11/10/24 01:59, Andrew Davis wrote:
On 10/10/24 1:50 PM, Simon Glass wrote: > Hi Neha, > > On Thu, 10 Oct 2024 at 01:09, Neha Malcom Francis n-francis@ti.com wrote: > > > > The message "DRAM: 2 GiB (effective 32 GiB)" can be a little confusing, > > modify the message to show exactly what is meant: > > > > "DRAM: 2 GiB (available for U-Boot out of total 32 GiB)" > > > > Signed-off-by: Neha Malcom Francis n-francis@ti.com > > --- > > common/board_f.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/common/board_f.c b/common/board_f.c > > index 154675d0e40..b7add8f7d3d 100644 > > --- a/common/board_f.c > > +++ b/common/board_f.c > > @@ -254,7 +254,7 @@ static int show_dram_config(void) > > > > print_size(gd->ram_size, ""); > > if (!sizes_near(gd->ram_size, size)) { > > - printf(" (effective "); > > + printf(" (available for U-Boot out of total "); > > print_size(size, ")"); > > } > > board_add_ram_info(0); > > -- > > 2.34.1 > > > > I've forgotten why the first number can be so much lower than the > second. What is causing that? > > This is quite a long string...could we say "(total 32 GiB)" ? Then > perhaps add something to doc/ to talk about the banner that U-Boot > prints? >
Why not just only print the total number? The amount available to U-Boot seems like an internal detail, I'd guess most folks just what to see at a glance how much DDR was detected on their system.
Knowing how much u-boot is using might help someone who is working on some memory map related stuff or if they want to stop at u-boot prompt and tweak environment variables related to memory map (e.g. load address for kernel, dtb, load bitmap to DDR etc). Overall I personally don't see much harm on keeping both the information (DDR available to u-boot and total available DDR). If the word effective is confusing than the print can be made more verbose as being intended in this patch-set or by following the suggestions given by Simon and Udit.
U-Boot isn't "using" 2GiB however. And in fact the command Simon is working on to dump the memory table and what's where, as far as U-Boot knows, would be helpful in that case.
"Available" and "Total" would be matching the terms used by "free" in Linux for example.
I still think both are valuable pieces of information (what's populated and what is usable by U-Boot AFAIR).
Yes, and that won't change the binary size much, thanks.
Hi Tom, Devarsh, Quentin
On 14-Oct-24 11:53 PM, Tom Rini wrote:
On Mon, Oct 14, 2024 at 07:23:09PM +0200, Quentin Schulz wrote:
Hi all,
On 10/14/24 5:35 PM, Tom Rini wrote:
On Mon, Oct 14, 2024 at 08:59:39PM +0530, Devarsh Thakkar wrote:
Hi,
On 14/10/24 19:57, Tom Rini wrote:
On Mon, Oct 14, 2024 at 10:10:43AM +0530, Neha Malcom Francis wrote:
Hi Andrew
On 11/10/24 01:59, Andrew Davis wrote: > On 10/10/24 1:50 PM, Simon Glass wrote: >> Hi Neha, >> >> On Thu, 10 Oct 2024 at 01:09, Neha Malcom Francis n-francis@ti.com wrote: >>> >>> The message "DRAM: 2 GiB (effective 32 GiB)" can be a little confusing, >>> modify the message to show exactly what is meant: >>> >>> "DRAM: 2 GiB (available for U-Boot out of total 32 GiB)" >>> >>> Signed-off-by: Neha Malcom Francis n-francis@ti.com >>> --- >>> common/board_f.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/common/board_f.c b/common/board_f.c >>> index 154675d0e40..b7add8f7d3d 100644 >>> --- a/common/board_f.c >>> +++ b/common/board_f.c >>> @@ -254,7 +254,7 @@ static int show_dram_config(void) >>> >>> print_size(gd->ram_size, ""); >>> if (!sizes_near(gd->ram_size, size)) { >>> - printf(" (effective "); >>> + printf(" (available for U-Boot out of total "); >>> print_size(size, ")"); >>> } >>> board_add_ram_info(0); >>> -- >>> 2.34.1 >>> >> >> I've forgotten why the first number can be so much lower than the >> second. What is causing that? >> >> This is quite a long string...could we say "(total 32 GiB)" ? Then >> perhaps add something to doc/ to talk about the banner that U-Boot >> prints? >> > > Why not just only print the total number? The amount available to > U-Boot seems like an internal detail, I'd guess most folks just what > to see at a glance how much DDR was detected on their system. >
Knowing how much u-boot is using might help someone who is working on some memory map related stuff or if they want to stop at u-boot prompt and tweak environment variables related to memory map (e.g. load address for kernel, dtb, load bitmap to DDR etc). Overall I personally don't see much harm on keeping both the information (DDR available to u-boot and total available DDR). If the word effective is confusing than the print can be made more verbose as being intended in this patch-set or by following the suggestions given by Simon and Udit.
U-Boot isn't "using" 2GiB however. And in fact the command Simon is working on to dump the memory table and what's where, as far as U-Boot knows, would be helpful in that case.
"Available" and "Total" would be matching the terms used by "free" in Linux for example.
I still think both are valuable pieces of information (what's populated and what is usable by U-Boot AFAIR).
Yes, and that won't change the binary size much, thanks.
Thank you for the inputs. I think we can go with s/effective/total and updating the documentation.
Hi Simon
+ Vignesh
On 11/10/24 00:20, Simon Glass wrote:
Hi Neha,
On Thu, 10 Oct 2024 at 01:09, Neha Malcom Francis n-francis@ti.com wrote:
The message "DRAM: 2 GiB (effective 32 GiB)" can be a little confusing, modify the message to show exactly what is meant:
"DRAM: 2 GiB (available for U-Boot out of total 32 GiB)"
Signed-off-by: Neha Malcom Francis n-francis@ti.com
common/board_f.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/board_f.c b/common/board_f.c index 154675d0e40..b7add8f7d3d 100644 --- a/common/board_f.c +++ b/common/board_f.c @@ -254,7 +254,7 @@ static int show_dram_config(void)
print_size(gd->ram_size, ""); if (!sizes_near(gd->ram_size, size)) {
printf(" (effective ");
printf(" (available for U-Boot out of total "); print_size(size, ")"); } board_add_ram_info(0);-- 2.34.1
I've forgotten why the first number can be so much lower than the second. What is causing that?
AFAIK, U-Boot supports up to 39-bit addressing and possibly since there are systems that have RAM sizes exceeding 39-bit, addressing has been capped to the first bank to avoid any possible problems. So U-Boot sets gd->ram_size to the first bank while it acknowledges that the system RAM is more than that. Tom can probably confirm if this is right.
In an offline discussion with Vignesh, he mentioned that a cleaner solution would be to extend out fdtdec_* functions to support all memory within a 39-bit address space.
This is quite a long string...could we say "(total 32 GiB)" ? Then perhaps add something to doc/ to talk about the banner that U-Boot prints?
Regards, Simon
participants (7)
-
Andrew Davis -
Devarsh Thakkar -
Kumar, Udit -
Neha Malcom Francis -
Quentin Schulz -
Simon Glass -
Tom Rini