[U-Boot] [PATCH] common: cli: Fix typo CONFIG_CMDINE -> CONFIG_CMDLINE

Patch f8bb6964 (Drop command-processing code when CONFIG_CMDLINE is disabled) introduced a small typo. This patch fixes it and unbreaks all boards again that don't have the Hush parser enabled.
Signed-off-by: Stefan Roese sr@denx.de Cc: Simon Glass sjg@chromium.org Cc: Tom Rini trini@konsulko.com --- common/cli.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/cli.c b/common/cli.c index 5e17da8..18d7e19 100644 --- a/common/cli.c +++ b/common/cli.c @@ -218,7 +218,7 @@ void cli_loop(void) parse_file_outer(); /* This point is never reached */ for (;;); -#elif defined(CONFIG_CMDINE) +#elif defined(CONFIG_CMDLINE) cli_simple_loop(); #else printf("## U-Boot command line is disabled. Please enable CONFIG_CMDLINE\n");

On Mon, Apr 04, 2016 at 04:32:15PM +0200, Stefan Roese wrote:
Patch f8bb6964 (Drop command-processing code when CONFIG_CMDLINE is disabled) introduced a small typo. This patch fixes it and unbreaks all boards again that don't have the Hush parser enabled.
Signed-off-by: Stefan Roese sr@denx.de Cc: Simon Glass sjg@chromium.org Cc: Tom Rini trini@konsulko.com
Applied to u-boot/master, thanks!

On 4 April 2016 at 08:32, Stefan Roese sr@denx.de wrote:
Patch f8bb6964 (Drop command-processing code when CONFIG_CMDLINE is disabled) introduced a small typo. This patch fixes it and unbreaks all boards again that don't have the Hush parser enabled.
Signed-off-by: Stefan Roese sr@denx.de Cc: Simon Glass sjg@chromium.org Cc: Tom Rini trini@konsulko.com
common/cli.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks Stefan, good to find this egregious bug before RC1. It would be good to have a version of sandbox that has both command line options, and more options in general.
Reviewed-by: Simon Glass sjg@chromium.org
participants (3)
-
Simon Glass
-
Stefan Roese
-
Tom Rini