RE: [U-Boot-Users] [PATCH] Add stricmp to lib_generic/string.c
-----Original Message----- From: wd@denx.de [mailto:wd@denx.de] Sent: Tuesday, 02 May 2006 3:35 PM To: Alan J. Luse Cc: u-boot-users@lists.sourceforge.net Subject: Re: [U-Boot-Users] [PATCH] Add stricmp to lib_generic/string.c
In message <5642B638DBEF6A4DBF9E9BC68144866D0276A59D@tamail1.timeamerica. com> you wrote:
Why should we add this? There is no code in U-Boot that
uses such a
function.
An upcoming submission uses stricmp. I can wait and submit this addition at that time if you like.
Try to avoid stricmp(). I will tend to reject it because it adds code size for very little benefit.
Best regards,
Wolfgang Denk
Wolfgang-
I rechecked where I was using it and can easily eliminate the reference making the patch submitted unnecessary.
Curiously enough I also ran a check to see where strnicmp is being used in all of U-Boot, since I was considering using it instead, and it doesn't seem to be used at all either even though its already in string.c. I will avoid using it as well since its an obvious candidate for elimination.
Regards,
Alan J. Luse Embedded Systems Engineer Time America, Inc.
In message 5642B638DBEF6A4DBF9E9BC68144866D0276A64E@tamail1.timeamerica.com you wrote:
I rechecked where I was using it and can easily eliminate the reference making the patch submitted unnecessary.
Fine. Thanks.
Curiously enough I also ran a check to see where strnicmp is being used in all of U-Boot, since I was considering using it instead, and it doesn't seem to be used at all either even though its already in string.c. I will avoid using it as well since its an obvious candidate for elimination.
Thanks for pointing out. I have to admit that I was not aware that we even had this function. It's gone now :-)
Best regards,
Wolfgang Denk
participants (2)
-
Alan J. Luse -
Wolfgang Denk