[U-Boot-Users] [PATCH] Spansion Flash configuration words
This is one of the first patches that will add support for a new 834x board (based on the 834x sys board).
CHANGELOG:
* Add the configuration words for the Spansion flash S29GL128N, S29GL256N and S29GL512N Patch by Marc Leeman, 4 Jul 2006
On Tue, 04 Jul 2006 13:40:08 +0200, Marc Leeman wrote:
This is one of the first patches that will add support for a new 834x board (based on the 834x sys board).
CHANGELOG:
- Add the configuration words for the Spansion flash S29GL128N, S29GL256N and S29GL512N Patch by Marc Leeman, 4 Jul 2006
Why do you need those? Those Spansion flashes work perfectly fine with the CFI driver!
Cheers Anders
Why do you need those?
U-Boot 1.1.4 (Jul 5 2006 - 13:26:03) MPC83XX
Clock configuration: Coherent System Bus: 264 MHz Core: 396 MHz Local Bus: 33 MHz CPU: MPC83xx, Rev: 1.1 at 396 MHz Board: Barco BARCO8347G1 Platform I2C: ready DRAM: Initializing SDRAM on Local Bus is NOT available!
DDR RAM: 256 MB FLASH:
Those Spansion flashes work perfectly fine with the CFI driver!
What flashes are you using and what version of U-Boot are you using?
I am using a git snapshot from 20060623 (to have the last mpc8349sys code).
I just switched the config to use the CFI driver and it's just stuck on detecting the flash.
[mleeman@neo u-boot-20060627]$ diff ~/no_backup/build-svc2.2.6.continuous-20060705-132011/build/u-boot-20060627/include/configs/BARCO8347G1.h include/configs/BARCO8347G1.h 133,134c133,134 < #undef CFG_FLASH_CFI /* use the Common Flash Interface */ < #undef CFG_FLASH_CFI_DRIVER /* use the CFI driver */ ---
#define CFG_FLASH_CFI /* use the Common Flash Interface */ #define CFG_FLASH_CFI_DRIVER /* use the CFI driver */
I wouldn't have added this if I didn't need a flash.c file for my platform (after having tested the default MPC8349EDMS config), but I'm always eager to correct any errors on my side and remove unneeded code:
U-Boot 1.1.4 (Jul 5 2006 - 12:05:58) MPC83XX
Clock configuration: Coherent System Bus: 264 MHz Core: 396 MHz Local Bus: 33 MHz CPU: MPC83xx, Rev: 1.1 at 396 MHz Board: Barco BARCO8347G1 Platform I2C: ready DRAM: Initializing SDRAM on Local Bus is NOT available! DDR RAM: 256 MB FLASH: Chip: S29GL128N 16 MB In: serial Out: serial Err: serial Net: TSEC0, TSEC1
Type run net_nfs to get kernel via tftpboot and mount root filesystem over NFS
Hit any key to stop autoboot: 0 =>
On Wed, 05 Jul 2006 13:39:00 +0200, Marc Leeman wrote:
Those Spansion flashes work perfectly fine with the CFI driver!
What flashes are you using and what version of U-Boot are you using?
Spansion S29GL128N90TFIR2, U-Boot has been working with this one for the past year.
U-Boot 1.1.4 (Apr 28 2006 - 16:11:24)
DRAM: 32 MB Flash: 16 MB In: serial Out: serial Err: serial U-Boot> flinfo
Bank # 1: CFI conformant FLASH (16 x 16) Size: 16 MB in 128 Sectors Erase timeout 16384 ms, write timeout 2 ms, buffer write timeout 5 ms, buffer size 32
I just switched the config to use the CFI driver and it's just stuck on detecting the flash.
Strange. I'll check if current git HEAD still works on our board and report back.
Cheers Anders
Spansion S29GL128N90TFIR2, U-Boot has been working with this one for the past year.
S29GL128N11FFI010 here
It must be the difference between the 90 and 110 ns access time that actus up.
In message 20060706083756.GE29052@scorpius.homelinux.org you wrote:
Spansion S29GL128N90TFIR2, U-Boot has been working with this one for the past year.
S29GL128N11FFI010 here
It must be the difference between the 90 and 110 ns access time that actus up.
If this is the case, then you probably have some memroy controller init problem, which you are just hushing up by using a custom flash driver.
I think you should fix this problem.
Best regards,
Wolfgang Denk
If this is the case, then you probably have some memroy controller init problem, which you are just hushing up by using a custom flash driver.
The memory controller init from the 834x? Oh, you mean the OR0 register for the flash?
I think you should fix this problem.
Thanks for the pointer. This might well be the case: we've been adjusting these registers and the 834x clocks in order to have access to the flash and get the timing right (and adjusting wait cycles).
I'll have another look with my collegues that were working on that. Tnx Wolfgang and Anders for pointing this out.
On Wed, 05 Jul 2006 14:54:03 +0200, Anders Larsen wrote:
On Wed, 05 Jul 2006 13:39:00 +0200, Marc Leeman wrote:
I just switched the config to use the CFI driver and it's just stuck on detecting the flash.
Strange. I'll check if current git HEAD still works on our board and report back.
For the record: I just rebuilt U-Boot from current git HEAD and it still detects our Spansion flashes just fine (HW: ARM little-endian).
Cheers Anders
In message 20060704114008.GX23183@scorpius.homelinux.org you wrote:
- Add the configuration words for the Spansion flash S29GL128N, S29GL256N and S29GL512N Patch by Marc Leeman, 4 Jul 2006
I reject this patch. First, it adds unreferences defintions - these are used nowhere in the code.
Second, as Anders Larsen already pointed out, you should use the CFI flash driver on such devices which does not need these defines.
Best regards,
Wolfgang Denk
participants (3)
-
Anders Larsen -
Marc Leeman -
Wolfgang Denk