[U-Boot-Users] [QUESTION/PATCH] Does MPC8349EMDS_config supersede MPC8349ADS_config?

hi kumar!
in case MPC8349ADS_config will not be made obsolete in the near future the following patch (which may be applied against top of boot/u-boot/u-boot.git) makes sense.
-h
Signed-off-by: Horst Kronstorfer hkronsto@frequentis.com
CHANGELOG
* Fixed signature when calling spd_sdram() in board/mpc8349ads/mpc8349ads.c.
board/mpc8349ads/mpc8349ads.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/board/mpc8349ads/mpc8349ads.c b/board/mpc8349ads/mpc8349ads.c index 505acbc..9841298 100644 --- a/board/mpc8349ads/mpc8349ads.c +++ b/board/mpc8349ads/mpc8349ads.c @@ -64,7 +64,7 @@ long int initdram (int board_type) /* DDR SDRAM - Main SODIMM */ im->sysconf.ddrlaw[0].bar = CFG_DDR_BASE & LAWBAR_BAR; #if defined(CONFIG_SPD_EEPROM) - msize = spd_sdram(NULL); + msize = spd_sdram(); #else msize = fixed_sdram(); #endif

On Mar 21, 2006, at 8:19 AM, KRONSTORFER Horst wrote:
hi kumar!
in case MPC8349ADS_config will not be made obsolete in the near future the following patch (which may be applied against top of boot/u-boot/u-boot.git) makes sense.
-h
I'd like to see if the new MPC8349EMDS_config can replace the current MPC8349ADS_config rather than support two board ports which are effectively for the same board.
- kumar
Signed-off-by: Horst Kronstorfer hkronsto@frequentis.com
CHANGELOG
- Fixed signature when calling spd_sdram() in board/mpc8349ads/
mpc8349ads.c.
board/mpc8349ads/mpc8349ads.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/board/mpc8349ads/mpc8349ads.c b/board/mpc8349ads/ mpc8349ads.c index 505acbc..9841298 100644 --- a/board/mpc8349ads/mpc8349ads.c +++ b/board/mpc8349ads/mpc8349ads.c @@ -64,7 +64,7 @@ long int initdram (int board_type) /* DDR SDRAM - Main SODIMM */ im->sysconf.ddrlaw[0].bar = CFG_DDR_BASE & LAWBAR_BAR; #if defined(CONFIG_SPD_EEPROM)
msize = spd_sdram(NULL);
msize = spd_sdram();
#else msize = fixed_sdram(); #endif
This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel? cmd_______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
participants (2)
-
KRONSTORFER Horst
-
Kumar Gala