[U-Boot] [PATCH] arm: kirkwood: suen3: fixed build warning
This patch fixes following build warning
Invalid Kwbimage command Type - valid names are: BOOT_FROM, NAND_ECC_MODE, NAND_PAGE_SIZE, SATA_PIO_MODE, DDR_INIT_DELAY, DATA, , spi, nand, sata, pex, uart
Signed-off-by: Prafulla Wadaskar prafulla@marvell.com --- board/keymile/km_arm/kwbimage.cfg | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/board/keymile/km_arm/kwbimage.cfg b/board/keymile/km_arm/kwbimage.cfg index d6edd27..26d6aa0 100644 --- a/board/keymile/km_arm/kwbimage.cfg +++ b/board/keymile/km_arm/kwbimage.cfg @@ -64,7 +64,6 @@ DATA 0xFFD01400 0x43000400 # SDRAM Configuration Register # bit31-30: 01
DATA 0xFFD01404 0x36343000 # DDR Controller Control Low - 0x38543000 # bit 3-0: 0 reserved # bit 4: 0=addr/cmd in smame cycle # bit 5: 0=clk is driven during self refresh, we don't care for APX @@ -170,7 +169,7 @@ DATA 0xFFD0149C 0x0000E90F # CPU ODT Control # bit11-10:2, DQ_ODTSel. ODT select turned on, 75 ohm
DATA 0xFFD01480 0x00000001 # DDR Initialization Control -#bit0=1, enable DDR init upon this register write +# bit0=1, enable DDR init upon this register write
# End of Header extension DATA 0x0 0x0
Prafulla Wadaskar wrote:
This patch fixes following build warning
Invalid Kwbimage command Type - valid names are: BOOT_FROM, NAND_ECC_MODE, NAND_PAGE_SIZE, SATA_PIO_MODE, DDR_INIT_DELAY, DATA, , spi, nand, sata, pex, uart
Signed-off-by: Prafulla Wadaskar prafulla@marvell.com
board/keymile/km_arm/kwbimage.cfg | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/board/keymile/km_arm/kwbimage.cfg b/board/keymile/km_arm/kwbimage.cfg index d6edd27..26d6aa0 100644 --- a/board/keymile/km_arm/kwbimage.cfg +++ b/board/keymile/km_arm/kwbimage.cfg @@ -64,7 +64,6 @@ DATA 0xFFD01400 0x43000400 # SDRAM Configuration Register # bit31-30: 01
DATA 0xFFD01404 0x36343000 # DDR Controller Control Low
0x38543000# bit 3-0: 0 reserved # bit 4: 0=addr/cmd in smame cycle # bit 5: 0=clk is driven during self refresh, we don't care for APX @@ -170,7 +169,7 @@ DATA 0xFFD0149C 0x0000E90F # CPU ODT Control # bit11-10:2, DQ_ODTSel. ODT select turned on, 75 ohm
DATA 0xFFD01480 0x00000001 # DDR Initialization Control -#bit0=1, enable DDR init upon this register write +# bit0=1, enable DDR init upon this register write
# End of Header extension DATA 0x0 0x0
This patch did not fix any of the warnings I saw. Please recheck. Tom
-----Original Message----- From: Tom [mailto:Tom.Rix@windriver.com] Sent: Thursday, March 04, 2010 7:25 PM To: Prafulla Wadaskar Cc: u-boot@lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik Subject: Re: [U-Boot] [PATCH] arm: kirkwood: suen3: fixed build warning
Prafulla Wadaskar wrote:
This patch fixes following build warning
Invalid Kwbimage command Type - valid names are: BOOT_FROM,
NAND_ECC_MODE, NAND_PAGE_SIZE, SATA_PIO_MODE, DDR_INIT_DELAY, DATA, , spi, nand, sata, pex, uart
Signed-off-by: Prafulla Wadaskar prafulla@marvell.com
board/keymile/km_arm/kwbimage.cfg | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/board/keymile/km_arm/kwbimage.cfg
b/board/keymile/km_arm/kwbimage.cfg
index d6edd27..26d6aa0 100644 --- a/board/keymile/km_arm/kwbimage.cfg +++ b/board/keymile/km_arm/kwbimage.cfg @@ -64,7 +64,6 @@ DATA 0xFFD01400 0x43000400 # SDRAM
Configuration Register
# bit31-30: 01
DATA 0xFFD01404 0x36343000 # DDR Controller Control Low
0x38543000# bit 3-0: 0 reserved # bit 4: 0=addr/cmd in smame cycle # bit 5: 0=clk is driven during self refresh, we don't
care for APX
@@ -170,7 +169,7 @@ DATA 0xFFD0149C 0x0000E90F # CPU
ODT Control
# bit11-10:2, DQ_ODTSel. ODT select turned on, 75 ohm
DATA 0xFFD01480 0x00000001 # DDR Initialization Control -#bit0=1, enable DDR init upon this register write +# bit0=1, enable DDR init upon this register write
# End of Header extension DATA 0x0 0x0
This patch did not fix any of the warnings I saw. Please recheck.
Hi Tom I am sorry to say, it is not build warning but it is runtime stderr generated during kwbimage.cfg parsing. This patch removes above mentioned "Invalid Kwbimage command Type" error reported by mkimage tool during u-boot.kwb target creation for this board.
Regards.. Prafulla . .
Tom
Prafulla Wadaskar wrote:
-----Original Message----- From: Tom [mailto:Tom.Rix@windriver.com] Sent: Thursday, March 04, 2010 7:25 PM To: Prafulla Wadaskar Cc: u-boot@lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik Subject: Re: [U-Boot] [PATCH] arm: kirkwood: suen3: fixed build warning
Prafulla Wadaskar wrote:
This patch fixes following build warning
Invalid Kwbimage command Type - valid names are: BOOT_FROM,
NAND_ECC_MODE, NAND_PAGE_SIZE, SATA_PIO_MODE, DDR_INIT_DELAY, DATA, , spi, nand, sata, pex, uart
Signed-off-by: Prafulla Wadaskar prafulla@marvell.com
board/keymile/km_arm/kwbimage.cfg | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/board/keymile/km_arm/kwbimage.cfg
b/board/keymile/km_arm/kwbimage.cfg
index d6edd27..26d6aa0 100644 --- a/board/keymile/km_arm/kwbimage.cfg +++ b/board/keymile/km_arm/kwbimage.cfg @@ -64,7 +64,6 @@ DATA 0xFFD01400 0x43000400 # SDRAM
Configuration Register
# bit31-30: 01
DATA 0xFFD01404 0x36343000 # DDR Controller Control Low
0x38543000# bit 3-0: 0 reserved # bit 4: 0=addr/cmd in smame cycle # bit 5: 0=clk is driven during self refresh, we don't
care for APX
@@ -170,7 +169,7 @@ DATA 0xFFD0149C 0x0000E90F # CPU
ODT Control
# bit11-10:2, DQ_ODTSel. ODT select turned on, 75 ohm
DATA 0xFFD01480 0x00000001 # DDR Initialization Control -#bit0=1, enable DDR init upon this register write +# bit0=1, enable DDR init upon this register write
# End of Header extension DATA 0x0 0x0
This patch did not fix any of the warnings I saw. Please recheck.
Hi Tom I am sorry to say, it is not build warning but it is runtime stderr generated during kwbimage.cfg parsing. This patch removes above mentioned "Invalid Kwbimage command Type" error reported by mkimage tool during u-boot.kwb target creation for this board.
Ah! Ok that helps. I did not hold up your pull request for this. Would you like this to go into ARM now?
Tom
Regards.. Prafulla . .
Tom
-----Original Message----- From: Tom [mailto:Tom.Rix@windriver.com] Sent: Friday, March 05, 2010 7:49 PM To: Prafulla Wadaskar Cc: u-boot@lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik Subject: Re: [U-Boot] [PATCH] arm: kirkwood: suen3: fixed build warning
Prafulla Wadaskar wrote:
-----Original Message----- From: Tom [mailto:Tom.Rix@windriver.com] Sent: Thursday, March 04, 2010 7:25 PM To: Prafulla Wadaskar Cc: u-boot@lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik Subject: Re: [U-Boot] [PATCH] arm: kirkwood: suen3: fixed build warning
Prafulla Wadaskar wrote:
This patch fixes following build warning
Invalid Kwbimage command Type - valid names are: BOOT_FROM,
NAND_ECC_MODE, NAND_PAGE_SIZE, SATA_PIO_MODE, DDR_INIT_DELAY, DATA, , spi, nand, sata, pex, uart
Signed-off-by: Prafulla Wadaskar prafulla@marvell.com
board/keymile/km_arm/kwbimage.cfg | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/board/keymile/km_arm/kwbimage.cfg
b/board/keymile/km_arm/kwbimage.cfg
index d6edd27..26d6aa0 100644 --- a/board/keymile/km_arm/kwbimage.cfg +++ b/board/keymile/km_arm/kwbimage.cfg @@ -64,7 +64,6 @@ DATA 0xFFD01400 0x43000400 # SDRAM
Configuration Register
# bit31-30: 01
DATA 0xFFD01404 0x36343000 # DDR Controller Control Low
0x38543000# bit 3-0: 0 reserved # bit 4: 0=addr/cmd in smame cycle # bit 5: 0=clk is driven during self refresh, we don't
care for APX
@@ -170,7 +169,7 @@ DATA 0xFFD0149C 0x0000E90F # CPU
ODT Control
# bit11-10:2, DQ_ODTSel. ODT select turned on, 75 ohm
DATA 0xFFD01480 0x00000001 # DDR Initialization Control -#bit0=1, enable DDR init upon this register write +# bit0=1, enable DDR init upon this register write
# End of Header extension DATA 0x0 0x0
This patch did not fix any of the warnings I saw. Please recheck.
Hi Tom I am sorry to say, it is not build warning but it is runtime stderr generated
during kwbimage.cfg parsing.
This patch removes above mentioned "Invalid Kwbimage
command Type" error reported by mkimage tool during u-boot.kwb target creation for this board.
Ah! Ok that helps. I did not hold up your pull request for this. Would you like this to go into ARM now?
Yes. Its better, if you can pull this too ;-) otherwise Pls flag me if I need to send pull request
Regards.. Prafulla . .
Tom
Regards.. Prafulla . .
Tom
Prafulla Wadaskar wrote:
-----Original Message----- From: Tom [mailto:Tom.Rix@windriver.com] Sent: Friday, March 05, 2010 7:49 PM To: Prafulla Wadaskar Cc: u-boot@lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik Subject: Re: [U-Boot] [PATCH] arm: kirkwood: suen3: fixed build warning
Prafulla Wadaskar wrote:
-----Original Message----- From: Tom [mailto:Tom.Rix@windriver.com] Sent: Thursday, March 04, 2010 7:25 PM To: Prafulla Wadaskar Cc: u-boot@lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik Subject: Re: [U-Boot] [PATCH] arm: kirkwood: suen3: fixed build warning
Prafulla Wadaskar wrote:
This patch fixes following build warning
Invalid Kwbimage command Type - valid names are: BOOT_FROM,
NAND_ECC_MODE, NAND_PAGE_SIZE, SATA_PIO_MODE, DDR_INIT_DELAY, DATA, , spi, nand, sata, pex, uart
Signed-off-by: Prafulla Wadaskar prafulla@marvell.com
board/keymile/km_arm/kwbimage.cfg | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/board/keymile/km_arm/kwbimage.cfg
b/board/keymile/km_arm/kwbimage.cfg
index d6edd27..26d6aa0 100644 --- a/board/keymile/km_arm/kwbimage.cfg +++ b/board/keymile/km_arm/kwbimage.cfg @@ -64,7 +64,6 @@ DATA 0xFFD01400 0x43000400 # SDRAM
Configuration Register
# bit31-30: 01
DATA 0xFFD01404 0x36343000 # DDR Controller Control Low
0x38543000# bit 3-0: 0 reserved # bit 4: 0=addr/cmd in smame cycle # bit 5: 0=clk is driven during self refresh, we don't
care for APX
@@ -170,7 +169,7 @@ DATA 0xFFD0149C 0x0000E90F # CPU
ODT Control
# bit11-10:2, DQ_ODTSel. ODT select turned on, 75 ohm
DATA 0xFFD01480 0x00000001 # DDR Initialization Control -#bit0=1, enable DDR init upon this register write +# bit0=1, enable DDR init upon this register write
# End of Header extension DATA 0x0 0x0
This patch did not fix any of the warnings I saw. Please recheck.
Hi Tom I am sorry to say, it is not build warning but it is runtime stderr generated
during kwbimage.cfg parsing.
This patch removes above mentioned "Invalid Kwbimage
command Type" error reported by mkimage tool during u-boot.kwb target creation for this board. Ah! Ok that helps. I did not hold up your pull request for this. Would you like this to go into ARM now?
Yes. Its better, if you can pull this too ;-) otherwise Pls flag me if I need to send pull request
I have applied it to ARM Thanks Tom
Regards.. Prafulla . .
Tom
Regards.. Prafulla . .
Tom
participants (2)
-
Prafulla Wadaskar -
Tom