[U-Boot-Users] [PATCH] [PATCH] Fix "usb part" command

From: Christian Eggers christian@p2400.wgnetz.xx
Only print partition for selected device if user supplied the <dev> arg with the "usb part [dev]" command.
Signed-off-by: Christian Eggers ceggers@gmx.de --- common/cmd_usb.c | 19 +++++++++++++++---- 1 files changed, 15 insertions(+), 4 deletions(-)
diff --git a/common/cmd_usb.c b/common/cmd_usb.c index 9be86b8..ed51087 100644 --- a/common/cmd_usb.c +++ b/common/cmd_usb.c @@ -553,13 +553,24 @@ int do_usb (cmd_tbl_t *cmdtp, int flag, }
if (strncmp(argv[1],"part",4) == 0) { - int devno, ok; - for (ok=0, devno=0; devno<USB_MAX_STOR_DEV; ++devno) { + int devno, ok = 0; + if (argc==2) { + for (devno=0; devno<USB_MAX_STOR_DEV; ++devno) { + stor_dev=usb_stor_get_dev(devno); + if (stor_dev->type!=DEV_TYPE_UNKNOWN) { + ok++; + if (devno) + printf("\n"); + printf("print_part of %x\n",devno); + print_part(stor_dev); + } + } + } + else { + devno=simple_strtoul(argv[2], NULL, 16); stor_dev=usb_stor_get_dev(devno); if (stor_dev->type!=DEV_TYPE_UNKNOWN) { ok++; - if (devno) - printf("\n"); printf("print_part of %x\n",devno); print_part(stor_dev); }

In message 121458881184-git-send-email-ceggers@gmx.de you wrote:
From: Christian Eggers christian@p2400.wgnetz.xx
Only print partition for selected device if user supplied the <dev> arg with the "usb part [dev]" command.
What is the rationale of this modification, i. e. which bug are you fixing?
I think current behaviour is consistent between "ide part", "scsi part", "usb part" etc. so if there is a problem here this might need to be changed elsewhere, too ?
Best regards,
Wolfgang Denk

Wolfgang Denk wd@denx.de writes:
In message 121458881184-git-send-email-ceggers@gmx.de you wrote:
From: Christian Eggers christian@p2400.wgnetz.xx
Only print partition for selected device if user supplied the <dev> arg with the "usb part [dev]" command.
What is the rationale of this modification, i. e. which bug are you fixing?
I think this fix is correct. If I do
usb part
U-Boot (correcly) prints the partitions of all devices. If I type
usb part 0
i only want the partitions on device 0. Without this patch I still get all partitions on all devices. This is wrong.
I think current behaviour is consistent between "ide part", "scsi part", "usb part" etc. so if there is a problem here this might need to be changed elsewhere, too ?
I just took a look at cmd_ide, and AFAICS it does exactly what USB will do with this patch.
Best regards
Markus Klotzbuecher
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de

In message 874p6y2gi9.fsf@denx.de you wrote:
Only print partition for selected device if user supplied the <dev> arg with the "usb part [dev]" command.
What is the rationale of this modification, i. e. which bug are you fixing?
I think this fix is correct. If I do
I see. Thanks.
Best regards,
Wolfgang Denk

Christian Eggers ceggers@gmx.de writes:
From: Christian Eggers christian@p2400.wgnetz.xx
Only print partition for selected device if user supplied the <dev> arg with the "usb part [dev]" command.
Signed-off-by: Christian Eggers ceggers@gmx.de
Acked-by: Markus Klotzbuecher mk@denx.de
Wolfgang, please apply!
Best regards
Markus Klotzbuecher
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de

In message 87zloq11wg.fsf@denx.de you wrote:
Christian Eggers ceggers@gmx.de writes:
From: Christian Eggers christian@p2400.wgnetz.xx
Only print partition for selected device if user supplied the <dev> arg with the "usb part [dev]" command.
Signed-off-by: Christian Eggers ceggers@gmx.de
Acked-by: Markus Klotzbuecher mk@denx.de
Wolfgang, please apply!
Done. Thanks.
Best regards,
Wolfgang Denk

In message 121458881184-git-send-email-ceggers@gmx.de you wrote:
From: Christian Eggers christian@p2400.wgnetz.xx
Only print partition for selected device if user supplied the <dev> arg with the "usb part [dev]" command.
Signed-off-by: Christian Eggers ceggers@gmx.de
common/cmd_usb.c | 19 +++++++++++++++---- 1 files changed, 15 insertions(+), 4 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
participants (3)
-
Christian Eggers
-
Markus Klotzbücher
-
Wolfgang Denk