Re: [U-Boot] [PATCH] Make patman usable outside of u-boot tree
On Wed, Jan 9, 2013 at 2:13 PM, Simon Glass sjg@google.com wrote:
Hi Vadim,
Looks good! Please can you add a single character option?
Simon, I could not think of a good single letter option to pick, so I did not, but if you have a suggestion I implement it.
Can you also please add an option to skip the 'apply' step? This takes quite a bit of time, and it would be nice to have a 'fast' option.
does it have to be in this CL?
cheers, /vb
Regards, Simon
On Wed, Jan 9, 2013 at 1:48 PM, Doug Anderson dianders@chromium.org wrote:
Vadim,
Thanks for the patch! Looks good in general, though please add the "patman" prefix to the first line of your commit message.
On Wed, Jan 9, 2013 at 1:13 PM, Vadim Bendebury vbendeb@chromium.org wrote:
To make it usable in git trees not providing a patch checker implementation, add a command line option, allowing to suippress patch
s/suippress/suppress
+parser.add_option('--no-check', action='store_true', dest='no_check',
default=False,help="Don't check for patch compliance")IMHO It would be slightly better to use action='store_false', dest='check', and default=True (just to avoid so many double-negatives).
-Doug
Hi Vadim,
On Wed, Jan 9, 2013 at 2:16 PM, Vadim Bendebury vbendeb@chromium.org wrote:
On Wed, Jan 9, 2013 at 2:13 PM, Simon Glass sjg@google.com wrote:
Hi Vadim,
Looks good! Please can you add a single character option?
Simon, I could not think of a good single letter option to pick, so I did not, but if you have a suggestion I implement it.
I can't think of a good one.
-C or -P ?
Can you also please add an option to skip the 'apply' step? This takes quite a bit of time, and it would be nice to have a 'fast' option.
does it have to be in this CL?
No not at all.
cheers, /vb
Regards, Simon
Regards, Simon
On Wed, Jan 9, 2013 at 1:48 PM, Doug Anderson dianders@chromium.org wrote:
Vadim,
Thanks for the patch! Looks good in general, though please add the "patman" prefix to the first line of your commit message.
On Wed, Jan 9, 2013 at 1:13 PM, Vadim Bendebury vbendeb@chromium.org wrote:
To make it usable in git trees not providing a patch checker implementation, add a command line option, allowing to suippress patch
s/suippress/suppress
+parser.add_option('--no-check', action='store_true', dest='no_check',
default=False,help="Don't check for patch compliance")IMHO It would be slightly better to use action='store_false', dest='check', and default=True (just to avoid so many double-negatives).
-Doug
On Wed, Jan 9, 2013 at 2:22 PM, Simon Glass sjg@chromium.org wrote:
Hi Vadim,
On Wed, Jan 9, 2013 at 2:16 PM, Vadim Bendebury vbendeb@chromium.org wrote:
On Wed, Jan 9, 2013 at 2:13 PM, Simon Glass sjg@google.com wrote:
Hi Vadim,
Looks good! Please can you add a single character option?
Simon, I could not think of a good single letter option to pick, so I did not, but if you have a suggestion I implement it.
I can't think of a good one.
-C or -P ?
Yeah, I feel a bit awkward about these, also, it would be inconsistent with --no-tags which does not have a single letter alternative. Let's see what others think about it - I would rather leave it as is...
cheers, /v
Can you also please add an option to skip the 'apply' step? This takes quite a bit of time, and it would be nice to have a 'fast' option.
does it have to be in this CL?
No not at all.
cheers, /vb
Regards, Simon
Regards, Simon
On Wed, Jan 9, 2013 at 1:48 PM, Doug Anderson dianders@chromium.org wrote:
Vadim,
Thanks for the patch! Looks good in general, though please add the "patman" prefix to the first line of your commit message.
On Wed, Jan 9, 2013 at 1:13 PM, Vadim Bendebury vbendeb@chromium.org wrote:
To make it usable in git trees not providing a patch checker implementation, add a command line option, allowing to suippress patch
s/suippress/suppress
+parser.add_option('--no-check', action='store_true', dest='no_check',
default=False,help="Don't check for patch compliance")IMHO It would be slightly better to use action='store_false', dest='check', and default=True (just to avoid so many double-negatives).
-Doug
participants (2)
-
Simon Glass -
Vadim Bendebury