[U-Boot] [PATCH] tools: genboardscfg: move buildman path to first
To system which has kconfiglib installed, genboardscfg will use system kconfiglib, we need it use U-Boot owned version, so move the buildman path to first.
Signed-off-by: Peng Fan peng.fan@nxp.com Cc: Masahiro Yamada yamada.m@jp.panasonic.com Cc: Simon Glass sjg@chromium.org Cc: Tom Rini trini@konsulko.com --- tools/genboardscfg.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/genboardscfg.py b/tools/genboardscfg.py index 0648472af0..e9bbd15e15 100755 --- a/tools/genboardscfg.py +++ b/tools/genboardscfg.py @@ -24,7 +24,7 @@ import sys import tempfile import time
-sys.path.append(os.path.join(os.path.dirname(__file__), 'buildman')) +sys.path.insert(1, os.path.join(os.path.dirname(__file__), 'buildman')) import kconfiglib
### constant variables ###
2018-07-24 15:27 GMT+09:00 Peng Fan peng.fan@nxp.com:
To system which has kconfiglib installed, genboardscfg will use system kconfiglib, we need it use U-Boot owned version, so move the buildman path to first.
Signed-off-by: Peng Fan peng.fan@nxp.com Cc: Masahiro Yamada yamada.m@jp.panasonic.com Cc: Simon Glass sjg@chromium.org Cc: Tom Rini trini@konsulko.com
Acked-by: Masahiro Yamada yamada.masahiro@socionext.com
tools/genboardscfg.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/genboardscfg.py b/tools/genboardscfg.py index 0648472af0..e9bbd15e15 100755 --- a/tools/genboardscfg.py +++ b/tools/genboardscfg.py @@ -24,7 +24,7 @@ import sys import tempfile import time
-sys.path.append(os.path.join(os.path.dirname(__file__), 'buildman')) +sys.path.insert(1, os.path.join(os.path.dirname(__file__), 'buildman')) import kconfiglib
### constant variables ###
2.14.1
U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Hi Peng,
On 24 July 2018 at 00:27, Peng Fan peng.fan@nxp.com wrote:
To system which has kconfiglib installed, genboardscfg will use system kconfiglib, we need it use U-Boot owned version, so move the buildman path to first.
Signed-off-by: Peng Fan peng.fan@nxp.com Cc: Masahiro Yamada yamada.m@jp.panasonic.com Cc: Simon Glass sjg@chromium.org Cc: Tom Rini trini@konsulko.com
tools/genboardscfg.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/genboardscfg.py b/tools/genboardscfg.py index 0648472af0..e9bbd15e15 100755 --- a/tools/genboardscfg.py +++ b/tools/genboardscfg.py @@ -24,7 +24,7 @@ import sys import tempfile import time
-sys.path.append(os.path.join(os.path.dirname(__file__), 'buildman')) +sys.path.insert(1, os.path.join(os.path.dirname(__file__), 'buildman'))
How come you insert this second in the list rather than first? If that is deliberate, can you please add a comment?
import kconfiglib
### constant variables ###
2.14.1
Regards, Simon
Hi Simon,
-----Original Message----- From: sjg@google.com [mailto:sjg@google.com] On Behalf Of Simon Glass Sent: 2018年7月25日 10:45 To: Peng Fan peng.fan@nxp.com Cc: U-Boot Mailing List u-boot@lists.denx.de; dl-linux-imx linux-imx@nxp.com; Masahiro Yamada yamada.m@jp.panasonic.com; Tom Rini trini@konsulko.com Subject: Re: [PATCH] tools: genboardscfg: move buildman path to first
Hi Peng,
On 24 July 2018 at 00:27, Peng Fan peng.fan@nxp.com wrote:
To system which has kconfiglib installed, genboardscfg will use system kconfiglib, we need it use U-Boot owned version, so move the buildman path to first.
Signed-off-by: Peng Fan peng.fan@nxp.com Cc: Masahiro Yamada yamada.m@jp.panasonic.com Cc: Simon Glass sjg@chromium.org Cc: Tom Rini trini@konsulko.com
tools/genboardscfg.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/genboardscfg.py b/tools/genboardscfg.py index 0648472af0..e9bbd15e15 100755 --- a/tools/genboardscfg.py +++ b/tools/genboardscfg.py @@ -24,7 +24,7 @@ import sys import tempfile import time
-sys.path.append(os.path.join(os.path.dirname(__file__), 'buildman')) +sys.path.insert(1, os.path.join(os.path.dirname(__file__), +'buildman'))
How come you insert this second in the list rather than first? If that is deliberate, can you please add a comment?
Do you mean I need to use `sys.path.insert(0, os.path.join(os.path.dirname(__file__), +'buildman'))`?
I print my sys.path, the first is '', So I follow other code in uboot, and use '1' here.
Thanks, Peng.
import kconfiglib
### constant variables ###
2.14.1
Regards, Simon
Hi Peng,
On 24 July 2018 at 19:51, Peng Fan peng.fan@nxp.com wrote:
Hi Simon,
-----Original Message----- From: sjg@google.com [mailto:sjg@google.com] On Behalf Of Simon Glass Sent: 2018年7月25日 10:45 To: Peng Fan peng.fan@nxp.com Cc: U-Boot Mailing List u-boot@lists.denx.de; dl-linux-imx linux-imx@nxp.com; Masahiro Yamada yamada.m@jp.panasonic.com; Tom Rini trini@konsulko.com Subject: Re: [PATCH] tools: genboardscfg: move buildman path to first
Hi Peng,
On 24 July 2018 at 00:27, Peng Fan peng.fan@nxp.com wrote:
To system which has kconfiglib installed, genboardscfg will use system kconfiglib, we need it use U-Boot owned version, so move the buildman path to first.
Signed-off-by: Peng Fan peng.fan@nxp.com Cc: Masahiro Yamada yamada.m@jp.panasonic.com Cc: Simon Glass sjg@chromium.org Cc: Tom Rini trini@konsulko.com
tools/genboardscfg.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/genboardscfg.py b/tools/genboardscfg.py index 0648472af0..e9bbd15e15 100755 --- a/tools/genboardscfg.py +++ b/tools/genboardscfg.py @@ -24,7 +24,7 @@ import sys import tempfile import time
-sys.path.append(os.path.join(os.path.dirname(__file__), 'buildman')) +sys.path.insert(1, os.path.join(os.path.dirname(__file__), +'buildman'))
How come you insert this second in the list rather than first? If that is deliberate, can you please add a comment?
Do you mean I need to use `sys.path.insert(0, os.path.join(os.path.dirname(__file__), +'buildman'))`?
I print my sys.path, the first is '', So I follow other code in uboot, and use '1' here.
OK I see, fair enough.
Reviewed-by: Simon Glass sjg@chromium.org
On Tue, Jul 24, 2018 at 02:27:18PM +0800, Peng Fan wrote:
To system which has kconfiglib installed, genboardscfg will use system kconfiglib, we need it use U-Boot owned version, so move the buildman path to first.
Signed-off-by: Peng Fan peng.fan@nxp.com Cc: Masahiro Yamada yamada.m@jp.panasonic.com Cc: Simon Glass sjg@chromium.org Cc: Tom Rini trini@konsulko.com Acked-by: Masahiro Yamada yamada.masahiro@socionext.com Reviewed-by: Simon Glass sjg@chromium.org
Applied to u-boot/master, thanks!
participants (4)
-
Masahiro Yamada -
Peng Fan -
Simon Glass -
Tom Rini