[U-Boot] [PATCH] sandbox: move source files from board/ to arch/sandbox/
Prior to commit 33a02da0, all boards must have board/${BOARD}/ or board/${VENDOR}/${BOARD}/ directory. Now this rule is obsolete.
It looks weird that sandbox defines "vendor" and "board" just for meeting the old U-Boot directory structure.
Signed-off-by: Masahiro Yamada yamada.m@jp.panasonic.com Cc: Simon Glass sjg@chromium.org --- Simon,
I moved board/sandbox/sandbox/sandbox.c to arch/sandbox/lib/sandbox.c
But if there is a more suitable place or file-name, please move.
arch/sandbox/lib/Makefile | 2 +- {board/sandbox/sandbox => arch/sandbox/lib}/sandbox.c | 0 board/sandbox/sandbox/Makefile | 7 ------- boards.cfg | 2 +- {board/sandbox/sandbox => doc}/README.sandbox | 0 5 files changed, 2 insertions(+), 9 deletions(-) rename {board/sandbox/sandbox => arch/sandbox/lib}/sandbox.c (100%) delete mode 100644 board/sandbox/sandbox/Makefile rename {board/sandbox/sandbox => doc}/README.sandbox (100%)
diff --git a/arch/sandbox/lib/Makefile b/arch/sandbox/lib/Makefile index 4c1a38d..6480ebf 100644 --- a/arch/sandbox/lib/Makefile +++ b/arch/sandbox/lib/Makefile @@ -8,4 +8,4 @@ #
-obj-y += interrupts.o +obj-y += interrupts.o sandbox.o diff --git a/board/sandbox/sandbox/sandbox.c b/arch/sandbox/lib/sandbox.c similarity index 100% rename from board/sandbox/sandbox/sandbox.c rename to arch/sandbox/lib/sandbox.c diff --git a/board/sandbox/sandbox/Makefile b/board/sandbox/sandbox/Makefile deleted file mode 100644 index a0b9880..0000000 --- a/board/sandbox/sandbox/Makefile +++ /dev/null @@ -1,7 +0,0 @@ -# -# Copyright (c) 2011 The Chromium OS Authors. -# -# SPDX-License-Identifier: GPL-2.0+ -# - -obj-y := sandbox.o diff --git a/boards.cfg b/boards.cfg index c83aff3..fc002f6 100644 --- a/boards.cfg +++ b/boards.cfg @@ -1158,7 +1158,7 @@ Active powerpc ppc4xx - xilinx ppc405-generic Active powerpc ppc4xx - xilinx ppc405-generic xilinx-ppc405-generic_flash xilinx-ppc405-generic:SYS_TEXT_BASE=0xF7F60000,RESET_VECTOR_ADDRESS=0xF7FFFFFC Ricardo Ribalda ricardo.ribalda@uam.es Active powerpc ppc4xx - xilinx ppc440-generic xilinx-ppc440-generic xilinx-ppc440-generic:SYS_TEXT_BASE=0x04000000,RESET_VECTOR_ADDRESS=0x04100000,BOOT_FROM_XMD=1 Ricardo Ribalda ricardo.ribalda@uam.es Active powerpc ppc4xx - xilinx ppc440-generic xilinx-ppc440-generic_flash xilinx-ppc440-generic:SYS_TEXT_BASE=0xF7F60000,RESET_VECTOR_ADDRESS=0xF7FFFFFC Ricardo Ribalda ricardo.ribalda@uam.es -Active sandbox sandbox - sandbox sandbox sandbox - Simon Glass sjg@chromium.org +Active sandbox sandbox - - <none> sandbox - Simon Glass sjg@chromium.org Active sh sh2 - renesas rsk7203 rsk7203 - Nobuhiro Iwamatsu iwamatsu.nobuhiro@renesas.com:Nobuhiro Iwamatsu iwamatsu@nigauri.org Active sh sh2 - renesas rsk7264 rsk7264 - Phil Edworthy phil.edworthy@renesas.com Active sh sh2 - renesas rsk7269 rsk7269 - - diff --git a/board/sandbox/sandbox/README.sandbox b/doc/README.sandbox similarity index 100% rename from board/sandbox/sandbox/README.sandbox rename to doc/README.sandbox
Hi Masahiro,
On 21 April 2014 03:39, Masahiro Yamada yamada.m@jp.panasonic.com wrote:
Prior to commit 33a02da0, all boards must have board/${BOARD}/ or board/${VENDOR}/${BOARD}/ directory. Now this rule is obsolete.
It looks weird that sandbox defines "vendor" and "board" just for meeting the old U-Boot directory structure.
Signed-off-by: Masahiro Yamada yamada.m@jp.panasonic.com Cc: Simon Glass sjg@chromium.org
Simon,
I moved board/sandbox/sandbox/sandbox.c to arch/sandbox/lib/sandbox.c
But if there is a more suitable place or file-name, please move.
I like the README move, but I worry about not having a sandbox board, from the point of view of discoverability. How will people find it?
Regards, Simon
Hi Simon,
On Mon, 21 Apr 2014 15:02:20 -0600 Simon Glass sjg@chromium.org wrote:
Hi Masahiro,
On 21 April 2014 03:39, Masahiro Yamada yamada.m@jp.panasonic.com wrote:
Prior to commit 33a02da0, all boards must have board/${BOARD}/ or board/${VENDOR}/${BOARD}/ directory. Now this rule is obsolete.
It looks weird that sandbox defines "vendor" and "board" just for meeting the old U-Boot directory structure.
Signed-off-by: Masahiro Yamada yamada.m@jp.panasonic.com Cc: Simon Glass sjg@chromium.org
Simon,
I moved board/sandbox/sandbox/sandbox.c to arch/sandbox/lib/sandbox.c
But if there is a more suitable place or file-name, please move.
I like the README move, but I worry about not having a sandbox board, from the point of view of discoverability. How will people find it?
I am not sure if this is necessary.
I just personaly thought the board directory seems odd for Sandbox because it is not a real board.
If you don't like this patch, feel free to reject it.
Best Regards Masahiro Yamada
Hi Masahiro,
On 21 April 2014 19:00, Masahiro Yamada yamada.m@jp.panasonic.com wrote:
Hi Simon,
On Mon, 21 Apr 2014 15:02:20 -0600 Simon Glass sjg@chromium.org wrote:
Hi Masahiro,
On 21 April 2014 03:39, Masahiro Yamada yamada.m@jp.panasonic.com wrote:
Prior to commit 33a02da0, all boards must have board/${BOARD}/ or board/${VENDOR}/${BOARD}/ directory. Now this rule is obsolete.
It looks weird that sandbox defines "vendor" and "board" just for meeting the old U-Boot directory structure.
Signed-off-by: Masahiro Yamada yamada.m@jp.panasonic.com Cc: Simon Glass sjg@chromium.org
Simon,
I moved board/sandbox/sandbox/sandbox.c to arch/sandbox/lib/sandbox.c
But if there is a more suitable place or file-name, please move.
I like the README move, but I worry about not having a sandbox board, from the point of view of discoverability. How will people find it?
I am not sure if this is necessary.
I just personaly thought the board directory seems odd for Sandbox because it is not a real board.
If you don't like this patch, feel free to reject it.
I think it is better to have board/sandbox. Is it possible to have a null vendor, so we don't need board/sandbox/sandbox?
Regards, Simon
Best Regards Masahiro Yamada
Hi Simon,
On Wed, 23 Apr 2014 09:04:20 -0600 Simon Glass sjg@chromium.org wrote:
Hi Masahiro,
On 21 April 2014 19:00, Masahiro Yamada yamada.m@jp.panasonic.com wrote:
Hi Simon,
On Mon, 21 Apr 2014 15:02:20 -0600 Simon Glass sjg@chromium.org wrote:
Hi Masahiro,
On 21 April 2014 03:39, Masahiro Yamada yamada.m@jp.panasonic.com wrote:
Prior to commit 33a02da0, all boards must have board/${BOARD}/ or board/${VENDOR}/${BOARD}/ directory. Now this rule is obsolete.
It looks weird that sandbox defines "vendor" and "board" just for meeting the old U-Boot directory structure.
Signed-off-by: Masahiro Yamada yamada.m@jp.panasonic.com Cc: Simon Glass sjg@chromium.org
Simon,
I moved board/sandbox/sandbox/sandbox.c to arch/sandbox/lib/sandbox.c
But if there is a more suitable place or file-name, please move.
I like the README move, but I worry about not having a sandbox board, from the point of view of discoverability. How will people find it?
I am not sure if this is necessary.
I just personaly thought the board directory seems odd for Sandbox because it is not a real board.
If you don't like this patch, feel free to reject it.
I think it is better to have board/sandbox. Is it possible to have a null vendor, so we don't need board/sandbox/sandbox?
Of cource. There are many boards without vendors.
In that case, you can set the 5th column to '-' in boards.cfg.
Active sandbox sandbox - sandbox sandbox sandbox
to
Active sandbox sandbox - - sandbox sandbox
With this change, you can decrease one level hierarchy.
board/sandbox/sandbox/sandbox.c -> board/sandbox/sandbox.c
Best Regards Masahiro Yamada
Hi Masahiro,
On 23 April 2014 20:14, Masahiro Yamada yamada.m@jp.panasonic.com wrote:
Hi Simon,
On Wed, 23 Apr 2014 09:04:20 -0600 Simon Glass sjg@chromium.org wrote:
Hi Masahiro,
On 21 April 2014 19:00, Masahiro Yamada yamada.m@jp.panasonic.com wrote:
Hi Simon,
On Mon, 21 Apr 2014 15:02:20 -0600 Simon Glass sjg@chromium.org wrote:
Hi Masahiro,
On 21 April 2014 03:39, Masahiro Yamada yamada.m@jp.panasonic.com wrote:
Prior to commit 33a02da0, all boards must have board/${BOARD}/ or board/${VENDOR}/${BOARD}/ directory. Now this rule is obsolete.
It looks weird that sandbox defines "vendor" and "board" just for meeting the old U-Boot directory structure.
Signed-off-by: Masahiro Yamada yamada.m@jp.panasonic.com Cc: Simon Glass sjg@chromium.org
Simon,
I moved board/sandbox/sandbox/sandbox.c to arch/sandbox/lib/sandbox.c
But if there is a more suitable place or file-name, please move.
I like the README move, but I worry about not having a sandbox board, from the point of view of discoverability. How will people find it?
I am not sure if this is necessary.
I just personaly thought the board directory seems odd for Sandbox because it is not a real board.
If you don't like this patch, feel free to reject it.
I think it is better to have board/sandbox. Is it possible to have a null vendor, so we don't need board/sandbox/sandbox?
Of cource. There are many boards without vendors.
In that case, you can set the 5th column to '-' in boards.cfg.
Active sandbox sandbox - sandbox sandbox sandbox
to
Active sandbox sandbox - - sandbox sandbox
With this change, you can decrease one level hierarchy.
board/sandbox/sandbox/sandbox.c -> board/sandbox/sandbox.c
That seems better to me. Will you update your patch?
Regards, Simon
Hi Simon,
With this change, you can decrease one level hierarchy.
board/sandbox/sandbox/sandbox.c -> board/sandbox/sandbox.c
That seems better to me. Will you update your patch?
Sure. Could you check this? http://patchwork.ozlabs.org/patch/344051/
Best Regards Masahiro Yamada
Hi Masahiro,
On 29 April 2014 22:53, Masahiro Yamada yamada.m@jp.panasonic.com wrote:
Hi Simon,
With this change, you can decrease one level hierarchy.
board/sandbox/sandbox/sandbox.c -> board/sandbox/sandbox.c
That seems better to me. Will you update your patch?
Sure. Could you check this? http://patchwork.ozlabs.org/patch/344051/
Sorry I applied the wrong patch - the other one is not showing up in patchwork for me. I'll see if I can figure it out.
Regards, Simon
Hi Simon,
On Tue, 13 May 2014 09:18:22 -0600 Simon Glass sjg@chromium.org wrote:
Hi Masahiro,
On 29 April 2014 22:53, Masahiro Yamada yamada.m@jp.panasonic.com wrote:
Hi Simon,
With this change, you can decrease one level hierarchy.
board/sandbox/sandbox/sandbox.c -> board/sandbox/sandbox.c
That seems better to me. Will you update your patch?
Sure. Could you check this? http://patchwork.ozlabs.org/patch/344051/
Sorry I applied the wrong patch - the other one is not showing up in patchwork for me. I'll see if I can figure it out.
After u-boot-x86/tom was merged, I cleared those patches out.
Please feel free to revert this patch and apply the other one.
Best Regards Masahiro Yamada
participants (2)
-
Masahiro Yamada -
Simon Glass