[U-Boot-Users] [PATCH] PHYSADDR is for physical address, KSEG1ADDR is for uncached
IMO, KSEG1 should work for AU1X00 too, but I can't test it
Signed-off-by: Vlad Lungu vlad@comsys.ro Signed-off-by: Shinya Kuribayashi shinya.kuribayashi@necel.com
--- include/asm-mips/addrspace.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/asm-mips/addrspace.h b/include/asm-mips/addrspace.h index b8214b1..0e6abd7 100644 --- a/include/asm-mips/addrspace.h +++ b/include/asm-mips/addrspace.h @@ -49,7 +49,7 @@ cannot access physical memory directly from core */ #define UNCACHED_SDRAM(a) (((unsigned long)(a)) | 0x20000000) #else /* !CONFIG_AU1X00 */ -#define UNCACHED_SDRAM(a) PHYSADDR(a) +#define UNCACHED_SDRAM(a) KSEG1ADDR(a) #endif /* CONFIG_AU1X00 */ #endif /* __ASSEMBLY__ */ /* -- 1.5.2.2
Hello,
I'm going to pick up this patch into -mips repos, but several problems are there. Please see below.
Vlad Lungu wrote:
IMO, KSEG1 should work for AU1X00 too, but I can't test it
Plase put an appropriate mail subject and patch description. "PHYSADDR is for physical address, KSEG1ADDR is for uncached" seems not be descriptive (at least for me).
If not native english speaker (of course I'm not), it helps a lot to see git log of others.
Signed-off-by: Vlad Lungu vlad@comsys.ro Signed-off-by: Shinya Kuribayashi shinya.kuribayashi@necel.com
include/asm-mips/addrspace.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/asm-mips/addrspace.h b/include/asm-mips/addrspace.h index b8214b1..0e6abd7 100644 --- a/include/asm-mips/addrspace.h +++ b/include/asm-mips/addrspace.h @@ -49,7 +49,7 @@ cannot access physical memory directly from core */ #define UNCACHED_SDRAM(a) (((unsigned long)(a)) | 0x20000000) #else /* !CONFIG_AU1X00 */
Indentation corrupted. Check your mailer settings.
-#define UNCACHED_SDRAM(a) PHYSADDR(a) +#define UNCACHED_SDRAM(a) KSEG1ADDR(a) #endif /* CONFIG_AU1X00 */ #endif /* __ASSEMBLY__ */
ditto.
/*
As I'm excersizing repo management, please don't expect my quick response ;-)
thanks,
Shinya
Shinya Kuribayashi wrote:
Hello,
I'm going to pick up this patch into -mips repos, but several problems are there. Please see below.
Applied. I changed patch subject and TAB indent.
thanks,
Shinya
Vlad Lungu wrote:
IMO, KSEG1 should work for AU1X00 too, but I can't test it
Plase put an appropriate mail subject and patch description. "PHYSADDR is for physical address, KSEG1ADDR is for uncached" seems not be descriptive (at least for me).
If not native english speaker (of course I'm not), it helps a lot to see git log of others.
Signed-off-by: Vlad Lungu vlad@comsys.ro Signed-off-by: Shinya Kuribayashi shinya.kuribayashi@necel.com
include/asm-mips/addrspace.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/asm-mips/addrspace.h b/include/asm-mips/addrspace.h index b8214b1..0e6abd7 100644 --- a/include/asm-mips/addrspace.h +++ b/include/asm-mips/addrspace.h @@ -49,7 +49,7 @@ cannot access physical memory directly from core */ #define UNCACHED_SDRAM(a) (((unsigned long)(a)) | 0x20000000) #else /* !CONFIG_AU1X00 */
Indentation corrupted. Check your mailer settings.
-#define UNCACHED_SDRAM(a) PHYSADDR(a) +#define UNCACHED_SDRAM(a) KSEG1ADDR(a) #endif /* CONFIG_AU1X00 */ #endif /* __ASSEMBLY__ */
ditto.
/*
As I'm excersizing repo management, please don't expect my quick response ;-)
thanks,
Shinya
participants (2)
-
Shinya Kuribayashi -
Vlad Lungu