Hi,

On 27.11.2015 06:27, Hannes Schmelzer wrote:

hello,

The ps7_init_gpl.c is some output from the xilinix vivado tool as hardware handoff. We compile this into our SPL.

My question is how to deal with "scripts/checkpatch.pl" on this file. The scripts throughs a lot of errors.

# scripts/checkpatch.pl -f board/xilinx/zynq/ZC702_hw_platform/ps7_init_gpl.c otal: 13009 errors, 13130 warnings, 14 checks, 13307 lines checked

NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or scripts/cleanfile

NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE

board/xilinx/zynq/ZC702_hw_platform/ps7_init_gpl.c has style problems, please review.

I have recommended this sequence

[u-boot]$ uncrustify --no-backup board/xilinx/zynq/ZC706_hw_platform/ps7_init_gpl.c Parsing: board/xilinx/zynq/ZC706_hw_platform/ps7_init_gpl.c as language C [u-boot]$ ./scripts/Lindent board/xilinx/zynq/ZC706_hw_platform/ps7_init_gpl.c [u-boot]$ ./scripts/checkpatch.pl -f board/xilinx/zynq/ZC706_hw_platform/ps7_init_gpl.c --max-line-length=200

And fix the rest by hand. That's what Nathan has done for adding zybo files.

Coding style should be hopefully fixed in 2016.1 but we will see as always.

Thanks, Michal