[U-Boot] [PATCH] spl: Add missing line ending to SPL print
One print requires line ending to be aligned with SW running after it. Prints look weird without it.
For example: U-Boot SPL 2017.01-01801-g1fb1292c7b9d (Jan 16 2017 - 12:50:53) EL Level: EL3 Trying to boot from SPINOTICE: ATF running on XCZU15EG/silicon v2/RTL5.1 at 0xfffe5000, with PMU firmware NOTICE: BL31: Secure code at 0x0
Signed-off-by: Michal Simek michal.simek@xilinx.com ---
common/spl/spl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/spl/spl.c b/common/spl/spl.c index a76ea3a60342..efe8b7710034 100644 --- a/common/spl/spl.c +++ b/common/spl/spl.c @@ -316,7 +316,7 @@ static int boot_from_devices(struct spl_image_info *spl_image, loader = spl_ll_find_loader(spl_boot_list[i]); #if defined(CONFIG_SPL_SERIAL_SUPPORT) && defined(CONFIG_SPL_LIBCOMMON_SUPPORT) if (loader) - printf("Trying to boot from %s", loader->name); + printf("Trying to boot from %s\n", loader->name); else puts("SPL: Unsupported Boot Device!\n"); #endif
On Monday 16 January 2017 05:36 PM, Michal Simek wrote:
One print requires line ending to be aligned with SW running after it. Prints look weird without it.
For example: U-Boot SPL 2017.01-01801-g1fb1292c7b9d (Jan 16 2017 - 12:50:53) EL Level: EL3 Trying to boot from SPINOTICE: ATF running on XCZU15EG/silicon v2/RTL5.1 at 0xfffe5000, with PMU firmware NOTICE: BL31: Secure code at 0x0
Signed-off-by: Michal Simek michal.simek@xilinx.com
A similar patches posted sometime back http://patchwork.ozlabs.org/patch/714521/
Thanks and regards, Lokesh
common/spl/spl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/spl/spl.c b/common/spl/spl.c index a76ea3a60342..efe8b7710034 100644 --- a/common/spl/spl.c +++ b/common/spl/spl.c @@ -316,7 +316,7 @@ static int boot_from_devices(struct spl_image_info *spl_image, loader = spl_ll_find_loader(spl_boot_list[i]); #if defined(CONFIG_SPL_SERIAL_SUPPORT) && defined(CONFIG_SPL_LIBCOMMON_SUPPORT) if (loader)
printf("Trying to boot from %s", loader->name);
printf("Trying to boot from %s\n", loader->name);#endif
On 16.1.2017 16:37, Lokesh Vutla wrote:
On Monday 16 January 2017 05:36 PM, Michal Simek wrote:
One print requires line ending to be aligned with SW running after it. Prints look weird without it.
For example: U-Boot SPL 2017.01-01801-g1fb1292c7b9d (Jan 16 2017 - 12:50:53) EL Level: EL3 Trying to boot from SPINOTICE: ATF running on XCZU15EG/silicon v2/RTL5.1 at 0xfffe5000, with PMU firmware NOTICE: BL31: Secure code at 0x0
Signed-off-by: Michal Simek michal.simek@xilinx.com
A similar patches posted sometime back http://patchwork.ozlabs.org/patch/714521/
wonderful. Please ignore this patch and take origin one.
Thanks, Michal
On 16 January 2017 at 08:49, Michal Simek michal.simek@xilinx.com wrote:
On 16.1.2017 16:37, Lokesh Vutla wrote:
On Monday 16 January 2017 05:36 PM, Michal Simek wrote:
One print requires line ending to be aligned with SW running after it. Prints look weird without it.
For example: U-Boot SPL 2017.01-01801-g1fb1292c7b9d (Jan 16 2017 - 12:50:53) EL Level: EL3 Trying to boot from SPINOTICE: ATF running on XCZU15EG/silicon v2/RTL5.1 at 0xfffe5000, with PMU firmware NOTICE: BL31: Secure code at 0x0
Signed-off-by: Michal Simek michal.simek@xilinx.com
A similar patches posted sometime back http://patchwork.ozlabs.org/patch/714521/
wonderful. Please ignore this patch and take origin one.
Reviewed-by: Simon Glass sjg@chromium.org
I prefer this patch :-)
On Mon, Jan 16, 2017 at 01:06:48PM +0100, Michal Simek wrote:
One print requires line ending to be aligned with SW running after it. Prints look weird without it.
For example: U-Boot SPL 2017.01-01801-g1fb1292c7b9d (Jan 16 2017 - 12:50:53) EL Level: EL3 Trying to boot from SPINOTICE: ATF running on XCZU15EG/silicon v2/RTL5.1 at 0xfffe5000, with PMU firmware NOTICE: BL31: Secure code at 0x0
Signed-off-by: Michal Simek michal.simek@xilinx.com
Applied to u-boot/master, thanks!
participants (4)
-
Lokesh Vutla -
Michal Simek -
Simon Glass -
Tom Rini