Re: [PATCH v2 03/11] riscv: Add headers for asm/global_data.h

Hi Sean,
From: Sean Anderson [mailto:seanga2@gmail.com] Sent: Thursday, January 16, 2020 6:51 AM To: U-Boot Mailing List Cc: Rick Jian-Zhi Chen(陳建志) Subject: [PATCH v2 03/11] riscv: Add headers for asm/global_data.h
This header depended on bd_t and ulong, but did not include the appropriate headers.
Signed-off-by: Sean Anderson seanga2@gmail.com
arch/riscv/include/asm/global_data.h | 2 ++ 1 file changed, 2 insertions(+)
I wonder why the compiling is OK without those appropriate headers.
Thanks, Rick
diff --git a/arch/riscv/include/asm/global_data.h b/arch/riscv/include/asm/global_data.h index b74bd7e738..4f0c12b402 100644 --- a/arch/riscv/include/asm/global_data.h +++ b/arch/riscv/include/asm/global_data.h @@ -11,6 +11,8 @@ #define __ASM_GBL_DATA_H
#include <asm/smp.h> +#include <asm/u-boot.h> +#include <linux/compiler.h>
/* Architecture-specific global data */ struct arch_global_data {
2.24.1

I wonder why the compiling is OK without those appropriate headers.
It's likely that all the uses looked like
#include <this_header_includes_ulong.h> #include <asm/global_data.h>
So it wasn't noticed until it was included first in some file.
participants (2)
-
Rick Chen
-
Sean Anderson