[U-Boot-Users] PATCH: drivers/mtd/jedec_flash.c (typo)
I noticed that the device id for AMD flash part AM29DL800BB is wrong.
Attached patch corrects it.
Cheers,
Jerry Hicks.
In message 48644421.9000108@gmail.com you wrote:
I noticed that the device id for AMD flash part AM29DL800BB is wrong.
Attached patch corrects it.
...
-#define AM29DL800BB 0x22C8 +#define AM29DL800BB 0x22CB
Hmmmm... I have but an old data sheet (Nov 2000) for this chip, which indeed says 22CB. But then, even the current Linux kernel tree has 22C8.
Can anybody with access to real hardware / current documentation comment?
Best regards,
Wolfgang Denk
On Sun, Jul 6, 2008 at 4:57 PM, Wolfgang Denk wd@denx.de wrote:
In message 48644421.9000108@gmail.com you wrote:
I noticed that the device id for AMD flash part AM29DL800BB is wrong.
Attached patch corrects it.
...
-#define AM29DL800BB 0x22C8 +#define AM29DL800BB 0x22CB
Hmmmm... I have but an old data sheet (Nov 2000) for this chip, which indeed says 22CB. But then, even the current Linux kernel tree has 22C8.
Can anybody with access to real hardware / current documentation comment?
Best regards,
Wolfgang Denk
(I had a connectivity "burp" earlier when sending a reply. Please excuse if double-posted)
We were using a custom driver written by Andy Lowe of Montavista. He had a #define local to our flash.c implementation when I noticed the discrepancy between his local definition and the one in the u-boot header.
On our hardware it works with 0x22CB but not with 0x22C8.
The current documentation from Spansion also shows it as 0x22CB.
http://www.spansion.com/datasheets/21519c4.pdf
Cheers,
Jerry.
On Monday 07 July 2008, Jerry Hicks wrote:
We were using a custom driver written by Andy Lowe of Montavista. He had a #define local to our flash.c implementation when I noticed the discrepancy between his local definition and the one in the u-boot header.
On our hardware it works with 0x22CB but not with 0x22C8.
The current documentation from Spansion also shows it as 0x22CB.
I created an "official" patch for this and applied it to the cfi_flash repository. I'll send the pull request soon.
Thanks.
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================
participants (3)
-
Jerry Hicks -
Stefan Roese -
Wolfgang Denk