On 11/07/2016 10:36 AM, york.sun@nxp.com wrote:

On 10/27/2016 02:47 AM, Calvin Johnson wrote:

...

Hi York,

...

-----Original Message----- From: york sun Sent: Wednesday, October 26, 2016 10:09 PM To: Calvin Johnson calvin.johnson@nxp.com; Prabhakar Kushwaha prabhakar.kushwaha@nxp.com; Pratiyush Srivastava pratiyush.srivastava@nxp.com; u-boot@lists.denx.de; Mingkai Hu mingkai.hu@nxp.com Cc: Hou Zhiqiang Zhiqiang.Hou@freescale.com Subject: Re: [PATCH] armv8/ls1043a: Add the OCRAM initialization

On 10/24/2016 09:30 PM, Calvin Johnson wrote:

...

...

...

> I wonder why we don't see ECC errors before this patch. We have > LS1043A boots on NAND, SD. >

OCRAM has a requirement of initializing before first time "read". If user reads OCRAM before **initializing**; ECC error will come. (u-boot is not handling this error for now).

I can only guess the reason of not seeing this error as OCRAM never read before any write. Even in case of Stack, data is first written and then read.

Is there a case you want to read from OCRAM before writing anything to it? Why don't we need to do so for SPL or

LSCH3?

...

This issue will be seen ONLY in secure boot. It was reproduced on LS1043A also.

How about LSCH3? We have LS2080A secure boot.

I don't know about LS2080A. Prabhakar or Ruchika(copied) may be able to comment on this.

Please follow up on this thread. We need to understand when and where OCRAM needs to be cleared.

Can Prabhakar or Ruchika verify this OCRAM init on LSCH3? If it is required and effective, we can take this patch.

York