[U-Boot-Users] [PATCH] Remove #undef DEBUG from MPC83xx board header files
Remove the "#undef DEBUG" line from all Freescale 83xx board header files. The inclusion of this line makes it impossible to enable debug code in other source files, because "#define DEBUG" typically needs to be defined before any header files are included.
Signed-off-by: Timur Tabi timur@freescale.com --- include/configs/MPC8323ERDB.h | 2 -- include/configs/MPC832XEMDS.h | 2 -- include/configs/MPC8349EMDS.h | 2 -- include/configs/MPC8360EMDS.h | 2 -- include/configs/MPC837XEMDS.h | 2 -- 5 files changed, 0 insertions(+), 10 deletions(-)
diff --git a/include/configs/MPC8323ERDB.h b/include/configs/MPC8323ERDB.h index 564de02..1dd1cfa 100644 --- a/include/configs/MPC8323ERDB.h +++ b/include/configs/MPC8323ERDB.h @@ -9,8 +9,6 @@ #ifndef __CONFIG_H #define __CONFIG_H
-#undef DEBUG - /* * High Level Configuration Options */ diff --git a/include/configs/MPC832XEMDS.h b/include/configs/MPC832XEMDS.h index a48b311..88a3ed3 100644 --- a/include/configs/MPC832XEMDS.h +++ b/include/configs/MPC832XEMDS.h @@ -20,8 +20,6 @@ #ifndef __CONFIG_H #define __CONFIG_H
-#undef DEBUG - /* * High Level Configuration Options */ diff --git a/include/configs/MPC8349EMDS.h b/include/configs/MPC8349EMDS.h index 03409bb..b8c3153 100644 --- a/include/configs/MPC8349EMDS.h +++ b/include/configs/MPC8349EMDS.h @@ -29,8 +29,6 @@ #ifndef __CONFIG_H #define __CONFIG_H
-#undef DEBUG - /* * High Level Configuration Options */ diff --git a/include/configs/MPC8360EMDS.h b/include/configs/MPC8360EMDS.h index fedb8a9..edd6673 100644 --- a/include/configs/MPC8360EMDS.h +++ b/include/configs/MPC8360EMDS.h @@ -22,8 +22,6 @@ #ifndef __CONFIG_H #define __CONFIG_H
-#undef DEBUG - /* * High Level Configuration Options */ diff --git a/include/configs/MPC837XEMDS.h b/include/configs/MPC837XEMDS.h index 0958e6b..e3595c7 100644 --- a/include/configs/MPC837XEMDS.h +++ b/include/configs/MPC837XEMDS.h @@ -21,8 +21,6 @@ #ifndef __CONFIG_H #define __CONFIG_H
-#undef DEBUG - /* * High Level Configuration Options */
On Wed, 9 Jan 2008 10:16:32 -0600 Timur Tabi timur@freescale.com wrote:
Remove the "#undef DEBUG" line from all Freescale 83xx board header files. The inclusion of this line makes it impossible to enable debug code in other source files, because "#define DEBUG" typically needs to be defined before any header files are included.
Signed-off-by: Timur Tabi timur@freescale.com
include/configs/MPC8323ERDB.h | 2 -- include/configs/MPC832XEMDS.h | 2 -- include/configs/MPC8349EMDS.h | 2 -- include/configs/MPC8360EMDS.h | 2 -- include/configs/MPC837XEMDS.h | 2 -- 5 files changed, 0 insertions(+), 10 deletions(-)
hmm..what about the rest of the boards that do this?:
include/configs/AP1000.h:#undef DEBUG include/configs/BAB7xx.h:#undef DEBUG include/configs/EB+MCF-EV123.h:#undef DEBUG include/configs/ELPPC.h:#undef DEBUG include/configs/IPHASE4539.h:#undef DEBUG /* General debug */ include/configs/M5235EVB.h:#undef DEBUG include/configs/M5271EVB.h:#undef DEBUG include/configs/M5329EVB.h:#undef DEBUG include/configs/M54455EVB.h:#undef DEBUG include/configs/MPC8360ERDK.h:#undef DEBUG include/configs/MPC8540EVAL.h:#undef DEBUG include/configs/MVBLUE.h:#undef DEBUG include/configs/QS823.h:#undef DEBUG /* debug output code */ include/configs/QS850.h:#undef DEBUG /* debug output code */ include/configs/QS860T.h:#undef DEBUG /* debug output code */ include/configs/Rattler.h:#undef DEBUG include/configs/ads5121.h:#undef DEBUG include/configs/assabet.h:#undef DEBUG include/configs/ep8248.h:#undef DEBUG include/configs/ep82xxm.h:#undef DEBUG include/configs/gw8260.h:#undef DEBUG /* General debug */ include/configs/mpc7448hpc2.h:#undef DEBUG include/configs/ms7722se.h:#undef DEBUG include/configs/ms7750se.h:#undef DEBUG include/configs/sacsng.h:#undef DEBUG /* General debug */ include/configs/sbc8260.h:#undef DEBUG /* General debug */ include/configs/sbc8349.h:#undef DEBUG
Kim
I suggest keep the debug option - #undef DEBUG.
Sometimes, if we need debug, it is easy to open the debug mode with the switch.
Thanks Dave
-----Original Message----- From: u-boot-users-bounces@lists.sourceforge.net [mailto:u-boot-users-bounces@lists.sourceforge.net] On Behalf Of Phillips Kim Sent: 2008?1?11? 11:30 AM To: Tabi Timur Cc: u-boot-users@lists.sourceforge.net Subject: Re: [U-Boot-Users] [PATCH] Remove #undef DEBUG from MPC83xx boardheader files
On Wed, 9 Jan 2008 10:16:32 -0600 Timur Tabi timur@freescale.com wrote:
Remove the "#undef DEBUG" line from all Freescale 83xx
board header files.
The inclusion of this line makes it impossible to enable
debug code in
other source files, because "#define DEBUG" typically needs
to be defined
before any header files are included.
Signed-off-by: Timur Tabi timur@freescale.com
include/configs/MPC8323ERDB.h | 2 -- include/configs/MPC832XEMDS.h | 2 -- include/configs/MPC8349EMDS.h | 2 -- include/configs/MPC8360EMDS.h | 2 -- include/configs/MPC837XEMDS.h | 2 -- 5 files changed, 0 insertions(+), 10 deletions(-)
hmm..what about the rest of the boards that do this?:
include/configs/AP1000.h:#undef DEBUG include/configs/BAB7xx.h:#undef DEBUG include/configs/EB+MCF-EV123.h:#undef DEBUG include/configs/ELPPC.h:#undef DEBUG include/configs/IPHASE4539.h:#undef DEBUG /* General debug */ include/configs/M5235EVB.h:#undef DEBUG include/configs/M5271EVB.h:#undef DEBUG include/configs/M5329EVB.h:#undef DEBUG include/configs/M54455EVB.h:#undef DEBUG include/configs/MPC8360ERDK.h:#undef DEBUG include/configs/MPC8540EVAL.h:#undef DEBUG include/configs/MVBLUE.h:#undef DEBUG include/configs/QS823.h:#undef DEBUG /* debug output code */ include/configs/QS850.h:#undef DEBUG /* debug output code */ include/configs/QS860T.h:#undef DEBUG /* debug output code */ include/configs/Rattler.h:#undef DEBUG include/configs/ads5121.h:#undef DEBUG include/configs/assabet.h:#undef DEBUG include/configs/ep8248.h:#undef DEBUG include/configs/ep82xxm.h:#undef DEBUG include/configs/gw8260.h:#undef DEBUG /* General debug */ include/configs/mpc7448hpc2.h:#undef DEBUG include/configs/ms7722se.h:#undef DEBUG include/configs/ms7750se.h:#undef DEBUG include/configs/sacsng.h:#undef DEBUG /* General debug */ include/configs/sbc8260.h:#undef DEBUG /* General debug */ include/configs/sbc8349.h:#undef DEBUG
Kim
Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.n et/marketplace _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Liu Dave wrote:
I suggest keep the debug option - #undef DEBUG.
Sometimes, if we need debug, it is easy to open the debug mode with the switch.
I don't see how. The "#undef DEBUG" will override any #define DEBUG or -DDEBUG that you specify. The "#undef DEBUG" makes it impossible to use the debug() call or anything else like it.
I don't see how. The "#undef DEBUG" will override any #define DEBUG or -DDEBUG that you specify. The "#undef DEBUG" makes it impossible to use the debug() call or anything else like it.
Yes, the DEBUG is global, sometime it is my need.
In message 58A20A281BAF1047B4EAE68DE5C0BDC2C0E189@zch01exm21.fsl.freescale.net you wrote:
I suggest keep the debug option - #undef DEBUG.
DEBUG is not defined by default, so this statement is redundant at best, harmful in some cases (when you try to enable debug globally).
Sometimes, if we need debug, it is easy to open the debug mode with the switch.
But you don't need the #undef DEBUG for that.
Best regards,
Wolfgang Denk
I suggest keep the debug option - #undef DEBUG.
DEBUG is not defined by default, so this statement is redundant at best, harmful in some cases (when you try to enable debug globally).
Sometimes, if we need debug, it is easy to open the debug mode with the switch.
But you don't need the #undef DEBUG for that.
Ok. Let us remove them.
Regards, Dave
participants (4)
-
Kim Phillips -
Liu Dave -
Timur Tabi -
Wolfgang Denk