[PATCH 1/1] fs: ext4: all file paths are absolute
U-Boot only knows absolute file paths. It is inconsistent to require that saving to an ext4 file system should use a leading '/' wile reading does not. Remove the superfluous check.
Reported-by: Patrice Chotard patrice.chotard@foss.st.com Signed-off-by: Heinrich Schuchardt heinrich.schuchardt@canonical.com --- fs/ext4/ext4_common.c | 5 ----- 1 file changed, 5 deletions(-)
diff --git a/fs/ext4/ext4_common.c b/fs/ext4/ext4_common.c index ea9b92298ba..9eac6beef3b 100644 --- a/fs/ext4/ext4_common.c +++ b/fs/ext4/ext4_common.c @@ -765,11 +765,6 @@ int ext4fs_get_parent_inode_num(const char *dirname, char *dname, int flags) struct ext2_inode *first_inode = NULL; struct ext2_inode temp_inode;
- if (*dirname != '/') { - printf("Please supply Absolute path\n"); - return -1; - } - /* TODO: input validation make equivalent to linux */ depth_dirname = zalloc(strlen(dirname) + 1); if (!depth_dirname)
On Wed, 20 Mar 2024 at 15:25, Heinrich Schuchardt heinrich.schuchardt@canonical.com wrote:
U-Boot only knows absolute file paths. It is inconsistent to require that saving to an ext4 file system should use a leading '/' wile reading does not. Remove the superfluous check.
Reported-by: Patrice Chotard patrice.chotard@foss.st.com Signed-off-by: Heinrich Schuchardt heinrich.schuchardt@canonical.com
fs/ext4/ext4_common.c | 5 ----- 1 file changed, 5 deletions(-)
diff --git a/fs/ext4/ext4_common.c b/fs/ext4/ext4_common.c index ea9b92298ba..9eac6beef3b 100644 --- a/fs/ext4/ext4_common.c +++ b/fs/ext4/ext4_common.c @@ -765,11 +765,6 @@ int ext4fs_get_parent_inode_num(const char *dirname, char *dname, int flags) struct ext2_inode *first_inode = NULL; struct ext2_inode temp_inode;
if (*dirname != '/') {printf("Please supply Absolute path\n");return -1;}/* TODO: input validation make equivalent to linux */ depth_dirname = zalloc(strlen(dirname) + 1); if (!depth_dirname)-- 2.43.0
Reviewed-by: Ilias Apalodimas ilias.apalodimas@linaro.org
On 3/20/24 14:25, Heinrich Schuchardt wrote:
U-Boot only knows absolute file paths. It is inconsistent to require that saving to an ext4 file system should use a leading '/' wile reading does not. Remove the superfluous check.
Reported-by: Patrice Chotard patrice.chotard@foss.st.com Signed-off-by: Heinrich Schuchardt heinrich.schuchardt@canonical.com
fs/ext4/ext4_common.c | 5 ----- 1 file changed, 5 deletions(-)
diff --git a/fs/ext4/ext4_common.c b/fs/ext4/ext4_common.c index ea9b92298ba..9eac6beef3b 100644 --- a/fs/ext4/ext4_common.c +++ b/fs/ext4/ext4_common.c @@ -765,11 +765,6 @@ int ext4fs_get_parent_inode_num(const char *dirname, char *dname, int flags) struct ext2_inode *first_inode = NULL; struct ext2_inode temp_inode;
- if (*dirname != '/') {
printf("Please supply Absolute path\n");return -1;- }
- /* TODO: input validation make equivalent to linux */ depth_dirname = zalloc(strlen(dirname) + 1); if (!depth_dirname)
Tested-by: Patrice Chotard patrice.chotard@foss.st.com
Thanks Patrice
On Wed, Mar 20, 2024 at 2:25 PM Heinrich Schuchardt heinrich.schuchardt@canonical.com wrote:
U-Boot only knows absolute file paths. It is inconsistent to require that saving to an ext4 file system should use a leading '/' wile reading does not. Remove the superfluous check.
Just a typo, "wile reading"
Michael
Reported-by: Patrice Chotard patrice.chotard@foss.st.com Signed-off-by: Heinrich Schuchardt heinrich.schuchardt@canonical.com
fs/ext4/ext4_common.c | 5 ----- 1 file changed, 5 deletions(-)
diff --git a/fs/ext4/ext4_common.c b/fs/ext4/ext4_common.c index ea9b92298ba..9eac6beef3b 100644 --- a/fs/ext4/ext4_common.c +++ b/fs/ext4/ext4_common.c @@ -765,11 +765,6 @@ int ext4fs_get_parent_inode_num(const char *dirname, char *dname, int flags) struct ext2_inode *first_inode = NULL; struct ext2_inode temp_inode;
if (*dirname != '/') {printf("Please supply Absolute path\n");return -1;}/* TODO: input validation make equivalent to linux */ depth_dirname = zalloc(strlen(dirname) + 1); if (!depth_dirname)-- 2.43.0
participants (4)
-
Heinrich Schuchardt -
Ilias Apalodimas -
Michael Nazzareno Trimarchi -
Patrice CHOTARD