[U-Boot] [PATCH 1/2] bootstage: Fix typos in the comment
There are two typos in the comment block in bootstage.h, fix them.
Signed-off-by: Bin Meng bmeng.cn@gmail.com ---
include/bootstage.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/bootstage.h b/include/bootstage.h index 6b7588d..0276cb3 100644 --- a/include/bootstage.h +++ b/include/bootstage.h @@ -86,9 +86,9 @@ enum bootstage_id { BOOTSTAGE_ID_POST_FAIL_R, /* Post failure reported after reloc */
/* - * This set is reported ony by x86, and the meaning is different. In + * This set is reported only by x86, and the meaning is different. In * this case we are reporting completion of a particular stage. - * This should probably change in he x86 code (which doesn't report + * This should probably change in the x86 code (which doesn't report * errors in any case), but discussion this can perhaps wait until we * have a generic board implementation. */
Space is used before 'default' in PCIE_ECAM_BASE in arch/x86/Kconfig so it looks misaligned. Replace the space with tab to indent.
Signed-off-by: Bin Meng bmeng.cn@gmail.com ---
arch/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 2370c32..fef11f3 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -428,7 +428,7 @@ source "board/intel/galileo/Kconfig"
config PCIE_ECAM_BASE hex - default 0xe0000000 + default 0xe0000000 help This is the memory-mapped address of PCI configuration space, which is only available through the Enhanced Configuration Access
Hi Simon,
On Mon, Feb 2, 2015 at 9:25 PM, Bin Meng bmeng.cn@gmail.com wrote:
Space is used before 'default' in PCIE_ECAM_BASE in arch/x86/Kconfig so it looks misaligned. Replace the space with tab to indent.
Signed-off-by: Bin Meng bmeng.cn@gmail.com
arch/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 2370c32..fef11f3 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -428,7 +428,7 @@ source "board/intel/galileo/Kconfig"
Ah, looks this patch depends on http://patchwork.ozlabs.org/patch/434403/. Let me know if you need me respin, or just have this patch applied after that one.
config PCIE_ECAM_BASE hex
- default 0xe0000000
default 0xe0000000 help This is the memory-mapped address of PCI configuration space, which is only available through the Enhanced Configuration Access--
Regards, Bin
On 2 February 2015 at 06:29, Bin Meng bmeng.cn@gmail.com wrote:
Hi Simon,
On Mon, Feb 2, 2015 at 9:25 PM, Bin Meng bmeng.cn@gmail.com wrote:
Space is used before 'default' in PCIE_ECAM_BASE in arch/x86/Kconfig so it looks misaligned. Replace the space with tab to indent.
Signed-off-by: Bin Meng bmeng.cn@gmail.com
arch/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 2370c32..fef11f3 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -428,7 +428,7 @@ source "board/intel/galileo/Kconfig"
Ah, looks this patch depends on http://patchwork.ozlabs.org/patch/434403/. Let me know if you need me respin, or just have this patch applied after that one.
It's fine.
Acked-by: Simon Glass sjg@chromium.org
On 2 February 2015 at 16:58, Simon Glass sjg@chromium.org wrote:
On 2 February 2015 at 06:29, Bin Meng bmeng.cn@gmail.com wrote:
Hi Simon,
On Mon, Feb 2, 2015 at 9:25 PM, Bin Meng bmeng.cn@gmail.com wrote:
Space is used before 'default' in PCIE_ECAM_BASE in arch/x86/Kconfig so it looks misaligned. Replace the space with tab to indent.
Signed-off-by: Bin Meng bmeng.cn@gmail.com
arch/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 2370c32..fef11f3 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -428,7 +428,7 @@ source "board/intel/galileo/Kconfig"
Ah, looks this patch depends on http://patchwork.ozlabs.org/patch/434403/. Let me know if you need me respin, or just have this patch applied after that one.
It's fine.
Acked-by: Simon Glass sjg@chromium.org
Applied to u-boot-x86, thanks!
On 2 February 2015 at 06:25, Bin Meng bmeng.cn@gmail.com wrote:
There are two typos in the comment block in bootstage.h, fix them.
Signed-off-by: Bin Meng bmeng.cn@gmail.com
include/bootstage.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Simon Glass sjg@chromium.org
On 2 February 2015 at 09:19, Simon Glass sjg@chromium.org wrote:
On 2 February 2015 at 06:25, Bin Meng bmeng.cn@gmail.com wrote:
There are two typos in the comment block in bootstage.h, fix them.
Signed-off-by: Bin Meng bmeng.cn@gmail.com
include/bootstage.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Simon Glass sjg@chromium.org
Applied to u-boot-x86, thanks!
participants (2)
-
Bin Meng -
Simon Glass