[U-Boot] Need Info regarding global label memsetup & file memsetup.s
Hi,
I was going through ARM integrator[cp/ap] (u-boot-1.3.3) board files & found occurrences of memsetup global variables & file memsetup.s
But according to a changelog entry, memsetup global label is changed/merged to lowlevel_init & memsetup.s is changed/merged to lowlevel_init.S.
Below are the memsetup entries inside integrator[cp/ap] directories. I was unable to find a call to memsetup global entry anywhere in whole of u-boot-1.3.3 directory
1. uboot-1.3.3\board\integrator[cp/ap]\memsetup.S Redundant file. This file should be removed. File content:
/* GPL ..snip.. ..snip.. Disclosure*/
/* * Memory setup * - the reset defaults are assumed sufficient */
.globl memsetup memsetup: mov pc,lr
2. Also memsetup.s entry in makefile (uboot-1.3.3\board\integrator[cp/ap]\Makefile)
Once 1 step is done, this entry becomes invalid. So it needs to be removed.
If i am correct, i can send a patch for the same.
Please correct me if i am wrong.
TIA
Regards Gururaja
-----Original Message----- From: Gururaja Hebbar K R [mailto:gururajakr@sanyo.co.in] Sent: 28 August 2008 06:41 To: u-boot@lists.denx.de Cc: wd@denx.de; Jean-Christophe PLAGNIOL-VILLARD; Peter Pearse Subject: Need Info regarding global label memsetup & file memsetup.s
Hi,
I was going through ARM integrator[cp/ap] (u-boot-1.3.3) board files & found occurrences of memsetup global variables & file memsetup.s Once 1 step is done, this entry becomes invalid. So it needs to be removed.
---snip---
If i am correct, i can send a patch for the same.
Please correct me if i am wrong.
Fine by me
Regards
Peter
Hi,
- memsetup.s is changed/merged to lowlevel_init.S memsetup.S has a global label memsetup that just returns back to caller - memsetup global label is changed/merged to lowlevel_init This label is not called from anywhere.
Signed-off-by: Gururaja Hebbar gururajakr@sanyo.co.in --- board/integratorap/Makefile | 2 +- board/integratorap/memsetup.S | 29 ----------------------------- board/integratorcp/Makefile | 2 +- board/integratorcp/memsetup.S | 29 ----------------------------- 4 files changed, 2 insertions(+), 60 deletions(-) delete mode 100755 board/integratorap/memsetup.S delete mode 100755 board/integratorcp/memsetup.S
diff --git a/board/integratorap/Makefile b/board/integratorap/Makefile index f78de3a..79f501a 100755 --- a/board/integratorap/Makefile +++ b/board/integratorap/Makefile @@ -30,7 +30,7 @@ include $(TOPDIR)/config.mk LIB = $(obj)lib$(BOARD).a
COBJS := integratorap.o flash.o -SOBJS := lowlevel_init.o memsetup.o +SOBJS := lowlevel_init.o
SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) OBJS := $(addprefix $(obj),$(COBJS)) diff --git a/board/integratorap/memsetup.S b/board/integratorap/memsetup.S deleted file mode 100755 index da43cb6..0000000 --- a/board/integratorap/memsetup.S +++ /dev/null @@ -1,29 +0,0 @@ -/* - * Memory setup for integratorAP - * - * See file CREDITS for list of people who contributed to this - * project. - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License as - * published by the Free Software Foundation; either version 2 of - * the License, or (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, - * MA 02111-1307 USA - */ -/* - * Memory setup - * - the reset defaults are assumed sufficient - */ - -.globl memsetup -memsetup: - mov pc,lr diff --git a/board/integratorcp/Makefile b/board/integratorcp/Makefile index 9201acc..92a1a07 100755 --- a/board/integratorcp/Makefile +++ b/board/integratorcp/Makefile @@ -26,7 +26,7 @@ include $(TOPDIR)/config.mk LIB = $(obj)lib$(BOARD).a
COBJS := integratorcp.o flash.o -SOBJS := lowlevel_init.o memsetup.o +SOBJS := lowlevel_init.o
SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) OBJS := $(addprefix $(obj),$(COBJS)) diff --git a/board/integratorcp/memsetup.S b/board/integratorcp/memsetup.S deleted file mode 100755 index da43cb6..0000000 --- a/board/integratorcp/memsetup.S +++ /dev/null @@ -1,29 +0,0 @@ -/* - * Memory setup for integratorAP - * - * See file CREDITS for list of people who contributed to this - * project. - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License as - * published by the Free Software Foundation; either version 2 of - * the License, or (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, - * MA 02111-1307 USA - */ -/* - * Memory setup - * - the reset defaults are assumed sufficient - */ - -.globl memsetup -memsetup: - mov pc,lr
participants (2)
-
Gururaja Hebbar K R -
Peter Pearse