[U-Boot] Portability of sh scripts

9 Nov
2018
9 Nov
'18
1:08 p.m.
Hey folks,
I noticed that tools/imx_cntr_image.sh contains non-portable code:
if [ $f == "u-boot-dtb.bin" ]; then
This is a "bash-ism", the operator "==" is not implemented by most test(1) or sh(1) impmlementations. Simply replacing it with "=" fixes this.
Should I send a trivial patch or do you just fix it?
Thanks,
Martin

9 Nov
9 Nov
1:11 p.m.
On Fri, Nov 09, 2018 at 01:08:42PM +0100, Martin Husemann wrote:
Hey folks,
I noticed that tools/imx_cntr_image.sh contains non-portable code:
if [ $f == "u-boot-dtb.bin" ]; then
This is a "bash-ism", the operator "==" is not implemented by most test(1) or sh(1) impmlementations. Simply replacing it with "=" fixes this.
Should I send a trivial patch or do you just fix it?
Please send a patch, thanks!
--
Tom
2375
Age (days ago)
2375
Last active (days ago)
1 comments
2 participants
participants (2)
-
Martin Husemann
-
Tom Rini