[U-Boot] [PATCH 1/3] mx23evk: Remove unneeded 'undef's
Rather than 'undef'ing some symbols, just remove them instead.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- include/configs/mx23evk.h | 2 -- 1 file changed, 2 deletions(-)
diff --git a/include/configs/mx23evk.h b/include/configs/mx23evk.h index c44a8b8..51aa9c4 100644 --- a/include/configs/mx23evk.h +++ b/include/configs/mx23evk.h @@ -49,8 +49,6 @@
/* U-Boot Commands */ #include <config_cmd_default.h> -#undef CONFIG_CMD_NET -#undef CONFIG_CMD_NFS
#define CONFIG_DISPLAY_CPUINFO #define CONFIG_DOS_PARTITION
The baudrate is already defined by CONFIG_BAUDRATE and there is no need to keep CONFIG_SYS_BAUDRATE_TABLE.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- include/configs/mx23evk.h | 1 - 1 file changed, 1 deletion(-)
diff --git a/include/configs/mx23evk.h b/include/configs/mx23evk.h index 51aa9c4..e43b93f 100644 --- a/include/configs/mx23evk.h +++ b/include/configs/mx23evk.h @@ -110,7 +110,6 @@ #define CONFIG_PL01x_PORTS { (void *)MXS_UARTDBG_BASE } #define CONFIG_CONS_INDEX 0 #define CONFIG_BAUDRATE 115200 /* Default baud rate */ -#define CONFIG_SYS_BAUDRATE_TABLE { 9600, 19200, 38400, 57600, 115200 }
/* DMA */ #define CONFIG_APBH_DMA
On Mon, Jan 28, 2013 at 9:41 AM, Fabio Estevam fabio.estevam@freescale.com wrote:
The baudrate is already defined by CONFIG_BAUDRATE and there is no need to keep CONFIG_SYS_BAUDRATE_TABLE.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Acked-by: Otavio Salvador otavio@ossystems.com.br
-- Otavio Salvador O.S. Systems E-mail: otavio@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
Dear Fabio Estevam,
The baudrate is already defined by CONFIG_BAUDRATE and there is no need to keep CONFIG_SYS_BAUDRATE_TABLE.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
include/configs/mx23evk.h | 1 - 1 file changed, 1 deletion(-)
diff --git a/include/configs/mx23evk.h b/include/configs/mx23evk.h index 51aa9c4..e43b93f 100644 --- a/include/configs/mx23evk.h +++ b/include/configs/mx23evk.h @@ -110,7 +110,6 @@ #define CONFIG_PL01x_PORTS { (void *)MXS_UARTDBG_BASE } #define CONFIG_CONS_INDEX 0 #define CONFIG_BAUDRATE 115200 /* Default baud rate */ -#define CONFIG_SYS_BAUDRATE_TABLE { 9600, 19200, 38400, 57600, 115200 }
This will not allow different baudrates now, will it?
Best regards, Marek Vasut
On Mon, Jan 28, 2013 at 10:46 AM, Marek Vasut marex@denx.de wrote:
This will not allow different baudrates now, will it?
You still may change the baudrate if you need to.
CONFIG_SYS_BAUDRATE_TABLE has been placed to a common place after the commit below:
commit 26750c8aee2383a026e0cf89e9310628d3a5a6a0 Author: Tom Rini trini@ti.com Date: Tue Jun 19 12:54:34 2012 +0000
CONFIG_SYS_BAUDRATE_TABLE: Add <config_fallbacks.h>, place there
We provide a default table of { 9600, 19200, 38400, 57600, 115200 } in <config_fallbacks.h> which mkconfig places after <configs/...h> in the generated config file. This is used when a board has not set its own table.
Signed-off-by: Tom Rini trini@ti.com
Dear Fabio Estevam,
On Mon, Jan 28, 2013 at 10:46 AM, Marek Vasut marex@denx.de wrote:
This will not allow different baudrates now, will it?
You still may change the baudrate if you need to.
CONFIG_SYS_BAUDRATE_TABLE has been placed to a common place after the commit below:
commit 26750c8aee2383a026e0cf89e9310628d3a5a6a0 Author: Tom Rini trini@ti.com Date: Tue Jun 19 12:54:34 2012 +0000
CONFIG_SYS_BAUDRATE_TABLE: Add <config_fallbacks.h>, place there We provide a default table of { 9600, 19200, 38400, 57600, 115200 } in <config_fallbacks.h> which mkconfig places after <configs/...h> in the generated config file. This is used when a board has not set its own table. Signed-off-by: Tom Rini <trini@ti.com>
Ok then I'd say -- kill 'em all!!
Best regards, Marek Vasut
On 28/01/2013 12:41, Fabio Estevam wrote:
The baudrate is already defined by CONFIG_BAUDRATE and there is no need to keep CONFIG_SYS_BAUDRATE_TABLE.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Applied to u-boot-imx, thanks.
Best regards, Stefano Babic
It is safe to turn on data and instruction caches for mx23.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- include/configs/mx23evk.h | 2 -- 1 file changed, 2 deletions(-)
diff --git a/include/configs/mx23evk.h b/include/configs/mx23evk.h index e43b93f..ae8cf6c 100644 --- a/include/configs/mx23evk.h +++ b/include/configs/mx23evk.h @@ -33,8 +33,6 @@ #define CONFIG_MACH_TYPE MACH_TYPE_MX23EVK
#define CONFIG_SYS_NO_FLASH -#define CONFIG_SYS_ICACHE_OFF -#define CONFIG_SYS_DCACHE_OFF #define CONFIG_BOARD_EARLY_INIT_F #define CONFIG_ARCH_MISC_INIT
Dear Fabio Estevam,
It is safe to turn on data and instruction caches for mx23.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
include/configs/mx23evk.h | 2 -- 1 file changed, 2 deletions(-)
diff --git a/include/configs/mx23evk.h b/include/configs/mx23evk.h index e43b93f..ae8cf6c 100644 --- a/include/configs/mx23evk.h +++ b/include/configs/mx23evk.h @@ -33,8 +33,6 @@ #define CONFIG_MACH_TYPE MACH_TYPE_MX23EVK
#define CONFIG_SYS_NO_FLASH -#define CONFIG_SYS_ICACHE_OFF -#define CONFIG_SYS_DCACHE_OFF #define CONFIG_BOARD_EARLY_INIT_F #define CONFIG_ARCH_MISC_INIT
Can you fix this for olinuxino (if not done already) too please?
Best regards, Marek Vasut
On Mon, Jan 28, 2013 at 10:47 AM, Marek Vasut marex@denx.de wrote:
Can you fix this for olinuxino (if not done already) too please?
mx23olinuxino has the caches turned on already.
On 28/01/2013 12:41, Fabio Estevam wrote:
It is safe to turn on data and instruction caches for mx23.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Applied to u-boot-imx, thanks.
Best regards, Stefano Babic
On Mon, Jan 28, 2013 at 9:40 AM, Fabio Estevam fabio.estevam@freescale.com wrote:
Rather than 'undef'ing some symbols, just remove them instead.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
include/configs/mx23evk.h | 2 -- 1 file changed, 2 deletions(-)
diff --git a/include/configs/mx23evk.h b/include/configs/mx23evk.h index c44a8b8..51aa9c4 100644 --- a/include/configs/mx23evk.h +++ b/include/configs/mx23evk.h @@ -49,8 +49,6 @@
/* U-Boot Commands */ #include <config_cmd_default.h> -#undef CONFIG_CMD_NET -#undef CONFIG_CMD_NFS
#define CONFIG_DISPLAY_CPUINFO #define CONFIG_DOS_PARTITION
The problem is that the default cmd set include them; that's why I had the undef.
-- Otavio Salvador O.S. Systems E-mail: otavio@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
participants (5)
-
Fabio Estevam -
Fabio Estevam -
Marek Vasut -
Otavio Salvador -
Stefano Babic