[U-Boot-Users] [PATCH] lba48 support & 64bit vsprintf
Added some CONFIG and CFG variables to for LBA48 support and for 64bit printing. Now you can use LBA48 and not use 64bit in vsprintf. LBA48 now works without 64bit.
Changelog Rune Torgersen - Added LBA48 support (CONFIG_LBA48 & CFG_64BIT_LBA) - Added support for 64bit printing in vsprintf (CFG_64BIT_VSPRINTF) - Added support for 64bit strtoul (CFG_64BIT_STRTOUL) README is also updated for these variables
Rune Torgersen System Developer Innovative Systems LLC 1000 Innovative Drive Mitchell, SD 57301 Ph: 605-995-6120 www.innovsys.com
In message DCEAAC0833DD314AB0B58112AD99B93B06DA7C@ismail.innsys.innovsys.com you wrote:
Added some CONFIG and CFG variables to for LBA48 support and for 64bit printing. Now you can use LBA48 and not use 64bit in vsprintf. LBA48 now works without 64bit.
Please do not use C++ comments in C code. Please do not add trailing white space. Please use the required indentation style (1TBS). Your patches are inconsistent (they overlap in include/common.h)
Your "long long" vsprintf is non-standard and I thus consider it broken. You use a 'L' length modifier for long long, but the standard requires 'll' instead ('L' stands for long double). If you need to stick with a single character length modifier please let's use 'q' instead (I changed your code this way - please ACK that this is OK with you).
Best regards,
Wolfgang Denk
participants (2)
-
Rune Torgersen -
Wolfgang Denk