[GIT PULL] Please pull u-boot-mmc master
Dear Tom,
Please pull u-boot-mmc master into u-boot master branch. If there is any problem, let me know, plz
Best Regards, Jaehoon Chung
CI: https://source.denx.de/u-boot/custodians/u-boot-mmc/-/pipelines/20547
The following changes since commit d097f9e1299a3bdb7de468f0d9bbc63932f461cd:
Merge tag 'fsl-qoriq-2024-4-24' of https://source.denx.de/u-boot/custodians/u-boot-fsl-qoriq (2024-04-23 17:53:06 -0600)
are available in the Git repository at:
git@source.denx.de:u-boot/custodians/u-boot-mmc.git master
for you to fetch changes up to 1776213dadef4b578f98bcf18beb152f8975a8bf:
mmc: arm_pl180: Limit data transfer to U16_MAX (2024-04-26 15:32:06 +0900)
---------------------------------------------------------------- Greg Malysa (1): mmc: Support 32-bit only ADMA on 64-bit platforms
Ian Roberts (2): mmc: sdhci: introduce adma_write_desc() hook to struct sdhci_ops mmc: sdhci: Fix potential ADMA descriptor table overflow
Jonas Karlman (2): mmc: Imply HS200 cap with mmc-hs400 prop to match linux mmc: Add support for the no-mmc-hs400 prop
Maximilian Brune (1): mmc: arm_pl180: Limit data transfer to U16_MAX
cmachida (1): mmc: sdhci: programmable clock calculation needs multiplier +1
drivers/mmc/Kconfig | 18 ++++++++++++++++++ drivers/mmc/arm_pl180_mmci.c | 10 ++++++++++ drivers/mmc/fsl_esdhc.c | 2 +- drivers/mmc/mmc-uclass.c | 7 +++++-- drivers/mmc/sdhci-adma.c | 43 +++++++++++++++++++++++++++++-------------- drivers/mmc/sdhci.c | 26 ++++++++++++++++++-------- include/sdhci.h | 21 +++++++++++++++------ 7 files changed, 96 insertions(+), 31 deletions(-)
On Fri, Apr 26, 2024 at 07:38:30PM +0900, Jaehoon Chung wrote:
Dear Tom,
Please pull u-boot-mmc master into u-boot master branch. If there is any problem, let me know, plz
Best Regards, Jaehoon Chung
CI: https://source.denx.de/u-boot/custodians/u-boot-mmc/-/pipelines/20547
The following changes since commit d097f9e1299a3bdb7de468f0d9bbc63932f461cd:
Merge tag 'fsl-qoriq-2024-4-24' of https://source.denx.de/u-boot/custodians/u-boot-fsl-qoriq (2024-04-23 17:53:06 -0600)
are available in the Git repository at:
git@source.denx.de:u-boot/custodians/u-boot-mmc.git master
for you to fetch changes up to 1776213dadef4b578f98bcf18beb152f8975a8bf:
mmc: arm_pl180: Limit data transfer to U16_MAX (2024-04-26 15:32:06 +0900)
Applied to u-boot/master, thanks!
Hi all,
On 4/26/24 10:51 AM, Tom Rini wrote:
On Fri, Apr 26, 2024 at 07:38:30PM +0900, Jaehoon Chung wrote:
Dear Tom,
Please pull u-boot-mmc master into u-boot master branch. If there is any problem, let me know, plz
Best Regards, Jaehoon Chung
CI: https://source.denx.de/u-boot/custodians/u-boot-mmc/-/pipelines/20547
The following changes since commit d097f9e1299a3bdb7de468f0d9bbc63932f461cd:
Merge tag 'fsl-qoriq-2024-4-24' of https://source.denx.de/u-boot/custodians/u-boot-fsl-qoriq (2024-04-23 17:53:06 -0600)
are available in the Git repository at:
git@source.denx.de:u-boot/custodians/u-boot-mmc.git master
for you to fetch changes up to 1776213dadef4b578f98bcf18beb152f8975a8bf:
mmc: arm_pl180: Limit data transfer to U16_MAX (2024-04-26 15:32:06 +0900)
Applied to u-boot/master, thanks!
A patch in this series caused a regression for AM62x SK with the following error:
Error reading cluster spl_load_image_fat: error reading image u-boot.img, err - -22 SPL: failed to boot from all boot devices (err=-6) ### ERROR ### Please RESET the board ###
Git bisect showed "mmc: sdhci: introduce adma_write_desc() hook to struct sdhci_ops" to be the offending commit.
Could someone point me to the next steps to fix this issue?
regards, Judith
Dear Judith,
-----Original Message----- From: Judith Mendez jm@ti.com Sent: Tuesday, April 30, 2024 5:40 AM To: Tom Rini trini@konsulko.com; Jaehoon Chung jh80.chung@samsung.com Cc: U-Boot Mailing List U-Boot@lists.denx.de; maximilian.brune@9elements.com; curtis.machida@intel.com; Jonas Karlman jonas@kwiboo.se; greg.malysa@timesys.com; ian.roberts@timesys.com; Jae hoon Chung jh80.chung@gmail.com; Peng Fan peng.fan@nxp.com; sheng.tan@9elements.com Subject: Re: [GIT PULL] Please pull u-boot-mmc master
Hi all,
On 4/26/24 10:51 AM, Tom Rini wrote:
On Fri, Apr 26, 2024 at 07:38:30PM +0900, Jaehoon Chung wrote:
Dear Tom,
Please pull u-boot-mmc master into u-boot master branch. If there is any problem, let me know, plz
Best Regards, Jaehoon Chung
CI: https://protect2.fireeye.com/v1/url?k=aa60f1d5-cbebe4f5-aa617a9a-74fe485fb34...
9095c5a77eabfca7&q=1&e=d67a142c-0b69-4de3-be99-de9292c603f2&u=https%3A%2F%2Fsource.denx.de%2Fu- boot%2Fcustodians%2Fu-boot-mmc%2F-%2Fpipelines%2F20547
The following changes since commit d097f9e1299a3bdb7de468f0d9bbc63932f461cd:
Merge tag 'fsl-qoriq-2024-4-24' of https://protect2.fireeye.com/v1/url?k=93e2c287-f269d7a7-
93e349c8-74fe485fb347-247fe01368500b3b&q=1&e=d67a142c-0b69-4de3-be99- de9292c603f2&u=https%3A%2F%2Fsource.denx.de%2Fu-boot%2Fcustodians%2Fu-boot-fsl-qoriq (2024-04-23 17:53:06 -0600)
are available in the Git repository at:
git@source.denx.de:u-boot/custodians/u-boot-mmc.git master
for you to fetch changes up to 1776213dadef4b578f98bcf18beb152f8975a8bf:
mmc: arm_pl180: Limit data transfer to U16_MAX (2024-04-26 15:32:06 +0900)
Applied to u-boot/master, thanks!
A patch in this series caused a regression for AM62x SK with the following error:
Error reading cluster spl_load_image_fat: error reading image u-boot.img, err - -22 SPL: failed to boot from all boot devices (err=-6) ### ERROR ### Please RESET the board ###
Git bisect showed "mmc: sdhci: introduce adma_write_desc() hook to struct sdhci_ops" to be the offending commit.
Could someone point me to the next steps to fix this issue?
I will check this problem. Thanks for pointing out.
Best Regards, Jaehoon Chung
regards, Judith
On Mon, Apr 29, 2024 at 03:39:53PM -0500, Judith Mendez wrote:
On 4/26/24 10:51 AM, Tom Rini wrote:
On Fri, Apr 26, 2024 at 07:38:30PM +0900, Jaehoon Chung wrote:
Please pull u-boot-mmc master into u-boot master branch. If there is any problem, let me know, plz
Applied to u-boot/master, thanks!
A patch in this series caused a regression for AM62x SK with the following error:
+1, this affects also Verdin AM62.
``` Trying to boot from MMC1 mmc_load_image_raw_sector: mmc block read error Partition 1 invalid on device 0 spl_register_fat_device: fat register err - -1 spl_load_image_fat: error reading image u-boot.img, err - -1 SPL: failed to boot from all boot devices ### ERROR ### Please RESET the board ### ```
Francesco
I am also looking into it since it's our change that is causing the issue. The functions modified don't return status codes so that must mean that it is causing the transaction to be configured incorrectly. However I don't have hardware to test these platforms locally, but I might be able to get a coworker who has an am62 platform to help me test (not sure which one though).
Some things I would like to look at first: 1) host->ops->adma_write_desc is expected to be NULL on this platform. If it weren't it'd probably crash instead but it seems like a decent starting point. I believe this corresponds to j721e_4bit_sdhci_ops in this case? 2) Could we compare the contents of the descriptors that are written in sdhci_adma_write_desc between working and broken builds? 3) sdhci_adma_init is only called if the descriptor table is null; is there any chance it has a random value instead of NULL to start off, so it isn't called and adma_addr is not populated correctly?
Thanks, Greg
-- Greg Malysa Timesys Corporation
On Tue, Apr 30, 2024 at 3:42 AM Francesco Dolcini francesco@dolcini.it wrote:
On Mon, Apr 29, 2024 at 03:39:53PM -0500, Judith Mendez wrote:
A patch in this series caused a regression for AM62x SK with the following error:
+1, this affects also Verdin AM62.
Hi, please try https://patchwork.ozlabs.org/project/uboot/patch/20240501185331.1189647-1-al... as this should explain the issue and also fix it.
Hi Greg,
On 5/1/24 9:40 PM, Greg Malysa wrote:
On Tue, Apr 30, 2024 at 3:42 AM Francesco Dolcini francesco@dolcini.it wrote:
On Mon, Apr 29, 2024 at 03:39:53PM -0500, Judith Mendez wrote:
A patch in this series caused a regression for AM62x SK with the following error:
+1, this affects also Verdin AM62.
Hi, please try https://patchwork.ozlabs.org/project/uboot/patch/20240501185331.1189647-1-al... as this should explain the issue and also fix it.
The fix fixes my issuu on AM62x, thanks.
~ Judith
participants (5)
-
Francesco Dolcini -
Greg Malysa -
Jaehoon Chung -
Judith Mendez -
Tom Rini