Dear Jaehoon Chung,

-----Original Message----- From: Jaehoon Chung [mailto:jh80.chung@samsung.com] Sent: Thursday, December 26, 2013 9:03 AM To: Piotr Wilczek; u-boot@lists.denx.de Cc: Kyungmin Park Subject: Re: [U-Boot] [PATCH] board:trats2: fix default partitions and mmc env

Hi, Piotr.

On 12/19/2013 11:09 PM, Piotr Wilczek wrote:

...

This patch add uuid disk to defualt partions necessary to restore gpt partitions and fixes mmcdev environmental variable.

Signed-off-by: Piotr Wilczek p.wilczek@samsung.com Signed-off-by: Kyungmin Park kyungmin.park@samsung.com

---

include/configs/trats2.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/configs/trats2.h b/include/configs/trats2.h

index

...

5d86a3d..4c0068b 100644 --- a/include/configs/trats2.h +++ b/include/configs/trats2.h @@ -160,6 +160,7 @@ #define PARTS_UMS "ums"

#define PARTS_DEFAULT \

• "uuid_disk=${uuid_gpt_disk};" \

"name="PARTS_CSA",start=5MiB,size=8MiB,uuid=${uuid_gpt_"PARTS_CSA "};" \

...

"name="PARTS_BOOT",size=64MiB,uuid=${uuid_gpt_"PARTS_BOOT"};" \ "name="PARTS_MODEM",size=100MiB,uuid=${uuid_gpt_"PARTS_MODEM"};"

\

...

@@ -201,7 +202,7 @@ "${kernelname}\0" \ "loaddtb=ext4load mmc ${mmcdev}:${mmcbootpart} ${fdtaddr} " \ "${fdtfile}\0" \

• "mmcdev=CONFIG_MMC_DEFAULT_DEV\0" \

• "mmcdev=0\0" \

What difference is CONFIG_MMC_DEFAULT_DEV and 0? CONFIG_MMC_DEFAULT_DEV 0 is defined. Maybe, mmcdev is set to 0, isn't? (It recognized that CONFIG_MMC_DEFAULT_DEV isn't defined.)

You are right, CONFIG_MMC_DEFAULT_DEV is set 0. I should have used __stringify function originally. Please see V2: http://patchwork.ozlabs.org/patch/305737/

Please also see the following patch: http://patchwork.ozlabs.org/patch/302903/

Both are very important fixes for current release.

Best Regards, Jaehoon Chung

...

"mmcbootpart=2\0" \ "mmcrootpart=5\0" \ "opts=always_resume=1\0" \

Best regards, Piotr Wilczek

On 30/12/13 17:40, Piotr Wilczek wrote:

This patch add uuid disk to defualt partions necessary to restore gpt partitions and fixes mmcdev environmental variable.

Signed-off-by: Piotr Wilczek p.wilczek@samsung.com Signed-off-by: Kyungmin Park kyungmin.park@samsung.com

---

Changes for V2:

• use __stringify for CONFIG_MMC_DEFAULT_DEV stringification

include/configs/trats2.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/configs/trats2.h b/include/configs/trats2.h index 5d86a3d..c9ce828 100644 --- a/include/configs/trats2.h +++ b/include/configs/trats2.h @@ -160,6 +160,7 @@ #define PARTS_UMS "ums"

#define PARTS_DEFAULT \

• "uuid_disk=${uuid_gpt_disk};" \ "name="PARTS_CSA",start=5MiB,size=8MiB,uuid=${uuid_gpt_"PARTS_CSA"};" \ "name="PARTS_BOOT",size=64MiB,uuid=${uuid_gpt_"PARTS_BOOT"};" \ "name="PARTS_MODEM",size=100MiB,uuid=${uuid_gpt_"PARTS_MODEM"};" \

@@ -201,7 +202,7 @@ "${kernelname}\0" \ "loaddtb=ext4load mmc ${mmcdev}:${mmcbootpart} ${fdtaddr} " \ "${fdtfile}\0" \

• "mmcdev=CONFIG_MMC_DEFAULT_DEV\0" \

• "mmcdev=" __stringify(CONFIG_MMC_DEFAULT_DEV) "\0" \ "mmcbootpart=2\0" \ "mmcrootpart=5\0" \ "opts=always_resume=1\0" \

applied to u-boot-samsung.

Thanks, Minkyu Kang.