[U-Boot] [PATCH 0/1] Fix ethernet regression on pcm051
From: Lars Poeschel poeschel@lemonage.de
I compiled and tried v2013.10-rc2 on pcm051 and it fails booting over tftp. I could bisect 2bf36ac638ab2db9f0295aa47064976eeebf80c1 as the cause of the problem. It moves bd_ram_ofs from the cpsw driver to the board files. Adding the bd_ram_ofs to the board file of pcm051 fixes the problem. That is what the patch does. A quick grep reveals, that igep0033 MAY also be affected. As the patch is simple and obivous and fixes a regression I'd like to get this in before the v2013.10 release.
Thanks
Lars Poeschel (1): pcm051: Supply a bd_ram_ofs for the cpsw driver
board/phytec/pcm051/board.c | 1 + 1 file changed, 1 insertion(+)
From: Lars Poeschel poeschel@lemonage.de
Since 2bf36ac638ab2db9f0295aa47064976eeebf80c1 the BD ram address is not hardcoded inside cpsw driver any more. Platforms have to supply their bd_ram_ofs in the platform data to the driver. With this commit pcm051 does this.
Signed-off-by: Lars Poeschel poeschel@lemonage.de --- board/phytec/pcm051/board.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/board/phytec/pcm051/board.c b/board/phytec/pcm051/board.c index e40b0bd..dafb1eb 100644 --- a/board/phytec/pcm051/board.c +++ b/board/phytec/pcm051/board.c @@ -150,6 +150,7 @@ static struct cpsw_platform_data cpsw_data = { .ale_entries = 1024, .host_port_reg_ofs = 0x108, .hw_stats_reg_ofs = 0x900, + .bd_ram_ofs = 0x2000, .mac_control = (1 << 5), .control = cpsw_control, .host_port_num = 0,
On 9/25/2013 5:21 AM, Lars Poeschel wrote:
From: Lars Poeschel poeschel@lemonage.de
I compiled and tried v2013.10-rc2 on pcm051 and it fails booting over tftp. I could bisect 2bf36ac638ab2db9f0295aa47064976eeebf80c1 as the cause of the problem. It moves bd_ram_ofs from the cpsw driver to the board files. Adding the bd_ram_ofs to the board file of pcm051 fixes the problem. That is what the patch does. A quick grep reveals, that igep0033 MAY also be affected. As the patch is simple and obivous and fixes a regression I'd like to get this in before the v2013.10 release.
Thanks
Lars Poeschel (1): pcm051: Supply a bd_ram_ofs for the cpsw driver
board/phytec/pcm051/board.c | 1 + 1 file changed, 1 insertion(+)
Acked-by: Mugunthan V N mugunthanvnm@ti.com
Regards Mugunthan V N
Hi Lars,
2013/9/26 Mugunthan V N mugunthanvnm@ti.com:
On 9/25/2013 5:21 AM, Lars Poeschel wrote:
From: Lars Poeschel poeschel@lemonage.de
I compiled and tried v2013.10-rc2 on pcm051 and it fails booting over tftp. I could bisect 2bf36ac638ab2db9f0295aa47064976eeebf80c1 as the cause of the problem. It moves bd_ram_ofs from the cpsw driver to the board files. Adding the bd_ram_ofs to the board file of pcm051 fixes the problem. That is what the patch does. A quick grep reveals, that igep0033 MAY also be affected. As the patch is simple and obivous and fixes a regression I'd like to get this in before the v2013.10 release.
Many thanks to detect this, as you said the igep0033 machine is also affected for this, so this patch is required. Could you send a version 2 and add the patch for igep0033 in the series ?. You can also add my
Tested-by: Enric Balletbo i Serra eballetbo@iseebcn.com
I'd like to get this series in before the v2013.10 release, too.
Thanks
Lars Poeschel (1): pcm051: Supply a bd_ram_ofs for the cpsw driver
board/phytec/pcm051/board.c | 1 + 1 file changed, 1 insertion(+)
Acked-by: Mugunthan V N mugunthanvnm@ti.com
Regards Mugunthan V N _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Regards,
Enric
participants (3)
-
Enric Balletbo Serra -
Lars Poeschel -
Mugunthan V N