[U-Boot] [PATCH] buildman: Make -V (verbose_build) really be verbose

The help text for -V says we will pass V=1 but all it really did was not pass in -s. Change the logic to pass make V=1 with given to buildman -V or -s to make otherwise.
Cc: Simon Glass sjg@chromium.org Signed-off-by: Tom Rini trini@konsulko.com --- tools/buildman/builderthread.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py index efb62f1..d7e7a78 100644 --- a/tools/buildman/builderthread.py +++ b/tools/buildman/builderthread.py @@ -197,7 +197,9 @@ class BuilderThread(threading.Thread): src_dir = os.getcwd() else: args.append('O=build') - if not self.builder.verbose_build: + if self.builder.verbose_build: + args.append('V=1') + else: args.append('-s') if self.builder.num_jobs is not None: args.extend(['-j', str(self.builder.num_jobs)])

Hi Tom,
On 1 April 2015 at 05:47, Tom Rini trini@konsulko.com wrote:
The help text for -V says we will pass V=1 but all it really did was not pass in -s. Change the logic to pass make V=1 with given to buildman -V or -s to make otherwise.
Cc: Simon Glass sjg@chromium.org Signed-off-by: Tom Rini trini@konsulko.com
tools/buildman/builderthread.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Acked-by: Simon Glass sjg@chromium.org
See also:
http://patchwork.ozlabs.org/patch/437051/
diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py index efb62f1..d7e7a78 100644 --- a/tools/buildman/builderthread.py +++ b/tools/buildman/builderthread.py @@ -197,7 +197,9 @@ class BuilderThread(threading.Thread): src_dir = os.getcwd() else: args.append('O=build')
if not self.builder.verbose_build:
if self.builder.verbose_build:
args.append('V=1')
else: args.append('-s') if self.builder.num_jobs is not None: args.extend(['-j', str(self.builder.num_jobs)])
-- 1.7.9.5
Regards, Simon

On Sun, Apr 05, 2015 at 12:31:39PM -0600, Simon Glass wrote:
Hi Tom,
On 1 April 2015 at 05:47, Tom Rini trini@konsulko.com wrote:
The help text for -V says we will pass V=1 but all it really did was not pass in -s. Change the logic to pass make V=1 with given to buildman -V or -s to make otherwise.
Cc: Simon Glass sjg@chromium.org Signed-off-by: Tom Rini trini@konsulko.com
tools/buildman/builderthread.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Acked-by: Simon Glass sjg@chromium.org
Thanks :)
See also:
Also useful, but I ran into this when I was going "what lds script does X use again? Lemme build, wait, lemme verbose build, wait, what?" and saw we didn't save the V=1 output just regular output.

On 6 April 2015 at 18:36, Tom Rini trini@konsulko.com wrote:
On Sun, Apr 05, 2015 at 12:31:39PM -0600, Simon Glass wrote:
Hi Tom,
On 1 April 2015 at 05:47, Tom Rini trini@konsulko.com wrote:
The help text for -V says we will pass V=1 but all it really did was not pass in -s. Change the logic to pass make V=1 with given to buildman -V or -s to make otherwise.
Cc: Simon Glass sjg@chromium.org Signed-off-by: Tom Rini trini@konsulko.com
tools/buildman/builderthread.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Acked-by: Simon Glass sjg@chromium.org
Thanks :)
See also:
Also useful, but I ran into this when I was going "what lds script does X use again? Lemme build, wait, lemme verbose build, wait, what?" and saw we didn't save the V=1 output just regular output.
Applied to u-boot-x86/buildman, thanks!
participants (2)
-
Simon Glass
-
Tom Rini