Hi All, Actually I just plan to try feature of support SS hub which just enabled this yesterday on LS1021ATWR (I know need to enable DM_USB for 1021 first). Per your knowledge, if I revert the patches I pasted in last mail, the SS hub support feature will be impacted or not? Thanks. Ran

-----Original Message----- From: Marek Vasut [mailto:marex@denx.de] Sent: Thursday, July 20, 2017 5:30 PM To: Ran Wang ran.wang_1@nxp.com; Patrice Chotard patrice.chotard@st.com Cc: Simon Glass sjg@chromium.org; Masahiro Yamada yamada.masahiro@socionext.com; Bin Meng bmeng.cn@gmail.com; Jiafei Pan jiafei.pan@nxp.com; u-boot@lists.denx.de Subject: Re: Compile failure encountered on latest (2017-07-20) git://git.denx.de/u-boot-usb.git branch master for target ls1021atwr_nor_defconfig

On 07/20/2017 11:28 AM, Ran Wang wrote:

...

Hello,

Hello,

...

Today (2017-07-20) I pulled the latest U-Boot source code and found attached

patch set will cause build failure (log also attached).

...

When I moved HEAD backward of them, issue resolved. Could you please help to double confirm this?

Thanks for the report, given the magnitude of the patchset, I'm not surprised, although I would've expected someone build-tested them properly ... I expect patches, ASAP.

...

I tried another target ls1046ardb_qspi_defconfig, fail too. Thank you. BR Ran

-- Best regards, Marek Vasut

Hi Bin and Marek, By enabling DM_USB for ls1021atwr and reverting culprit patch set which cause build failure, now I successfully enumerate SS hub and the SS thumb drive behind it :) Actually I have read your discussion on this feature (https://patchwork.ozlabs.org/patch/779920/). I will submit patch to enable DM_USB in Kconfig for ls1021 later.

Thanks for your great work!

BR Ran

-----Original Message----- From: Marek Vasut [mailto:marex@denx.de] Sent: Thursday, July 20, 2017 5:30 PM To: Ran Wang ran.wang_1@nxp.com; Patrice Chotard patrice.chotard@st.com Cc: Simon Glass sjg@chromium.org; Masahiro Yamada yamada.masahiro@socionext.com; Bin Meng bmeng.cn@gmail.com; Jiafei Pan jiafei.pan@nxp.com; u-boot@lists.denx.de Subject: Re: Compile failure encountered on latest (2017-07-20) git://git.denx.de/u-boot-usb.git branch master for target ls1021atwr_nor_defconfig

On 07/20/2017 11:28 AM, Ran Wang wrote:

...

Hello,

Hello,

...

Today (2017-07-20) I pulled the latest U-Boot source code and found attached

patch set will cause build failure (log also attached).

...

When I moved HEAD backward of them, issue resolved. Could you please help to double confirm this?

Thanks for the report, given the magnitude of the patchset, I'm not surprised, although I would've expected someone build-tested them properly ... I expect patches, ASAP.

...

I tried another target ls1046ardb_qspi_defconfig, fail too. Thank you. BR Ran

-- Best regards, Marek Vasut

Hi Marek, Ran, Bin

I will send a patch which fix the compilation issue due to introduction of PHY support in xhci-dwc3 driver.

introduced in patch : 84e53877f5148 usb: host: xhci-dwc3: Add generic PHY support

Sorry for that.

Patrice

On 07/20/2017 12:21 PM, Marek Vasut wrote:

On 07/20/2017 12:18 PM, Ran Wang wrote:

...

Hi Bin and Marek,

Please stop top-posting and fix your mailer to wrap lines at 80.

...

 By enabling DM_USB for ls1021atwr and reverting culprit patch set which cause build failure, now I successfully enumerate SS hub and the SS thumb drive behind it :)
 Actually I have read your discussion on this feature (https://patchwork.ozlabs.org/patch/779920/).
 I will submit patch to enable DM_USB in Kconfig for ls1021 later.

Please send a fix rather than a workaround ; enabling DM_USB can be done later.

...

 Thanks for your great work!

BR Ran

...

-----Original Message----- From: Marek Vasut [mailto:marex@denx.de] Sent: Thursday, July 20, 2017 5:30 PM To: Ran Wang ran.wang_1@nxp.com; Patrice Chotard patrice.chotard@st.com Cc: Simon Glass sjg@chromium.org; Masahiro Yamada yamada.masahiro@socionext.com; Bin Meng bmeng.cn@gmail.com; Jiafei Pan jiafei.pan@nxp.com; u-boot@lists.denx.de Subject: Re: Compile failure encountered on latest (2017-07-20) git://git.denx.de/u-boot-usb.git branch master for target ls1021atwr_nor_defconfig

On 07/20/2017 11:28 AM, Ran Wang wrote:

...

Hello,

Hello,

...

Today (2017-07-20) I pulled the latest U-Boot source code and found attached

patch set will cause build failure (log also attached).

...

When I moved HEAD backward of them, issue resolved. Could you please help to double confirm this?

Thanks for the report, given the magnitude of the patchset, I'm not surprised, although I would've expected someone build-tested them properly ... I expect patches, ASAP.

...

I tried another target ls1046ardb_qspi_defconfig, fail too. Thank you. BR Ran

-- Best regards, Marek Vasut

Hi Marek,

On Thu, Jul 20, 2017 at 5:30 PM, Marek Vasut marex@denx.de wrote:

On 07/20/2017 11:28 AM, Ran Wang wrote:

...

Hello,

Hello,

...

Today (2017-07-20) I pulled the latest U-Boot source code and found attached patch set will cause build failure (log also attached). When I moved HEAD backward of them, issue resolved. Could you please help to double confirm this?

Thanks for the report, given the magnitude of the patchset, I'm not surprised, although I would've expected someone build-tested them properly ... I expect patches, ASAP.

The broken build seems to be caused by the dwc3-xhci patchset. I've buildman tested my xhci patchset.

...

I tried another target ls1046ardb_qspi_defconfig, fail too. Thank you.

Regards, Bin

Hi Marek

I have resubmitted my 2 series : _ [PATCH v8 0/6] Extend xhci-dwc3​ _ [PATCH v11 00/10] usb: Extend ehci and ohci generic driver​

The xhci-dwc3 series must be merged first due to dependencies with PHY patches with the second series.

All my patches in u-boot-usb/master branches can be dropped and replaced by the 2 above series.

To sum-up, these 2 series fixed: _ compilation issues reported by Ran Wang due to missing flag for platforms which use xhci-dwc3.c driver but don't use generic PHY. _ the bisection issue reported by Łukasz Majewski in xhci-dwc3.c driver. _ issue reported by Patrick Delaunay in both ehci and ohci drivers, where PHY must be initialized only when found.

buildman has been run on all platforms using EHCI_GENERIC, OHCI_GENERIC and USB_XHCI_DWC3 flags in there defconfig.

Sorry for the inconvenience

Patrice

On 07/21/2017 02:38 PM, Marek Vasut wrote:

On 07/21/2017 02:26 PM, Bin Meng wrote:

...

Hi Marek,

On Thu, Jul 20, 2017 at 5:30 PM, Marek Vasut marex@denx.de wrote:

...

On 07/20/2017 11:28 AM, Ran Wang wrote:

...

Hello,

Hello,

...

Today (2017-07-20) I pulled the latest U-Boot source code and found attached patch set will cause build failure (log also attached). When I moved HEAD backward of them, issue resolved. Could you please help to double confirm this?

Thanks for the report, given the magnitude of the patchset, I'm not surprised, although I would've expected someone build-tested them properly ... I expect patches, ASAP.

The broken build seems to be caused by the dwc3-xhci patchset. I've buildman tested my xhci patchset.

Indeed, I'm waiting for a fix.