[PATCH] gpio: renesas: Simplify .request/.rfree callbacks
Remove identify wrapper functions.
Signed-off-by: Pali Rohár pali@kernel.org --- drivers/gpio/gpio-rcar.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c index 138801850d3e..ba00bb459679 100644 --- a/drivers/gpio/gpio-rcar.c +++ b/drivers/gpio/gpio-rcar.c @@ -130,20 +130,9 @@ static int rcar_gpio_get_function(struct udevice *dev, unsigned offset) return GPIOF_INPUT; }
-static int rcar_gpio_request(struct udevice *dev, unsigned offset, - const char *label) -{ - return pinctrl_gpio_request(dev, offset, label); -} - -static int rcar_gpio_free(struct udevice *dev, unsigned offset) -{ - return pinctrl_gpio_free(dev, offset); -} - static const struct dm_gpio_ops rcar_gpio_ops = { - .request = rcar_gpio_request, - .rfree = rcar_gpio_free, + .request = pinctrl_gpio_request, + .rfree = pinctrl_gpio_free, .direction_input = rcar_gpio_direction_input, .direction_output = rcar_gpio_direction_output, .get_value = rcar_gpio_get_value,
On 02.08.22 12:06, Pali Rohár wrote:
Remove identify wrapper functions.
Signed-off-by: Pali Rohár pali@kernel.org
Reviewed-by: Stefan Roese sr@denx.de
Thanks, Stefan
drivers/gpio/gpio-rcar.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c index 138801850d3e..ba00bb459679 100644 --- a/drivers/gpio/gpio-rcar.c +++ b/drivers/gpio/gpio-rcar.c @@ -130,20 +130,9 @@ static int rcar_gpio_get_function(struct udevice *dev, unsigned offset) return GPIOF_INPUT; }
-static int rcar_gpio_request(struct udevice *dev, unsigned offset,
const char *label)-{
- return pinctrl_gpio_request(dev, offset, label);
-}
-static int rcar_gpio_free(struct udevice *dev, unsigned offset) -{
- return pinctrl_gpio_free(dev, offset);
-}
- static const struct dm_gpio_ops rcar_gpio_ops = {
- .request = rcar_gpio_request,
- .rfree = rcar_gpio_free,
- .request = pinctrl_gpio_request,
- .rfree = pinctrl_gpio_free, .direction_input = rcar_gpio_direction_input, .direction_output = rcar_gpio_direction_output, .get_value = rcar_gpio_get_value,
Viele Grüße, Stefan Roese
On Wednesday 03 August 2022 08:48:39 Stefan Roese wrote:
On 02.08.22 12:06, Pali Rohár wrote:
Remove identify wrapper functions.
Signed-off-by: Pali Rohár pali@kernel.org
Reviewed-by: Stefan Roese sr@denx.de
Any more comments? Or could it be merged?
Thanks, Stefan
drivers/gpio/gpio-rcar.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c index 138801850d3e..ba00bb459679 100644 --- a/drivers/gpio/gpio-rcar.c +++ b/drivers/gpio/gpio-rcar.c @@ -130,20 +130,9 @@ static int rcar_gpio_get_function(struct udevice *dev, unsigned offset) return GPIOF_INPUT; } -static int rcar_gpio_request(struct udevice *dev, unsigned offset,
const char *label)-{
- return pinctrl_gpio_request(dev, offset, label);
-}
-static int rcar_gpio_free(struct udevice *dev, unsigned offset) -{
- return pinctrl_gpio_free(dev, offset);
-}
- static const struct dm_gpio_ops rcar_gpio_ops = {
- .request = rcar_gpio_request,
- .rfree = rcar_gpio_free,
- .request = pinctrl_gpio_request,
- .rfree = pinctrl_gpio_free, .direction_input = rcar_gpio_direction_input, .direction_output = rcar_gpio_direction_output, .get_value = rcar_gpio_get_value,
Viele Grüße, Stefan Roese
-- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
On Friday 02 September 2022 21:56:07 Pali Rohár wrote:
On Wednesday 03 August 2022 08:48:39 Stefan Roese wrote:
On 02.08.22 12:06, Pali Rohár wrote:
Remove identify wrapper functions.
Signed-off-by: Pali Rohár pali@kernel.org
Reviewed-by: Stefan Roese sr@denx.de
Any more comments? Or could it be merged?
PING after another month?
Thanks, Stefan
drivers/gpio/gpio-rcar.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c index 138801850d3e..ba00bb459679 100644 --- a/drivers/gpio/gpio-rcar.c +++ b/drivers/gpio/gpio-rcar.c @@ -130,20 +130,9 @@ static int rcar_gpio_get_function(struct udevice *dev, unsigned offset) return GPIOF_INPUT; } -static int rcar_gpio_request(struct udevice *dev, unsigned offset,
const char *label)-{
- return pinctrl_gpio_request(dev, offset, label);
-}
-static int rcar_gpio_free(struct udevice *dev, unsigned offset) -{
- return pinctrl_gpio_free(dev, offset);
-}
- static const struct dm_gpio_ops rcar_gpio_ops = {
- .request = rcar_gpio_request,
- .rfree = rcar_gpio_free,
- .request = pinctrl_gpio_request,
- .rfree = pinctrl_gpio_free, .direction_input = rcar_gpio_direction_input, .direction_output = rcar_gpio_direction_output, .get_value = rcar_gpio_get_value,
Viele Grüße, Stefan Roese
-- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
On Sunday 09 October 2022 14:34:55 Pali Rohár wrote:
On Friday 02 September 2022 21:56:07 Pali Rohár wrote:
On Wednesday 03 August 2022 08:48:39 Stefan Roese wrote:
On 02.08.22 12:06, Pali Rohár wrote:
Remove identify wrapper functions.
Signed-off-by: Pali Rohár pali@kernel.org
Reviewed-by: Stefan Roese sr@denx.de
Any more comments? Or could it be merged?
PING after another month?
PING?
Thanks, Stefan
drivers/gpio/gpio-rcar.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c index 138801850d3e..ba00bb459679 100644 --- a/drivers/gpio/gpio-rcar.c +++ b/drivers/gpio/gpio-rcar.c @@ -130,20 +130,9 @@ static int rcar_gpio_get_function(struct udevice *dev, unsigned offset) return GPIOF_INPUT; } -static int rcar_gpio_request(struct udevice *dev, unsigned offset,
const char *label)-{
- return pinctrl_gpio_request(dev, offset, label);
-}
-static int rcar_gpio_free(struct udevice *dev, unsigned offset) -{
- return pinctrl_gpio_free(dev, offset);
-}
- static const struct dm_gpio_ops rcar_gpio_ops = {
- .request = rcar_gpio_request,
- .rfree = rcar_gpio_free,
- .request = pinctrl_gpio_request,
- .rfree = pinctrl_gpio_free, .direction_input = rcar_gpio_direction_input, .direction_output = rcar_gpio_direction_output, .get_value = rcar_gpio_get_value,
Viele Grüße, Stefan Roese
-- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
Hi Pali,
added Marek to Cc
On 01.11.22 23:57, Pali Rohár wrote:
On Sunday 09 October 2022 14:34:55 Pali Rohár wrote:
On Friday 02 September 2022 21:56:07 Pali Rohár wrote:
On Wednesday 03 August 2022 08:48:39 Stefan Roese wrote:
On 02.08.22 12:06, Pali Rohár wrote:
Remove identify wrapper functions.
Signed-off-by: Pali Rohár pali@kernel.org
Reviewed-by: Stefan Roese sr@denx.de
Any more comments? Or could it be merged?
PING after another month?
PING?
Marek, could you please take a look? This patch is delegated to you in patchworks:
http://patchwork.ozlabs.org/project/uboot/patch/20220802100655.17965-1-pali@...
Thanks, Stefan
Thanks, Stefan
drivers/gpio/gpio-rcar.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c index 138801850d3e..ba00bb459679 100644 --- a/drivers/gpio/gpio-rcar.c +++ b/drivers/gpio/gpio-rcar.c @@ -130,20 +130,9 @@ static int rcar_gpio_get_function(struct udevice *dev, unsigned offset) return GPIOF_INPUT; } -static int rcar_gpio_request(struct udevice *dev, unsigned offset,
const char *label)-{
- return pinctrl_gpio_request(dev, offset, label);
-}
-static int rcar_gpio_free(struct udevice *dev, unsigned offset) -{
- return pinctrl_gpio_free(dev, offset);
-}
- static const struct dm_gpio_ops rcar_gpio_ops = {
- .request = rcar_gpio_request,
- .rfree = rcar_gpio_free,
- .request = pinctrl_gpio_request,
- .rfree = pinctrl_gpio_free, .direction_input = rcar_gpio_direction_input, .direction_output = rcar_gpio_direction_output, .get_value = rcar_gpio_get_value,
Viele Grüße, Stefan Roese
-- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
Viele Grüße, Stefan Roese
+ Tom
On Wednesday 02 November 2022 09:58:10 Stefan Roese wrote:
Hi Pali,
added Marek to Cc
On 01.11.22 23:57, Pali Rohár wrote:
On Sunday 09 October 2022 14:34:55 Pali Rohár wrote:
On Friday 02 September 2022 21:56:07 Pali Rohár wrote:
On Wednesday 03 August 2022 08:48:39 Stefan Roese wrote:
On 02.08.22 12:06, Pali Rohár wrote:
Remove identify wrapper functions.
Signed-off-by: Pali Rohár pali@kernel.org
Reviewed-by: Stefan Roese sr@denx.de
Any more comments? Or could it be merged?
PING after another month?
PING?
Marek, could you please take a look? This patch is delegated to you in patchworks:
http://patchwork.ozlabs.org/project/uboot/patch/20220802100655.17965-1-pali@...
Thanks, Stefan
Thanks, Stefan
drivers/gpio/gpio-rcar.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c index 138801850d3e..ba00bb459679 100644 --- a/drivers/gpio/gpio-rcar.c +++ b/drivers/gpio/gpio-rcar.c @@ -130,20 +130,9 @@ static int rcar_gpio_get_function(struct udevice *dev, unsigned offset) return GPIOF_INPUT; } -static int rcar_gpio_request(struct udevice *dev, unsigned offset,
const char *label)-{
- return pinctrl_gpio_request(dev, offset, label);
-}
-static int rcar_gpio_free(struct udevice *dev, unsigned offset) -{
- return pinctrl_gpio_free(dev, offset);
-}
- static const struct dm_gpio_ops rcar_gpio_ops = {
- .request = rcar_gpio_request,
- .rfree = rcar_gpio_free,
- .request = pinctrl_gpio_request,
- .rfree = pinctrl_gpio_free, .direction_input = rcar_gpio_direction_input, .direction_output = rcar_gpio_direction_output, .get_value = rcar_gpio_get_value,
Viele Grüße, Stefan Roese
-- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
Viele Grüße, Stefan Roese
-- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
On 11/2/22 09:58, Stefan Roese wrote:
Hi Pali,
Hello Stefan,
added Marek to Cc
Thank you.
On 01.11.22 23:57, Pali Rohár wrote:
On Sunday 09 October 2022 14:34:55 Pali Rohár wrote:
On Friday 02 September 2022 21:56:07 Pali Rohár wrote:
On Wednesday 03 August 2022 08:48:39 Stefan Roese wrote:
On 02.08.22 12:06, Pali Rohár wrote:
Remove identify wrapper functions.
Signed-off-by: Pali Rohár pali@kernel.org
Reviewed-by: Stefan Roese sr@denx.de
Any more comments? Or could it be merged?
PING after another month?
PING?
Marek, could you please take a look? This patch is delegated to you in patchworks:
http://patchwork.ozlabs.org/project/uboot/patch/20220802100655.17965-1-pali@...
It would be better if the patch author added me to CC, that could've prevented those frustrated pings with no response.
diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c index 138801850d3e..ba00bb459679 100644 --- a/drivers/gpio/gpio-rcar.c +++ b/drivers/gpio/gpio-rcar.c @@ -130,20 +130,9 @@ static int rcar_gpio_get_function(struct udevice *dev, unsigned offset) return GPIOF_INPUT; } -static int rcar_gpio_request(struct udevice *dev, unsigned offset, - const char *label) -{ - return pinctrl_gpio_request(dev, offset, label); -}
-static int rcar_gpio_free(struct udevice *dev, unsigned offset) -{ - return pinctrl_gpio_free(dev, offset); -}
static const struct dm_gpio_ops rcar_gpio_ops = { - .request = rcar_gpio_request, - .rfree = rcar_gpio_free, + .request = pinctrl_gpio_request, + .rfree = pinctrl_gpio_free, .direction_input = rcar_gpio_direction_input, .direction_output = rcar_gpio_direction_output, .get_value = rcar_gpio_get_value,
The patch is obviously OK,
Reviewed-by: Marek Vasut marex@denx.de
PING?
Another patch mentioned today which stay there for more than 8 months?
On Tuesday 02 August 2022 12:06:55 Pali Rohár wrote:
Remove identify wrapper functions.
Signed-off-by: Pali Rohár pali@kernel.org
drivers/gpio/gpio-rcar.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c index 138801850d3e..ba00bb459679 100644 --- a/drivers/gpio/gpio-rcar.c +++ b/drivers/gpio/gpio-rcar.c @@ -130,20 +130,9 @@ static int rcar_gpio_get_function(struct udevice *dev, unsigned offset) return GPIOF_INPUT; }
-static int rcar_gpio_request(struct udevice *dev, unsigned offset,
const char *label)-{
- return pinctrl_gpio_request(dev, offset, label);
-}
-static int rcar_gpio_free(struct udevice *dev, unsigned offset) -{
- return pinctrl_gpio_free(dev, offset);
-}
static const struct dm_gpio_ops rcar_gpio_ops = {
- .request = rcar_gpio_request,
- .rfree = rcar_gpio_free,
- .request = pinctrl_gpio_request,
- .rfree = pinctrl_gpio_free, .direction_input = rcar_gpio_direction_input, .direction_output = rcar_gpio_direction_output, .get_value = rcar_gpio_get_value,
-- 2.20.1
participants (3)
-
Marek Vasut -
Pali Rohár -
Stefan Roese