[U-Boot-Users] [Patch]IntegratorAP & CP multi core module support
Hi Attached a patch to allow users to specify the core module fitted to their integrator board.
Please inform me of any defects found.
CHANGELOG: * Patch by Peter Pearse, 2 Feb 2005 - add core module targets - add ARM946E cpu support - remap memory to 0x00000000
Notes ----- a) Provides targets for all supported Core Modules - targets are of the form integrator<type>_CM<id>_config Examples make integratorap_CM946E_S make integratorcp_CM920T_config
b) Previous targets integegratorcp, integratorap retained.
c) Tested to build with MAKEALL arm (trab & omap2420h fail) integratorcp integratorcp_CM926EJ_S_config integratorcp_CM966E_S_config
d) Tested to boot linux & save environment on Integrator/CP CM926EJ-S in all three boot combinations Run ARM Boot Monitor then manually run U-Boot from user flash Run ARM Boot Monitor, auto-switch to U-Boot from user flash Run U-Boot direct from user flash i.e. NO ARM Boot Monitor
e) Patched against head at 2 Feb 2005
f) Based on the patches submitted by:: - Shawn Jin (arm946e) - Jean-Paul Saman (remap)
Regards Peter ------------------------ Peter.Pearse@arm.com -------------------------
In message 89A528FE6DB0FA44877BB2F05B84671801C12D3C@ZIPPY.Emea.Arm.com you wrote:
Attached a patch to allow users to specify the core module fittedto their integrator board.
...
f) Based on the patches submitted by::
- Shawn Jin (arm946e)
- Jean-Paul Saman (remap)
Can you please indicate which exact patches you are referring to (date, subject)? Does this mean that the original patches, as far as not merged into the main tree yet, can be considered as obsolete?
Best regards,
Wolfgang Denk
In message 89A528FE6DB0FA44877BB2F05B84671801C12D3C@ZIPPY.Emea.Arm.com you wrote:
Please inform me of any defects found.
See below :-(
CHANGELOG:
- Patch by Peter Pearse, 2 Feb 2005
- add core module targets
- add ARM946E cpu support
- remap memory to 0x00000000
I finally added this patch, but just because it's been on my queue for so long without any real progress. I hope this is the easiest way to get things going.
But PLEASE don't even think of submitting such a monster again.
Most of your files violate the Coding Style. Trailing white space, indentation, etc.
What you do tho the Makefile is horror. Adding 170+ lines just for a few boards? There should be a cleaner way! Please provide a (incremental) patch to get rid of this mess! The Makefile is a Makefile, and no place to add hundrets of lines of source code.
Your board config names are unacceptable. "integratorcp_CM922T_XA10". Who is supposed to type something like this? Please provide a (incremental) patch to use sensible, *much* shorter names. Instead of "integratorcp_CM922T_XA10" it should be sufficient to write "cm922t_xa10", right?
Best regards,
Wolfgang Denk
participants (2)
-
Peter Pearse -
Wolfgang Denk