[U-Boot] Build failure for ARM devices

Hi,
Today when I have rebased all my patches to latest denx/master, I have observed that the following commit has broken the build for ARM family of devices (in my case it's OMAP3). I have patch fixing this issue, which I will submit shortly.
Commit - =================== commit 84b5e8022ef62b68df360392a55c4fc2f2e568d7 Author: Wolfgang Denk wd@denx.de Date: Fri Jul 29 14:42:18 2011 +0200
Constify getenv(), setenv() and hash code functions
This is needed to get rid of build warnings like
main.c:311: warning: passing argument 2 of 'setenv' discards qualifiers from pointer target type
which result from commit 09c2e90 "unify version_string".
Signed-off-by: Wolfgang Denk wd@denx.de Cc: Andreas Bie<DF>mann andreas.devel@googlemail.com
Error log - =================
arm-none-linux-gnueabi-gcc -DDO_DEPS_ONLY \ -g -Os -fno-common -ffixed-r8 -msoft-float -D__KERNEL__ -DCONFIG_SYS_TEXT_BASE=0x80008000 -I/db/psp_git/users/a0393758/omap-uboot-denx/include -fno-builtin -ffreestanding -nostdinc -isystem /opt/codesourcery/2010q1-202/bin/../lib/gcc/arm-none-linux-gnueabi/4.4.1/include -pipe -DCONFIG_ARM -D__ARM__ -marm -mabi=aapcs-linux -mno-thumb-interwork -march=armv5 -Wall -Wstrict-prototypes -fno-stack-protector -Wno-format-nonliteral -Wno-format-security \ -o lib/asm-offsets.s lib/asm-offsets.c -c -S In file included from /db/psp_git/users/a0393758/omap-uboot-denx/include/common.h:276, from lib/asm-offsets.c:18: /db/psp_git/users/a0393758/omap-uboot-denx/include/asm/u-boot-arm.h:66: error: conflicting types for 'setenv' /db/psp_git/users/a0393758/omap-uboot-denx/include/common.h:271: note: previous declaration of 'setenv' was here make: *** [lib/asm-offsets.s] Error 1
Thanks, Vaibhav

Hello Vaibhav,
Hiremath, Vaibhav wrote:
Hi,
Today when I have rebased all my patches to latest denx/master, I have observed that the following commit has broken the build for ARM family of devices (in my case it's OMAP3). I have patch fixing this issue, which I will submit shortly.
see fix from Wolfgang here:
http://patchwork.ozlabs.org/patch/107519/
bye, Heiko

-----Original Message----- From: Heiko Schocher [mailto:hs@denx.de] Sent: Monday, August 01, 2011 3:09 PM To: Hiremath, Vaibhav Cc: U-Boot@lists.denx.de Subject: Re: [U-Boot] Build failure for ARM devices
Hello Vaibhav,
Hiremath, Vaibhav wrote:
Hi,
Today when I have rebased all my patches to latest denx/master, I have
observed that the following commit has broken the build for ARM family of devices (in my case it's OMAP3). I have patch fixing this issue, which I will submit shortly.
see fix from Wolfgang here:
[Hiremath, Vaibhav] Hmmm ok. Thanks for pointing to this.
Thanks, Vaibhav
bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Dear "Hiremath, Vaibhav",
In message 19F8576C6E063C45BE387C64729E739404E398E5BF@dbde02.ent.ti.com you wrote:
Hi,
Today when I have rebased all my patches to latest denx/master, I have observed that the following commit has broken the build for ARM family of devices (in my case it's OMAP3). I have patch fixing this issue, which I will submit shortly.
Thanks, but please don't. We already have patches for this from 4 different people.
Best regards,
Wolfgang Denk
participants (3)
-
Heiko Schocher
-
Hiremath, Vaibhav
-
Wolfgang Denk