[U-Boot] [PATCH] sf: update sst25wf040b flash params

From: Haikun Wang Haikun.Wang@freescale.com
sst25wf040b doesn't support Auto Address Increment Programming command. Remove SST_WR flag.
Signed-off-by: Haikun Wang B53464@freescale.com --- drivers/mtd/spi/sf_params.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c index c12e8c6..283087a 100644 --- a/drivers/mtd/spi/sf_params.c +++ b/drivers/mtd/spi/sf_params.c @@ -100,7 +100,8 @@ const struct spi_flash_params spi_flash_params_table[] = { {"SST25WF010", 0xbf2502, 0x0, 64 * 1024, 2, RD_NORM, SECT_4K | SST_WR}, {"SST25WF020", 0xbf2503, 0x0, 64 * 1024, 4, RD_NORM, SECT_4K | SST_WR}, {"SST25WF040", 0xbf2504, 0x0, 64 * 1024, 8, RD_NORM, SECT_4K | SST_WR}, - {"SST25WF040B", 0x621613, 0x0, 64 * 1024, 8, RD_NORM, SECT_4K | SST_WR}, + {"SST25WF040B", 0x621613, 0x0, 64 * 1024, + 8, RD_NORM, SECT_4K}, {"SST25WF080", 0xbf2505, 0x0, 64 * 1024, 16, RD_NORM, SECT_4K | SST_WR}, #endif #ifdef CONFIG_SPI_FLASH_WINBOND /* WINBOND */

On 26 June 2015 at 17:27, Haikun Wang haikun.wang@freescale.com wrote:
From: Haikun Wang Haikun.Wang@freescale.com
sst25wf040b doesn't support Auto Address Increment Programming command. Remove SST_WR flag.
Signed-off-by: Haikun Wang B53464@freescale.com
drivers/mtd/spi/sf_params.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c index c12e8c6..283087a 100644 --- a/drivers/mtd/spi/sf_params.c +++ b/drivers/mtd/spi/sf_params.c @@ -100,7 +100,8 @@ const struct spi_flash_params spi_flash_params_table[] = { {"SST25WF010", 0xbf2502, 0x0, 64 * 1024, 2, RD_NORM, SECT_4K | SST_WR}, {"SST25WF020", 0xbf2503, 0x0, 64 * 1024, 4, RD_NORM, SECT_4K | SST_WR}, {"SST25WF040", 0xbf2504, 0x0, 64 * 1024, 8, RD_NORM, SECT_4K | SST_WR},
{"SST25WF040B", 0x621613, 0x0, 64 * 1024, 8, RD_NORM, SECT_4K | SST_WR},
{"SST25WF040B", 0x621613, 0x0, 64 * 1024,
8, RD_NORM, SECT_4K},
Please check - extran line is not required?
{"SST25WF080", 0xbf2505, 0x0, 64 * 1024, 16, RD_NORM, SECT_4K | SST_WR},
#endif
#ifdef CONFIG_SPI_FLASH_WINBOND /* WINBOND */
1.9.1
thanks!

On 6/27/2015 3:35 AM, Jagan Teki wrote:
On 26 June 2015 at 17:27, Haikun Wang haikun.wang@freescale.com wrote:
From: Haikun Wang Haikun.Wang@freescale.com
sst25wf040b doesn't support Auto Address Increment Programming command. Remove SST_WR flag.
Signed-off-by: Haikun Wang B53464@freescale.com
drivers/mtd/spi/sf_params.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c index c12e8c6..283087a 100644 --- a/drivers/mtd/spi/sf_params.c +++ b/drivers/mtd/spi/sf_params.c @@ -100,7 +100,8 @@ const struct spi_flash_params spi_flash_params_table[] = { {"SST25WF010", 0xbf2502, 0x0, 64 * 1024, 2, RD_NORM, SECT_4K | SST_WR}, {"SST25WF020", 0xbf2503, 0x0, 64 * 1024, 4, RD_NORM, SECT_4K | SST_WR}, {"SST25WF040", 0xbf2504, 0x0, 64 * 1024, 8, RD_NORM, SECT_4K | SST_WR},
{"SST25WF040B", 0x621613, 0x0, 64 * 1024, 8, RD_NORM, SECT_4K | SST_WR},
{"SST25WF040B", 0x621613, 0x0, 64 * 1024,
8, RD_NORM, SECT_4K},
Please check - extran line is not required?
If I put them in one line, checkpatch will report a warning: WARNING: line over 80 characters.
{"SST25WF080", 0xbf2505, 0x0, 64 * 1024, 16, RD_NORM, SECT_4K | SST_WR},
#endif
#ifdef CONFIG_SPI_FLASH_WINBOND /* WINBOND */
1.9.1
thanks!

On 29 June 2015 at 14:08, Wang Haikun Haikun.Wang@freescale.com wrote:
On 6/27/2015 3:35 AM, Jagan Teki wrote:
On 26 June 2015 at 17:27, Haikun Wang haikun.wang@freescale.com wrote:
From: Haikun Wang Haikun.Wang@freescale.com
sst25wf040b doesn't support Auto Address Increment Programming command. Remove SST_WR flag.
Signed-off-by: Haikun Wang B53464@freescale.com
drivers/mtd/spi/sf_params.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c index c12e8c6..283087a 100644 --- a/drivers/mtd/spi/sf_params.c +++ b/drivers/mtd/spi/sf_params.c @@ -100,7 +100,8 @@ const struct spi_flash_params spi_flash_params_table[] = { {"SST25WF010", 0xbf2502, 0x0, 64 * 1024, 2, RD_NORM, SECT_4K | SST_WR}, {"SST25WF020", 0xbf2503, 0x0, 64 * 1024, 4, RD_NORM, SECT_4K | SST_WR}, {"SST25WF040", 0xbf2504, 0x0, 64 * 1024, 8, RD_NORM, SECT_4K | SST_WR},
{"SST25WF040B", 0x621613, 0x0, 64 * 1024, 8, RD_NORM, SECT_4K | SST_WR},
{"SST25WF040B", 0x621613, 0x0, 64 * 1024,
8, RD_NORM, SECT_4K},
Please check - extran line is not required?
If I put them in one line, checkpatch will report a warning: WARNING: line over 80 characters.
No issues it's id table struct need to be readable.
{"SST25WF080", 0xbf2505, 0x0, 64 * 1024, 16, RD_NORM, SECT_4K | SST_WR},
#endif
#ifdef CONFIG_SPI_FLASH_WINBOND /* WINBOND */
1.9.1
thanks!
participants (3)
-
Haikun Wang
-
Jagan Teki
-
Wang Haikun