[U-Boot] [PATCH] tools: Correct python building host tools

When we have python building tools for the host it will not check HOSTXX variables but only XX variables, for example LDFLAGS and not HOSTLDFLAGS.
Cc: Simon Glass sjg@chromium.org Reported-by: Heiko Schocher hs@denx.de Fixes: 1905c8fc711a ("build: Always build the libfdt python module") Signed-off-by: Tom Rini trini@konsulko.com --- tools/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/Makefile b/tools/Makefile index a609d058595b..cefcedf683ca 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -117,7 +117,8 @@ _libfdt.so-sharedobjs += $(LIBFDT_OBJS) libfdt:
tools/_libfdt.so: $(patsubst %.o,%.c,$(LIBFDT_OBJS)) tools/libfdt_wrap.c - python $(srctree)/lib/libfdt/setup.py "$(_hostc_flags)" $^ + LDFLAGS="$(HOSTLDFLAGS)" python $(srctree)/lib/libfdt/setup.py \ + "$(_hostc_flags)" $^ mv _libfdt.so $@
tools/libfdt_wrap.c: $(srctree)/lib/libfdt/libfdt.swig

On 23 January 2017 at 09:44, Tom Rini trini@konsulko.com wrote:
When we have python building tools for the host it will not check HOSTXX variables but only XX variables, for example LDFLAGS and not HOSTLDFLAGS.
Cc: Simon Glass sjg@chromium.org Reported-by: Heiko Schocher hs@denx.de Fixes: 1905c8fc711a ("build: Always build the libfdt python module") Signed-off-by: Tom Rini trini@konsulko.com
tools/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/Makefile b/tools/Makefile index a609d058595b..cefcedf683ca 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -117,7 +117,8 @@ _libfdt.so-sharedobjs += $(LIBFDT_OBJS) libfdt:
tools/_libfdt.so: $(patsubst %.o,%.c,$(LIBFDT_OBJS)) tools/libfdt_wrap.c
python $(srctree)/lib/libfdt/setup.py "$(_hostc_flags)" $^
LDFLAGS="$(HOSTLDFLAGS)" python $(srctree)/lib/libfdt/setup.py \
"$(_hostc_flags)" $^ mv _libfdt.so $@
tools/libfdt_wrap.c: $(srctree)/lib/libfdt/libfdt.swig
1.9.1
Reviewed-by: Simon Glass sjg@chromium.org Tested on 5 PowerPC builds: Tested-by: Simon Glass sjg@chromium.org
Thanks Tom!
- Simon

Hello Tom,
Am 23.01.2017 um 17:44 schrieb Tom Rini:
When we have python building tools for the host it will not check HOSTXX variables but only XX variables, for example LDFLAGS and not HOSTLDFLAGS.
Cc: Simon Glass sjg@chromium.org Reported-by: Heiko Schocher hs@denx.de Fixes: 1905c8fc711a ("build: Always build the libfdt python module") Signed-off-by: Tom Rini trini@konsulko.com
tools/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Thanks! This fixes the build for the tqm5200 board.
Tested-by: Heiko Schocher hs@denx.de
bye, Heiko
diff --git a/tools/Makefile b/tools/Makefile index a609d058595b..cefcedf683ca 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -117,7 +117,8 @@ _libfdt.so-sharedobjs += $(LIBFDT_OBJS) libfdt:
tools/_libfdt.so: $(patsubst %.o,%.c,$(LIBFDT_OBJS)) tools/libfdt_wrap.c
- python $(srctree)/lib/libfdt/setup.py "$(_hostc_flags)" $^
LDFLAGS="$(HOSTLDFLAGS)" python $(srctree)/lib/libfdt/setup.py \
"$(_hostc_flags)" $^
mv _libfdt.so $@
tools/libfdt_wrap.c: $(srctree)/lib/libfdt/libfdt.swig

On Mon, Jan 23, 2017 at 11:44:33AM -0500, Tom Rini wrote:
When we have python building tools for the host it will not check HOSTXX variables but only XX variables, for example LDFLAGS and not HOSTLDFLAGS.
Cc: Simon Glass sjg@chromium.org Reported-by: Heiko Schocher hs@denx.de Fixes: 1905c8fc711a ("build: Always build the libfdt python module") Signed-off-by: Tom Rini trini@konsulko.com Reviewed-by: Simon Glass sjg@chromium.org Tested-by: Simon Glass sjg@chromium.org Tested-by: Heiko Schocher hs@denx.de
Applied to u-boot/master, thanks!
participants (3)
-
Heiko Schocher
-
Simon Glass
-
Tom Rini