[PATCH] env: efi: fix a wrong address dereference

From: AKASHI Takahiro takahiro.akashi@linaro.org
Probably, a pointer to a variable in an inner block should not be exposed to an outer block.
Fixes: c70f44817d46 ("efi_loader: simplify 'printenv -e'") Signed-off-by: AKASHI Takahiro takahiro.akashi@linaro.org [trini: Don't make guid const now] Signed-off-by: Tom Rini trini@konsulko.com --- cmd/nvedit_efi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/cmd/nvedit_efi.c b/cmd/nvedit_efi.c index 094c0e809870..d5e93827e45c 100644 --- a/cmd/nvedit_efi.c +++ b/cmd/nvedit_efi.c @@ -241,6 +241,7 @@ int do_env_print_efi(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]) { const efi_guid_t *guid_p = NULL; + efi_guid_t guid; bool verbose = true; efi_status_t ret;
@@ -254,8 +255,6 @@ int do_env_print_efi(struct cmd_tbl *cmdtp, int flag, int argc,
for (argc--, argv++; argc > 0 && argv[0][0] == '-'; argc--, argv++) { if (!strcmp(argv[0], "-guid")) { - efi_guid_t guid; - if (argc == 1) return CMD_RET_USAGE; argc--;

On Sat, Jul 03, 2021 at 10:25:22AM -0400, Tom Rini wrote:
From: AKASHI Takahiro takahiro.akashi@linaro.org
Probably, a pointer to a variable in an inner block should not be exposed to an outer block.
Fixes: c70f44817d46 ("efi_loader: simplify 'printenv -e'") Signed-off-by: AKASHI Takahiro takahiro.akashi@linaro.org [trini: Don't make guid const now] Signed-off-by: Tom Rini trini@konsulko.com
Applied to u-boot/master, thanks!
participants (1)
-
Tom Rini