[PATCH v2 0/1] arch: zynqmp: Make zynqmp command more accessible.
While working on a third-party board using a ZynqMP, I was unable to use the zynqmp command even with the proper config definitions. While that command appears tied to the architecture, it was being included based on the board selection instead.
This patch series moves the command to be accessible to any ZynqMP arch based board.
Changes since v1: - Squash into a single commit - Command is now moved into arch tree instead of cmd tree
The zynqmp cmds.c is currently tied to the board but the commands contained within are more closely tied to the architecture. To allow usage of those commands when the architecture is ZynqMP but the board is not, this change moves the cmds into the arch/ tree.
The source file is renamed to zynqmp.c to reflect the command name as well.
Signed-off-by: Charlie Johnston charlie.johnston@loftorbital.com --- arch/arm/mach-zynqmp/Kconfig | 13 ++++++++++++- arch/arm/mach-zynqmp/Makefile | 4 ++++ .../cmds.c => arch/arm/mach-zynqmp/zynqmp.c | 0 board/xilinx/zynqmp/Kconfig | 19 ------------------- board/xilinx/zynqmp/Makefile | 4 ---- 5 files changed, 16 insertions(+), 24 deletions(-) rename board/xilinx/zynqmp/cmds.c => arch/arm/mach-zynqmp/zynqmp.c (100%) delete mode 100644 board/xilinx/zynqmp/Kconfig
diff --git a/arch/arm/mach-zynqmp/Kconfig b/arch/arm/mach-zynqmp/Kconfig index 6a7be0b427..ed0aa29c12 100644 --- a/arch/arm/mach-zynqmp/Kconfig +++ b/arch/arm/mach-zynqmp/Kconfig @@ -212,7 +212,18 @@ config SD1_LSHFT_MODE
endchoice
+config CMD_ZYNQMP + bool "Enable ZynqMP specific commands" + depends on ZYNQMP_FIRMWARE + default y + help + Enable ZynqMP specific commands like "zynqmp secure" + which is used for zynqmp secure image verification. + The secure image is a xilinx specific BOOT.BIN with + either authentication or encryption or both encryption + and authentication feature enabled while generating + BOOT.BIN using Xilinx bootgen tool. + source "board/xilinx/Kconfig" -source "board/xilinx/zynqmp/Kconfig"
endif diff --git a/arch/arm/mach-zynqmp/Makefile b/arch/arm/mach-zynqmp/Makefile index 8f897a37d1..38be1627ee 100644 --- a/arch/arm/mach-zynqmp/Makefile +++ b/arch/arm/mach-zynqmp/Makefile @@ -8,3 +8,7 @@ obj-$(CONFIG_MP) += mp.o obj-$(CONFIG_SPL_BUILD) += spl.o handoff.o psu_spl_init.o obj-$(CONFIG_SPL_ZYNQMP_DRAM_ECC_INIT) += ecc_spl_init.o obj-$(CONFIG_$(SPL_)ZYNQMP_PSU_INIT_ENABLED) += psu_spl_init.o + +ifndef CONFIG_SPL_BUILD +obj-$(CONFIG_CMD_ZYNQMP) += zynqmp.o +endif # !CONFIG_SPL_BUILD diff --git a/board/xilinx/zynqmp/cmds.c b/arch/arm/mach-zynqmp/zynqmp.c similarity index 100% rename from board/xilinx/zynqmp/cmds.c rename to arch/arm/mach-zynqmp/zynqmp.c diff --git a/board/xilinx/zynqmp/Kconfig b/board/xilinx/zynqmp/Kconfig deleted file mode 100644 index ffa2f0215d..0000000000 --- a/board/xilinx/zynqmp/Kconfig +++ /dev/null @@ -1,19 +0,0 @@ -# Copyright (c) 2018, Xilinx, Inc. -# -# SPDX-License-Identifier: GPL-2.0 - -if ARCH_ZYNQMP - -config CMD_ZYNQMP - bool "Enable ZynqMP specific commands" - depends on ZYNQMP_FIRMWARE - default y - help - Enable ZynqMP specific commands like "zynqmp secure" - which is used for zynqmp secure image verification. - The secure image is a xilinx specific BOOT.BIN with - either authentication or encryption or both encryption - and authentication feature enabled while generating - BOOT.BIN using Xilinx bootgen tool. - -endif diff --git a/board/xilinx/zynqmp/Makefile b/board/xilinx/zynqmp/Makefile index 204e4fadf0..9ab50eca40 100644 --- a/board/xilinx/zynqmp/Makefile +++ b/board/xilinx/zynqmp/Makefile @@ -40,10 +40,6 @@ $(obj)/pm_cfg_obj.o: $(shell cd $(srctree); readlink -f $(CONFIG_ZYNQMP_SPL_PM_C endif endif
-ifndef CONFIG_SPL_BUILD -obj-$(CONFIG_CMD_ZYNQMP) += cmds.o -endif - # Suppress "warning: function declaration isn't a prototype" CFLAGS_REMOVE_psu_init_gpl.o := -Wstrict-prototypes
On 4/10/24 21:50, Charlie Johnston wrote:
While working on a third-party board using a ZynqMP, I was unable to use the zynqmp command even with the proper config definitions. While that command appears tied to the architecture, it was being included based on the board selection instead.
This patch series moves the command to be accessible to any ZynqMP arch based board.
Changes since v1:
- Squash into a single commit
- Command is now moved into arch tree instead of cmd tree
Applied. M
participants (2)
-
Charlie Johnston -
Michal Simek